[HIVE-20807] Refactor LlapStatusServiceDriver - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.0
Fix Version/s: 4.0.0-alpha-1
Component/s: Hive
Labels:
None

Description

LlapStatusServiceDriver is the class used to determine if LLAP has started. The following problems should be solved by refactoring:

1. The main class is more than 800 lines long,should be cut into multiple smaller classes.
2. The current design makes it extremely hard to write unit tests.
3. There are some overcomplicated, over-engineered parts of the code.
4. Most of the code is under org.apache.hadoop.hive.llap.cli, but some parts are under org.apache.hadoop.hive.llap.cli.status. The whole program could be moved to the latter.
5. LlapStatusHelpers serves as a class for holding classes, which doesn't make much sense.