[HIVE-20807] Refactor LlapStatusServiceDriver

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Hive
• Assignee: Miklos Gergely
• Reporter: Miklos Gergely
• Created: 25/Oct/18 13:56
• Updated: 17/Nov/22 08:54
• Resolved: 12/Nov/18 23:50

Description

LlapStatusServiceDriver is the class used to determine if LLAP has started. The following problems should be solved by refactoring:

1. The main class is more than 800 lines long,should be cut into multiple smaller classes.
2. The current design makes it extremely hard to write unit tests.
3. There are some overcomplicated, over-engineered parts of the code.
4. Most of the code is under org.apache.hadoop.hive.llap.cli, but some parts are under org.apache.hadoop.hive.llap.cli.status. The whole program could be moved to the latter.
5. LlapStatusHelpers serves as a class for holding classes, which doesn't make much sense.

Issue Links

• links to: Review Board