Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20159

Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin

    XMLWordPrintableJSON

    Details

    • Release Note:
      Included slf4j logger in the ConditionalResolverSkewJoin.java in the IOException part

      Description

      https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121

          } catch (IOException e) {
            e.printStackTrace();
          }
      

      Introduce an SLF4J logger to this class and print a WARN level log message if the IOException from Utilities.listStatusIfExists is generated. I suggest WARN because the entire operation doesn't fail if this error happens. It continues on its way with the data that it was able to collect. I'm not sure if this is the intended behavior, but for now, a helpful warning message in the logging would be better.

        Attachments

        1. HIVE.20159.patch
          1 kB
          Mani M
        2. HIVE.20159.02.patch
          1 kB
          Mani M
        3. HIVE-20159.3.patch
          1 kB
          David Mollitor
        4. HIVE-20159.4.patch
          1 kB
          David Mollitor

          Issue Links

            Activity

              People

              • Assignee:
                rmsmani@gmail.com Mani M
                Reporter:
                belugabehr David Mollitor
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: