[HIVE-20159] Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0, 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Query Planning
• Labels: logging newbie noob
• Release Note: Included slf4j logger in the ConditionalResolverSkewJoin.java in the IOException part
• Assignee: Mani M
• Reporter: David Mollitor
• Created: 12/Jul/18 22:33
• Updated: 17/Nov/22 08:54
• Resolved: 08/Jan/19 11:19

Description

https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121

    } catch (IOException e) {
      e.printStackTrace();
    }

Introduce an SLF4J logger to this class and print a WARN level log message if the IOException from Utilities.listStatusIfExists is generated. I suggest WARN because the entire operation doesn't fail if this error happens. It continues on its way with the data that it was able to collect. I'm not sure if this is the intended behavior, but for now, a helpful warning message in the logging would be better.

Issue Links

• is cloned by: HIVE-21099 Do Not Print StackTraces to STDERR in ConditionalResolverMergeFiles
• links to: Review Request