[HIVE-19076] Fix NPE and TApplicationException in function related HiveMetastore methods - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.0.0-alpha-1
Component/s: None
Labels:
None

Description

The TestFunctions tests revealed that NPE is thrown in some cases. These NPEs could be prevented with a simple null check and a MetaException with a proper error message should be thrown instead.
Example: NPE is thrown in the following test cases

testCreateFunctionNullFunctionName
testCreateFunctionNullDatabaseName
testCreateFunctionNullOwnerType
testCreateFunctionNullFunctionType
testGetFunctionNullDatabase
testDropFunctionNullDatabase
testDropFunctionNullFunctionName
testAlterFunctionNullDatabase
testAlterFunctionNullFunctionName
testAlterFunctionNullFunction
testAlterFunctionNullFunctionNameInNew
testAlterFunctionNullDatabaseNameInNew
testAlterFunctionNullOwnerTypeInNew
testAlterFunctionNullFunctionTypeInNew

Also there are some alter function tests where InvalidObjectException is thrown with Embedded MetaStore, but TApplicationException it thrown with Remote MetaStore. The reason is that the InvalidObjectException is not defined for the alter_function method in the thrift interface, so we got the TApplicationException when the InvalidObjectException was thrown. In these cases the InvalidObjectException could be handled on the server side and re-throw it as a MetaException