[HIVE-19076] Fix NPE and TApplicationException in function related HiveMetastore methods - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.0.0-alpha-1
Component/s: None
Labels:
None

Description

The TestFunctions tests revealed that NPE is thrown in some cases. These NPEs could be prevented with a simple null check and a MetaException with a proper error message should be thrown instead.
Example: NPE is thrown in the following test cases

testCreateFunctionNullFunctionName
testCreateFunctionNullDatabaseName
testCreateFunctionNullOwnerType
testCreateFunctionNullFunctionType
testGetFunctionNullDatabase
testDropFunctionNullDatabase
testDropFunctionNullFunctionName
testAlterFunctionNullDatabase
testAlterFunctionNullFunctionName
testAlterFunctionNullFunction
testAlterFunctionNullFunctionNameInNew
testAlterFunctionNullDatabaseNameInNew
testAlterFunctionNullOwnerTypeInNew
testAlterFunctionNullFunctionTypeInNew

Also there are some alter function tests where InvalidObjectException is thrown with Embedded MetaStore, but TApplicationException it thrown with Remote MetaStore. The reason is that the InvalidObjectException is not defined for the alter_function method in the thrift interface, so we got the TApplicationException when the InvalidObjectException was thrown. In these cases the InvalidObjectException could be handled on the server side and re-throw it as a MetaException

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

HIVE-19076.1.patch
29/Mar/18 12:50
20 kB
Marta Kuczora
HIVE-19076.2.patch
03/Apr/18 08:56
20 kB
Marta Kuczora
HIVE-19076.3.patch
05/Apr/18 13:42
21 kB
Marta Kuczora

Issue Links

links to

Review

Activity

People

Assignee:: Marta Kuczora

Reporter:: Marta Kuczora

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 29/Mar/18 12:46

Updated:: 17/Nov/22 08:55

Resolved:: 10/Apr/18 13:49