Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • None
    • None

    Description

      I had added these without much thought when writing the metrics-framework to test out the concept.

      Looking back, these actually need of more investigation, as some are actually wrong or at least do not add much value. Wrong is the active-transaction, as actually each ObjectStore is a thread-local, and an aggregate number is what was meant. Open/committed/rollback need some investigation what really helps.

      Goal is to remove these before the release to reduce confusion to users.

      Attachments

        1. HIVE-12525.patch
          5 kB
          Szehon Ho

        Activity

          szehon Szehon Ho added a comment -

          jxiang can you help take a quick look? I wanted to remove some cleanup some metrics before release.

          szehon Szehon Ho added a comment - jxiang can you help take a quick look? I wanted to remove some cleanup some metrics before release.
          jxiang Jimmy Xiang added a comment -

          +1

          jxiang Jimmy Xiang added a comment - +1
          hiveqa Hive QA added a comment -

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12774421/HIVE-12525.patch

          SUCCESS: +1 due to 1 test(s) being added or modified.

          ERROR: -1 due to 4 failed/errored test(s), 9865 tests executed
          Failed tests:

          TestHWISessionManager - did not produce a TEST-*.xml file
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
          org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testGetPartitionSpecs_WithAndWithoutPartitionGrouping
          org.apache.hive.jdbc.TestSSL.testSSLVersion
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6159/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6159/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6159/

          Messages:

          Executing org.apache.hive.ptest.execution.TestCheckPhase
          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 4 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12774421 - PreCommit-HIVE-TRUNK-Build

          hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12774421/HIVE-12525.patch SUCCESS: +1 due to 1 test(s) being added or modified. ERROR: -1 due to 4 failed/errored test(s), 9865 tests executed Failed tests: TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testGetPartitionSpecs_WithAndWithoutPartitionGrouping org.apache.hive.jdbc.TestSSL.testSSLVersion Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6159/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6159/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6159/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed This message is automatically generated. ATTACHMENT ID: 12774421 - PreCommit-HIVE-TRUNK-Build

          Should this be committed?

          sershe Sergey Shelukhin added a comment - Should this be committed?
          szehon Szehon Ho added a comment -

          Yes sorry was on vacation.

          Test failures not related, committed to master, thanks Jimmy for review.

          szehon Szehon Ho added a comment - Yes sorry was on vacation. Test failures not related, committed to master, thanks Jimmy for review.

          Master is now 2.1... please backport if needed

          sershe Sergey Shelukhin added a comment - Master is now 2.1... please backport if needed
          szehon Szehon Ho added a comment -

          OK missed that, backported to 2.0 as well.

          szehon Szehon Ho added a comment - OK missed that, backported to 2.0 as well.
          leftyl Lefty Leverenz added a comment -

          szehon, this also needs to be committed to branch-1.

          leftyl Lefty Leverenz added a comment - szehon , this also needs to be committed to branch-1.

          People

            szehon Szehon Ho
            szehon Szehon Ho
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: