[HIVE-12315] vectorization_short_regress.q has a wrong result issue for a double calculation

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.14.0, 1.0.1, 1.1.1, 1.2.1, 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Vectorization

Release Note

HIVE-12315: Fix Vectorized double divide by zero (Gopal V, reviewed by Matt McCline)

• Assignee: Gopal Vijayaraghavan
• Reporter: Matt McCline
• Created: 02/Nov/15 18:05
• Updated: 16/Feb/16 23:52
• Resolved: 06/Nov/15 01:18

Description

I suspect it is related to the fancy optimizations in vectorized double divide that try to quickly process the batch without checking each row for null.

 public static void setNullAndDivBy0DataEntriesDouble(
      DoubleColumnVector v, boolean selectedInUse, int[] sel, int n, DoubleColumnVector denoms) {
    assert v.isRepeating || !denoms.isRepeating;
    v.noNulls = false;
    double[] vector = denoms.vector;
    if (v.isRepeating && (v.isNull[0] = (v.isNull[0] || vector[0] == 0))) {
      v.vector[0] = DoubleColumnVector.NULL_VALUE;