Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-12315

vectorization_short_regress.q has a wrong result issue for a double calculation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.14.0, 1.0.1, 1.1.1, 1.2.1, 2.0.0
    • Fix Version/s: 1.3.0, 2.0.0
    • Component/s: Vectorization
    • Labels:
      None
    • Release Note:
      Hide
      HIVE-12315: Fix Vectorized double divide by zero (Gopal V, reviewed by Matt McCline)
      Show
      HIVE-12315 : Fix Vectorized double divide by zero (Gopal V, reviewed by Matt McCline)

      Description

      I suspect it is related to the fancy optimizations in vectorized double divide that try to quickly process the batch without checking each row for null.

       public static void setNullAndDivBy0DataEntriesDouble(
            DoubleColumnVector v, boolean selectedInUse, int[] sel, int n, DoubleColumnVector denoms) {
          assert v.isRepeating || !denoms.isRepeating;
          v.noNulls = false;
          double[] vector = denoms.vector;
          if (v.isRepeating && (v.isNull[0] = (v.isNull[0] || vector[0] == 0))) {
            v.vector[0] = DoubleColumnVector.NULL_VALUE;
      

        Attachments

        1. HIVE-12315.1.patch
          3 kB
          Gopal V
        2. vectorization_short_regress_bug.q
          0.6 kB
          Matt McCline

          Activity

            People

            • Assignee:
              gopalv Gopal V
              Reporter:
              mmccline Matt McCline
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: