[HDFS-9919] TestStandbyCheckpoints#testNonPrimarySBNUploadFSImage waitForCheckpoint incorrectly

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha1
• Component/s: test
• Assignee: Yiqun Lin
• Reporter: Yiqun Lin
• Created: 08/Mar/16 11:36
• Updated: 12/May/16 18:13
• Resolved: 08/Mar/16 19:54

Description

In HDFS-9787, it sloved the problem that standby NNs can upload FSImage to ANN after become non-primary standby NN. But in its unit test, it seems there is a small problem. when ANN change state to standby and standby nns should do a checkpoint. And in test, it makes a checpoint check as follow:

    for (int i = 0; i < NUM_NNS; i++) {
      // Once the standby catches up, it should do a checkpoint
      // and save to local directories.
      HATestUtil.waitForCheckpoint(cluster, 1, ImmutableList.of(12));
    }

And in these code, the nnIdx for waitForCheckpoint is always 1, not i. It seems there is no need to check one standby nn's checkpoint NUM_NNS times.