Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9787

SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer changed to false.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: ha
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer become false.
      Here is the logic to check if upload FSImage or not.
      In StandbyCheckpointer.java
      boolean sendRequest = isPrimaryCheckPointer || secsSinceLast >= checkpointConf.getQuietPeriod();
      doCheckpoint(sendRequest);

      The sendRequest is always false if isPrimaryCheckPointer is false giving secsSinceLast (~checkpointPeriod) >= checkpointConf.getQuietPeriod() (checkpointPeriod * this.quietMultiplier(default value 1.5)) always returns false.

      1. HDFS-9787-v001.patch
        4 kB
        Guocui Mi
      2. HDFS-9787-v002.patch
        4 kB
        Guocui Mi
      3. HDFS-9787-v003.patch
        4 kB
        Guocui Mi
      4. HDFS-9787-v004.patch
        4 kB
        Guocui Mi

        Issue Links

          Activity

          Hide
          Guocui Guocui Mi added a comment -

          check time since last upload instead of time since last checkpoint.

          Show
          Guocui Guocui Mi added a comment - check time since last upload instead of time since last checkpoint.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Jesse Yates, do you mind taking a look at this?

          Show
          elgoiri Íñigo Goiri added a comment - Jesse Yates , do you mind taking a look at this?
          Hide
          jesse_yates Jesse Yates added a comment -

          I think I'll have some time tomorrow - adding it to my list

          Show
          jesse_yates Jesse Yates added a comment - I think I'll have some time tomorrow - adding it to my list
          Hide
          Guocui Guocui Mi added a comment -

          check last upload time instead of last check point time.

          Show
          Guocui Guocui Mi added a comment - check last upload time instead of last check point time.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thanks!

          Show
          elgoiri Íñigo Goiri added a comment - Thanks!
          Hide
          jesse_yates Jesse Yates added a comment -

          Taking a quick look, this would imply that the non-primary SNN never sends a checkpoint after the first time? A good test to ensure that this is the case is to start the NNs, wait until there primary SNN is selected and then remove it from the cluster. Are any more checkpoints sent to the ANN?

          My inclination is that you are correct, no (unless it takes a long time to build the checkpoint), but I'd like to hear if that's actually the case. I think the fix is to just set lastCheckpointTime in doCheckpoint() rather than after each loop iteration.

          Show
          jesse_yates Jesse Yates added a comment - Taking a quick look, this would imply that the non-primary SNN never sends a checkpoint after the first time? A good test to ensure that this is the case is to start the NNs, wait until there primary SNN is selected and then remove it from the cluster. Are any more checkpoints sent to the ANN? My inclination is that you are correct, no (unless it takes a long time to build the checkpoint), but I'd like to hear if that's actually the case. I think the fix is to just set lastCheckpointTime in doCheckpoint() rather than after each loop iteration.
          Hide
          jesse_yates Jesse Yates added a comment -

          I don't think you need a new variable - lastCheckpointTime is never used outside of the class and only used for for this check

          Show
          jesse_yates Jesse Yates added a comment - I don't think you need a new variable - lastCheckpointTime is never used outside of the class and only used for for this check
          Hide
          elgoiri Íñigo Goiri added a comment -

          Now that I see this, can it be the problem that we do:

          // Reset checkpoint time so that we don't always checkpoint
          // on startup.
          lastCheckpointTime = monotonicNow();
          

          And then:

          lastCheckpointTime = now;
          

          We'll do the test in our cluster anyway.

          Show
          elgoiri Íñigo Goiri added a comment - Now that I see this, can it be the problem that we do: // Reset checkpoint time so that we don't always checkpoint // on startup. lastCheckpointTime = monotonicNow(); And then: lastCheckpointTime = now; We'll do the test in our cluster anyway.
          Hide
          elgoiri Íñigo Goiri added a comment -

          My bad, this is right.
          We will test resetting the lastCheckpointTime in every loop.

          Show
          elgoiri Íñigo Goiri added a comment - My bad, this is right. We will test resetting the lastCheckpointTime in every loop.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 34s trunk passed
          +1 compile 0m 40s trunk passed with JDK v1.8.0_72
          +1 compile 0m 42s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_72
          +1 javac 0m 37s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_95
          +1 javac 0m 39s the patch passed
          -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
          -1 unit 62m 54s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 63m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          150m 22s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787193/HDFS-9786-v000.patch
          JIRA Issue HDFS-9787
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux df15285db7fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a7fce9a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14440/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14440/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 34s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_72 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 0s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 -1 unit 62m 54s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 63m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 150m 22s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787193/HDFS-9786-v000.patch JIRA Issue HDFS-9787 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux df15285db7fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7fce9a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14440/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14440/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Guocui Guocui Mi added a comment -

          >>> this would imply that the non-primary SNN never sends a checkpoint after the first time?
          It is true according to my observation.
          I am trying to add unittest to cover the scenario. Another two scenarios triggered in our cluster:
          1) PrimaryCheckpoint uploading fsimage failure due to ANN not available temporarily.
          2) Restart all NNs at same time.

          I afraid the proposal you shared can't work.
          1) set lastCheckpointTime before following code in doCheckpoint(): no difference between putting after each loop iteration.
          2) after following code in doCheckpoint() : Non-primary SNN will do checkpoint one by one continuously since lastCheckpointTime not get updated.
          if(!sendCheckpoint)

          { return; }
          Show
          Guocui Guocui Mi added a comment - >>> this would imply that the non-primary SNN never sends a checkpoint after the first time? It is true according to my observation. I am trying to add unittest to cover the scenario. Another two scenarios triggered in our cluster: 1) PrimaryCheckpoint uploading fsimage failure due to ANN not available temporarily. 2) Restart all NNs at same time. I afraid the proposal you shared can't work. 1) set lastCheckpointTime before following code in doCheckpoint(): no difference between putting after each loop iteration. 2) after following code in doCheckpoint() : Non-primary SNN will do checkpoint one by one continuously since lastCheckpointTime not get updated. if(!sendCheckpoint) { return; }
          Hide
          Guocui Guocui Mi added a comment -

          lastCheckpointTime is also used to check if it is necessary to do another checkpoint. we can't mix up last checkpoint time and last upload time in order to honor dfs.namenode.checkpoint.period
          FYI: else if (secsSinceLast >= checkpointConf.getPeriod()) {

          Show
          Guocui Guocui Mi added a comment - lastCheckpointTime is also used to check if it is necessary to do another checkpoint. we can't mix up last checkpoint time and last upload time in order to honor dfs.namenode.checkpoint.period FYI: else if (secsSinceLast >= checkpointConf.getPeriod()) {
          Hide
          jesse_yates Jesse Yates added a comment -

          The original solution was an attempting to catch the case where we don't flood the NN with checkpoint requests. Instead, maybe the better solution would be to do a small RPC to see when the latest image was uploaded. If it was uploaded the quietMultiplier beyond the checkpoint period, then we attempt to upload the checkpoint.

          Its a bit more work, but I think this more clearly lays out the intentions in the code, rather than obtaining the same effect, but without the overhead of actually sending the checkpoint along each time we want to find out if its behind.

          Show
          jesse_yates Jesse Yates added a comment - The original solution was an attempting to catch the case where we don't flood the NN with checkpoint requests. Instead, maybe the better solution would be to do a small RPC to see when the latest image was uploaded. If it was uploaded the quietMultiplier beyond the checkpoint period, then we attempt to upload the checkpoint. Its a bit more work, but I think this more clearly lays out the intentions in the code, rather than obtaining the same effect, but without the overhead of actually sending the checkpoint along each time we want to find out if its behind.
          Hide
          Guocui Guocui Mi added a comment -

          Agree with you on this, should create one new workitem for this.
          1> Non-primary SNNs check ANN checkpoint version via RPC;
          2> Check if checkpoint period beyond threshold
          Yes : try to upload checkpoint to ANN. become primary SNN if success.
          3> repeat 1> 2>.

          This patch is just a simple bug fix to make it work as expected first.

          Show
          Guocui Guocui Mi added a comment - Agree with you on this, should create one new workitem for this. 1> Non-primary SNNs check ANN checkpoint version via RPC; 2> Check if checkpoint period beyond threshold Yes : try to upload checkpoint to ANN. become primary SNN if success. 3> repeat 1> 2>. This patch is just a simple bug fix to make it work as expected first.
          Hide
          vinayrpet Vinayakumar B added a comment -

          The original solution was an attempting to catch the case where we don't flood the NN with checkpoint requests. Instead, maybe the better solution would be to do a small RPC to see when the latest image was uploaded. If it was uploaded the quietMultiplier beyond the checkpoint period, then we attempt to upload the checkpoint.
          Its a bit more work, but I think this more clearly lays out the intentions in the code, rather than obtaining the same effect, but without the overhead of actually sending the checkpoint along each time we want to find out if its behind.

          Yes, thats required to optimize the current approach. But I feel could be done in follow-up Jira,

          First lets fix the current bug. Agree?

          So, I see that patch fixes the issue mentioned in this Jira.
          +1 for the patch,

          Show
          vinayrpet Vinayakumar B added a comment - The original solution was an attempting to catch the case where we don't flood the NN with checkpoint requests. Instead, maybe the better solution would be to do a small RPC to see when the latest image was uploaded. If it was uploaded the quietMultiplier beyond the checkpoint period, then we attempt to upload the checkpoint. Its a bit more work, but I think this more clearly lays out the intentions in the code, rather than obtaining the same effect, but without the overhead of actually sending the checkpoint along each time we want to find out if its behind. Yes, thats required to optimize the current approach. But I feel could be done in follow-up Jira, First lets fix the current bug. Agree? So, I see that patch fixes the issue mentioned in this Jira. +1 for the patch,
          Hide
          vinayrpet Vinayakumar B added a comment -

          Oh!, Guocui Mi, could you cleanup the checkstyle warning?

          Show
          vinayrpet Vinayakumar B added a comment - Oh!, Guocui Mi , could you cleanup the checkstyle warning?
          Hide
          Guocui Guocui Mi added a comment -

          Sure, Just submit new patch with unittest.

          Show
          Guocui Guocui Mi added a comment - Sure, Just submit new patch with unittest.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 19s trunk passed
          +1 compile 0m 42s trunk passed with JDK v1.8.0_72
          +1 compile 0m 42s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 2m 5s trunk passed
          +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_72
          +1 javac 0m 37s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_95
          +1 javac 0m 41s the patch passed
          -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
          -1 unit 54m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 56m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 28s Patch does not generate ASF License warnings.
          136m 47s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787587/HDFS-9787-v002.patch
          JIRA Issue HDFS-9787
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b6af21060f2b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8fdef0b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14469/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14469/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 19s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_72 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 5s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 54m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 56m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 136m 47s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787587/HDFS-9787-v002.patch JIRA Issue HDFS-9787 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b6af21060f2b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fdef0b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14469/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14469/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14469/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 0m 37s trunk passed with JDK v1.8.0_72
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 3s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 49s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.8.0_72
          +1 javac 0m 34s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_95
          +1 javac 0m 38s the patch passed
          -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
          -1 unit 66m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 67m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          158m 44s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
            hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSClientRetries
            hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787583/HDFS-9787-v001.patch
          JIRA Issue HDFS-9787
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3b39913b0e87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 70c756d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14468/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14468/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 49s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 34s the patch passed with JDK v1.8.0_72 +1 javac 0m 34s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 66m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 67m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 158m 44s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode   hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSClientRetries   hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787583/HDFS-9787-v001.patch JIRA Issue HDFS-9787 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b39913b0e87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 70c756d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14468/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14468/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14468/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 27s trunk passed
          +1 compile 0m 37s trunk passed with JDK v1.8.0_72
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 42s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_72
          +1 javac 0m 35s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.7.0_95
          +1 javac 0m 37s the patch passed
          -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_95
          -1 unit 62m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 65m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          152m 1s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787611/HDFS-9787-v003.patch
          JIRA Issue HDFS-9787
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 18b98a9f8627 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8fdef0b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14472/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14472/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 27s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 42s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_72 +1 javac 0m 35s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_95 +1 javac 0m 37s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_95 -1 unit 62m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 65m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 152m 1s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787611/HDFS-9787-v003.patch JIRA Issue HDFS-9787 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18b98a9f8627 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fdef0b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14472/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14472/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14472/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 0m 40s trunk passed with JDK v1.8.0_72
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_72
          +1 javac 0m 37s the patch passed
          +1 compile 0m 40s the patch passed with JDK v1.7.0_95
          +1 javac 0m 40s the patch passed
          +1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95
          -1 unit 53m 54s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 50m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          128m 20s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader
            hadoop.hdfs.server.datanode.TestBlockScanner
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787633/HDFS-9787-v004.patch
          JIRA Issue HDFS-9787
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4ad408d30f95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2fb423e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14474/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14474/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 41s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_95 +1 javac 0m 40s the patch passed +1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95 -1 unit 53m 54s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 50m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 128m 20s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_95 Failed junit tests hadoop.fs.TestHdfsNativeCodeLoader Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787633/HDFS-9787-v004.patch JIRA Issue HDFS-9787 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4ad408d30f95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2fb423e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14474/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14474/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          The latest version looks good to me.
          I agree with Vinayakumar B on opening a new JIRA to add a new RPC call for fixing this properly and just post this one as a bugfix for the current approach.
          Jesse Yates thoughts?

          Show
          elgoiri Íñigo Goiri added a comment - The latest version looks good to me. I agree with Vinayakumar B on opening a new JIRA to add a new RPC call for fixing this properly and just post this one as a bugfix for the current approach. Jesse Yates thoughts?
          Hide
          jesse_yates Jesse Yates added a comment -

          Yeah, that's fine. As long as the committer is happy, I'm happy.

          Show
          jesse_yates Jesse Yates added a comment - Yeah, that's fine. As long as the committer is happy, I'm happy.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Show
          vinayrpet Vinayakumar B added a comment -
          Hide
          vinayrpet Vinayakumar B added a comment -

          Will commit the latest patch soon.

          Show
          vinayrpet Vinayakumar B added a comment - Will commit the latest patch soon.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk.
          Thanks all.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk. Thanks all.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9310 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9310/)
          HDFS-9787. SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer (vinayakumarb: rev 2536ece7b67ccfeac44314615a5f9dbe771ce373)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9310 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9310/ ) HDFS-9787 . SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer (vinayakumarb: rev 2536ece7b67ccfeac44314615a5f9dbe771ce373) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java

            People

            • Assignee:
              Guocui Guocui Mi
              Reporter:
              Guocui Guocui Mi
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development