Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9733

Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      To prepare for file checksum computing for striped files, this refactors the existing codes in Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum to make HDFS-8430 and HDFS-9694 easier.

      1. HDFS-9733-v1.patch
        35 kB
        Kai Zheng
      2. HDFS-9733-v2.patch
        51 kB
        Kai Zheng
      3. HDFS-9733-v3.patch
        52 kB
        Kai Zheng
      4. HDFS-9733-v4.patch
        53 kB
        Kai Zheng
      5. HDFS-9733-v5.patch
        52 kB
        Kai Zheng
      6. HDFS-9733-v6.patch
        52 kB
        Kai Zheng
      7. HDFS-9733-v7.patch
        56 kB
        Kai Zheng
      8. HDFS-9733-v8.patch
        56 kB
        Kai Zheng
      9. HDFS-9733-v9.patch
        56 kB
        Kai Zheng

        Issue Links

          Activity

          Hide
          drankye Kai Zheng added a comment -

          Uploaded the patch to do the refactoring.

          Show
          drankye Kai Zheng added a comment - Uploaded the patch to do the refactoring.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 6m 29s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_66
          +1 compile 6m 50s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 2m 29s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 5m 38s trunk passed
          +1 javadoc 2m 19s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 14s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 26s Maven dependency ordering for patch
          -1 mvninstall 0m 20s hadoop-hdfs-client in the patch failed.
          -1 mvninstall 0m 21s hadoop-hdfs in the patch failed.
          -1 compile 1m 4s root in the patch failed with JDK v1.8.0_66.
          -1 javac 1m 4s root in the patch failed with JDK v1.8.0_66.
          -1 compile 1m 13s root in the patch failed with JDK v1.7.0_91.
          -1 javac 1m 13s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 1m 6s root: patch generated 2 new + 475 unchanged - 5 fixed = 477 total (was 480)
          -1 mvnsite 0m 22s hadoop-hdfs-client in the patch failed.
          -1 mvnsite 0m 24s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 21s hadoop-hdfs-client in the patch failed.
          -1 findbugs 0m 22s hadoop-hdfs in the patch failed.
          -1 javadoc 4m 26s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
          -1 javadoc 4m 26s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
          +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66
          -1 javadoc 7m 56s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
          -1 javadoc 7m 56s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
          +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91
          -1 unit 19m 15s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 18s hadoop-hdfs-client in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 20s hadoop-hdfs-client in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          80m 35s



          Reason Tests
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785607/HDFS-9733-v1.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 492edf65f6cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e30ce01
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14325/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14325/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 6m 29s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_66 +1 compile 6m 50s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 9s trunk passed +1 mvnsite 2m 29s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 5m 38s trunk passed +1 javadoc 2m 19s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 14s trunk passed with JDK v1.7.0_91 0 mvndep 0m 26s Maven dependency ordering for patch -1 mvninstall 0m 20s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 21s hadoop-hdfs in the patch failed. -1 compile 1m 4s root in the patch failed with JDK v1.8.0_66. -1 javac 1m 4s root in the patch failed with JDK v1.8.0_66. -1 compile 1m 13s root in the patch failed with JDK v1.7.0_91. -1 javac 1m 13s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 6s root: patch generated 2 new + 475 unchanged - 5 fixed = 477 total (was 480) -1 mvnsite 0m 22s hadoop-hdfs-client in the patch failed. -1 mvnsite 0m 24s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 21s hadoop-hdfs-client in the patch failed. -1 findbugs 0m 22s hadoop-hdfs in the patch failed. -1 javadoc 4m 26s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) -1 javadoc 4m 26s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7) +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66 -1 javadoc 7m 56s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) -1 javadoc 7m 56s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7) +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91 -1 unit 19m 15s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 18s hadoop-hdfs-client in the patch failed with JDK v1.8.0_66. -1 unit 0m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 0m 20s hadoop-hdfs-client in the patch failed with JDK v1.7.0_91. -1 unit 0m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 80m 35s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785607/HDFS-9733-v1.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 492edf65f6cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e30ce01 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14325/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14325/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch adding missed files.

          Show
          drankye Kai Zheng added a comment - Updated the patch adding missed files.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 5s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 12m 36s trunk passed
          +1 compile 12m 49s trunk passed with JDK v1.8.0_72
          +1 compile 9m 14s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 29s trunk passed
          +1 mvnsite 2m 58s trunk passed
          +1 mvneclipse 0m 45s trunk passed
          +1 findbugs 6m 49s trunk passed
          +1 javadoc 3m 20s trunk passed with JDK v1.8.0_72
          +1 javadoc 4m 17s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 47s the patch passed
          +1 compile 12m 4s the patch passed with JDK v1.8.0_72
          +1 javac 12m 4s the patch passed
          +1 compile 9m 50s the patch passed with JDK v1.7.0_95
          +1 javac 9m 50s the patch passed
          -1 checkstyle 1m 22s root: patch generated 52 new + 530 unchanged - 5 fixed = 582 total (was 535)
          +1 mvnsite 3m 11s the patch passed
          +1 mvneclipse 0m 47s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 2m 46s hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 3m 48s the patch passed with JDK v1.8.0_72
          +1 javadoc 5m 2s the patch passed with JDK v1.7.0_95
          -1 unit 12m 6s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 37s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 76m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 8m 46s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 81m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 33s Patch does not generate ASF License warnings.
          300m 46s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            Unread field:FileChecksumHelper.java:[line 66]
          JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname
            hadoop.ha.TestZKFailoverController
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestName
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestFileAppend
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787921/HDFS-9733-v2.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 786e00f05865 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8ed07bd
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14497/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14497/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 5s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 12m 36s trunk passed +1 compile 12m 49s trunk passed with JDK v1.8.0_72 +1 compile 9m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 29s trunk passed +1 mvnsite 2m 58s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 6m 49s trunk passed +1 javadoc 3m 20s trunk passed with JDK v1.8.0_72 +1 javadoc 4m 17s trunk passed with JDK v1.7.0_95 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 47s the patch passed +1 compile 12m 4s the patch passed with JDK v1.8.0_72 +1 javac 12m 4s the patch passed +1 compile 9m 50s the patch passed with JDK v1.7.0_95 +1 javac 9m 50s the patch passed -1 checkstyle 1m 22s root: patch generated 52 new + 530 unchanged - 5 fixed = 582 total (was 535) +1 mvnsite 3m 11s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 46s hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 3m 48s the patch passed with JDK v1.8.0_72 +1 javadoc 5m 2s the patch passed with JDK v1.7.0_95 -1 unit 12m 6s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 1m 37s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 76m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 8m 46s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 81m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 33s Patch does not generate ASF License warnings. 300m 46s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   Unread field:FileChecksumHelper.java: [line 66] JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname   hadoop.ha.TestZKFailoverController   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestName   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestFileAppend JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787921/HDFS-9733-v2.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 786e00f05865 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14497/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14497/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14497/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch to address some reported issues.

          Show
          drankye Kai Zheng added a comment - Updated the patch to address some reported issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 8m 16s trunk passed
          +1 compile 10m 2s trunk passed with JDK v1.8.0_72
          +1 compile 8m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 16s trunk passed
          +1 mvnsite 3m 3s trunk passed
          +1 mvneclipse 0m 46s trunk passed
          +1 findbugs 6m 26s trunk passed
          +1 javadoc 3m 26s trunk passed with JDK v1.8.0_72
          +1 javadoc 4m 26s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 37s the patch passed
          +1 compile 10m 35s the patch passed with JDK v1.8.0_72
          +1 javac 10m 35s the patch passed
          +1 compile 9m 6s the patch passed with JDK v1.7.0_95
          +1 javac 9m 6s the patch passed
          -1 checkstyle 1m 25s root: patch generated 44 new + 530 unchanged - 5 fixed = 574 total (was 535)
          +1 mvnsite 3m 9s the patch passed
          +1 mvneclipse 0m 47s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 4s the patch passed
          +1 javadoc 2m 59s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 45s the patch passed with JDK v1.7.0_95
          -1 unit 9m 38s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 80m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 8m 25s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 61m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          253m 30s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestFileAppend
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788011/HDFS-9733-v3.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 77ebd1b0d0f2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8ed07bd
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14503/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14503/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 8m 16s trunk passed +1 compile 10m 2s trunk passed with JDK v1.8.0_72 +1 compile 8m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 16s trunk passed +1 mvnsite 3m 3s trunk passed +1 mvneclipse 0m 46s trunk passed +1 findbugs 6m 26s trunk passed +1 javadoc 3m 26s trunk passed with JDK v1.8.0_72 +1 javadoc 4m 26s trunk passed with JDK v1.7.0_95 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 37s the patch passed +1 compile 10m 35s the patch passed with JDK v1.8.0_72 +1 javac 10m 35s the patch passed +1 compile 9m 6s the patch passed with JDK v1.7.0_95 +1 javac 9m 6s the patch passed -1 checkstyle 1m 25s root: patch generated 44 new + 530 unchanged - 5 fixed = 574 total (was 535) +1 mvnsite 3m 9s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 4s the patch passed +1 javadoc 2m 59s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 45s the patch passed with JDK v1.7.0_95 -1 unit 9m 38s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 80m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 8m 25s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 61m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 253m 30s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestFileAppend JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestDistributedFileSystem   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788011/HDFS-9733-v3.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77ebd1b0d0f2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14503/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14503/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks for the refactor Kai. Overall it looks good to me.
          Following are my questions/comments

          1. Why do you think we need 2 abstract classes here?
            AbstractBlockChecksumComputer
            BlockChecksumComputer
            One is enough?
          2. Could you please add doc for this class? what it is doing?
            ReplicatedBlockChecksumComputer
          3. Small doc for this method as well? compute
          4. How does this class related?
            CorruptedBlocks
            I think overall you can take advantage to improve javadoc around this newly created classes.
            This classes added in DFSUtilClient.java
          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks for the refactor Kai. Overall it looks good to me. Following are my questions/comments Why do you think we need 2 abstract classes here? AbstractBlockChecksumComputer BlockChecksumComputer One is enough? Could you please add doc for this class? what it is doing? ReplicatedBlockChecksumComputer Small doc for this method as well? compute How does this class related? CorruptedBlocks I think overall you can take advantage to improve javadoc around this newly created classes. This classes added in DFSUtilClient.java
          Hide
          drankye Kai Zheng added a comment -

          Thanks Uma for the great comments!

          Why do you think we need 2 abstract classes here?

          Ah right now we do just need one abstract class for the refactoring. The other can be introduced later in HDFS-9694 when it's really needed.

          Could you please add doc for this class?

          Sure for this and the other similar comments. I will add javadoc for the new class and public/protected methods.

          How does this class related?

          Oh, CorruptedBlocks was from the work in HDFS-9734. I will do the cleanup when update the patch.

          Show
          drankye Kai Zheng added a comment - Thanks Uma for the great comments! Why do you think we need 2 abstract classes here? Ah right now we do just need one abstract class for the refactoring. The other can be introduced later in HDFS-9694 when it's really needed. Could you please add doc for this class? Sure for this and the other similar comments. I will add javadoc for the new class and public/protected methods. How does this class related? Oh, CorruptedBlocks was from the work in HDFS-9734 . I will do the cleanup when update the patch.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch according to review. Thanks.

          Show
          drankye Kai Zheng added a comment - Updated the patch according to review. Thanks.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks Kai for updating the patch. The latest patch looks good to me.
          +1 pending Jenkins.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks Kai for updating the patch. The latest patch looks good to me. +1 pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 41s Maven dependency ordering for branch
          +1 mvninstall 7m 24s trunk passed
          +1 compile 6m 34s trunk passed with JDK v1.8.0_72
          +1 compile 7m 14s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 14s trunk passed
          +1 mvnsite 2m 46s trunk passed
          +1 mvneclipse 0m 44s trunk passed
          +1 findbugs 5m 38s trunk passed
          +1 javadoc 2m 36s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 31s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 9s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.8.0_72
          +1 javac 6m 44s the patch passed
          +1 compile 7m 22s the patch passed with JDK v1.7.0_95
          +1 javac 7m 22s the patch passed
          -1 checkstyle 1m 14s root: patch generated 47 new + 525 unchanged - 5 fixed = 572 total (was 530)
          +1 mvnsite 2m 53s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 33s the patch passed
          +1 javadoc 2m 13s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 6s the patch passed with JDK v1.7.0_95
          +1 unit 6m 34s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 54m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 51m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          194m 41s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestDistributedFileSystem
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788967/HDFS-9733-v4.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 22b6abe6e171 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 27b7775
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14581/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14581/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 41s Maven dependency ordering for branch +1 mvninstall 7m 24s trunk passed +1 compile 6m 34s trunk passed with JDK v1.8.0_72 +1 compile 7m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 14s trunk passed +1 mvnsite 2m 46s trunk passed +1 mvneclipse 0m 44s trunk passed +1 findbugs 5m 38s trunk passed +1 javadoc 2m 36s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 31s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 9s the patch passed +1 compile 6m 44s the patch passed with JDK v1.8.0_72 +1 javac 6m 44s the patch passed +1 compile 7m 22s the patch passed with JDK v1.7.0_95 +1 javac 7m 22s the patch passed -1 checkstyle 1m 14s root: patch generated 47 new + 525 unchanged - 5 fixed = 572 total (was 530) +1 mvnsite 2m 53s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 33s the patch passed +1 javadoc 2m 13s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 6s the patch passed with JDK v1.7.0_95 +1 unit 6m 34s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 54m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 51m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 194m 41s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestDistributedFileSystem JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788967/HDFS-9733-v4.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 22b6abe6e171 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27b7775 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14581/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14581/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14581/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Hi Kai Zheng, Test failures seems to be related. Can you please fix them?
          Also please address all check style warnings.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Hi Kai Zheng , Test failures seems to be related. Can you please fix them? Also please address all check style warnings.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Kai Zheng I think one reason for test failure could be that, when located blocks are 0 (may be for zero size files etc), we don't really try from datanodes, but here you are setting crcType only when we call tryDatanode. Here default crcType can be set bydefaut.I checked the older code, there we are setting default crcType by default. Please validate and update the patch accordingly. Thanks

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Kai Zheng I think one reason for test failure could be that, when located blocks are 0 (may be for zero size files etc), we don't really try from datanodes, but here you are setting crcType only when we call tryDatanode. Here default crcType can be set bydefaut.I checked the older code, there we are setting default crcType by default. Please validate and update the patch accordingly. Thanks
          Hide
          drankye Kai Zheng added a comment -

          Thanks Uma for the digging and analysis for me! Yes I will fix the failures and checking style issues as well. You're right the length == 0 case should be particularly handled. Here I will keep the current logic for the case, fixing the failures, and leave it to be refined for HDFS-9705.

          Show
          drankye Kai Zheng added a comment - Thanks Uma for the digging and analysis for me! Yes I will fix the failures and checking style issues as well. You're right the length == 0 case should be particularly handled. Here I will keep the current logic for the case, fixing the failures, and leave it to be refined for HDFS-9705 .
          Hide
          drankye Kai Zheng added a comment -

          Fixed the failures as Uma suggested and fixed some checking styles.

          Show
          drankye Kai Zheng added a comment - Fixed the failures as Uma suggested and fixed some checking styles.
          Hide
          drankye Kai Zheng added a comment -

          Fixed another check style.

          Show
          drankye Kai Zheng added a comment - Fixed another check style.
          Hide
          drankye Kai Zheng added a comment -

          The update didn't fix check styles like below. I'm thinking the variables will be revisited in subsequent tasks like HDFS-9694. Uma Maheswara Rao G please let me know if you'd prefer they're fixed here. Thanks.

          long crcPerBlock = 0;:10: Variable 'crcPerBlock' must be private and have accessor methods.
          
          Show
          drankye Kai Zheng added a comment - The update didn't fix check styles like below. I'm thinking the variables will be revisited in subsequent tasks like HDFS-9694 . Uma Maheswara Rao G please let me know if you'd prefer they're fixed here. Thanks. long crcPerBlock = 0;:10: Variable 'crcPerBlock' must be private and have accessor methods.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks Kai for updating the patch.
          For your question, I would prefer to keep the patch completion and don't open points for another JIRA patch. So, lets make possible variable private here and when required we can change later when changing them in another JIRA.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks Kai for updating the patch. For your question, I would prefer to keep the patch completion and don't open points for another JIRA patch. So, lets make possible variable private here and when required we can change later when changing them in another JIRA.
          Hide
          drankye Kai Zheng added a comment -

          OK, it makes sense and I will do the fix here. Thanks Uma.

          Show
          drankye Kai Zheng added a comment - OK, it makes sense and I will do the fix here. Thanks Uma.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 49s Maven dependency ordering for branch
          +1 mvninstall 7m 36s trunk passed
          +1 compile 8m 39s trunk passed with JDK v1.8.0_72
          +1 compile 7m 55s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 18s trunk passed
          +1 mvnsite 2m 51s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 5m 48s trunk passed
          +1 javadoc 2m 52s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 42s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 17s the patch passed
          +1 compile 8m 37s the patch passed with JDK v1.8.0_72
          +1 javac 8m 37s the patch passed
          +1 compile 7m 50s the patch passed with JDK v1.7.0_95
          +1 javac 7m 50s the patch passed
          -1 checkstyle 1m 15s root: patch generated 33 new + 525 unchanged - 5 fixed = 558 total (was 530)
          +1 mvnsite 2m 44s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 32s the patch passed
          +1 javadoc 2m 44s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 40s the patch passed with JDK v1.7.0_95
          +1 unit 9m 39s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 77m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 11m 34s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 1m 33s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 81m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          263m 50s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestPread
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestName
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789526/HDFS-9733-v6.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bdf405a2d3e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3369a4f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14593/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14593/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 49s Maven dependency ordering for branch +1 mvninstall 7m 36s trunk passed +1 compile 8m 39s trunk passed with JDK v1.8.0_72 +1 compile 7m 55s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 18s trunk passed +1 mvnsite 2m 51s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 5m 48s trunk passed +1 javadoc 2m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 42s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 17s the patch passed +1 compile 8m 37s the patch passed with JDK v1.8.0_72 +1 javac 8m 37s the patch passed +1 compile 7m 50s the patch passed with JDK v1.7.0_95 +1 javac 7m 50s the patch passed -1 checkstyle 1m 15s root: patch generated 33 new + 525 unchanged - 5 fixed = 558 total (was 530) +1 mvnsite 2m 44s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 32s the patch passed +1 javadoc 2m 44s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 40s the patch passed with JDK v1.7.0_95 +1 unit 9m 39s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 77m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 11m 34s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 1m 33s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 81m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 263m 50s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestPread   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestName   hadoop.ipc.TestRPCWaitForProxy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789526/HDFS-9733-v6.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bdf405a2d3e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3369a4f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14593/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14593/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch as Uma suggested. Thanks!

          Show
          drankye Kai Zheng added a comment - Updated the patch as Uma suggested. Thanks!
          Hide
          drankye Kai Zheng added a comment -

          Rebased the patch with the latest codes.

          Show
          drankye Kai Zheng added a comment - Rebased the patch with the latest codes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 20s trunk passed
          +1 compile 6m 40s trunk passed with JDK v1.8.0_72
          +1 compile 7m 14s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 14s trunk passed
          +1 mvnsite 2m 38s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 5m 41s trunk passed
          +1 javadoc 2m 37s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 26s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 11s the patch passed
          +1 compile 7m 2s the patch passed with JDK v1.8.0_72
          +1 javac 7m 2s the patch passed
          +1 compile 7m 30s the patch passed with JDK v1.7.0_95
          +1 javac 7m 30s the patch passed
          -1 checkstyle 1m 15s root: patch generated 14 new + 525 unchanged - 5 fixed = 539 total (was 530)
          +1 mvnsite 2m 49s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 9s the patch passed
          +1 javadoc 2m 15s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 10s the patch passed with JDK v1.7.0_95
          +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          +1 unit 52m 36s hadoop-hdfs in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 10s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 unit 51m 44s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          193m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790088/HDFS-9733-v7.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6ef29cf4b525 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d7fdec1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14624/artifact/patchprocess/diff-checkstyle-root.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14624/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14624/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 20s trunk passed +1 compile 6m 40s trunk passed with JDK v1.8.0_72 +1 compile 7m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 14s trunk passed +1 mvnsite 2m 38s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 41s trunk passed +1 javadoc 2m 37s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 26s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 11s the patch passed +1 compile 7m 2s the patch passed with JDK v1.8.0_72 +1 javac 7m 2s the patch passed +1 compile 7m 30s the patch passed with JDK v1.7.0_95 +1 javac 7m 30s the patch passed -1 checkstyle 1m 15s root: patch generated 14 new + 525 unchanged - 5 fixed = 539 total (was 530) +1 mvnsite 2m 49s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 9s the patch passed +1 javadoc 2m 15s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 10s the patch passed with JDK v1.7.0_95 +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. +1 unit 52m 36s hadoop-hdfs in the patch passed with JDK v1.8.0_72. +1 unit 7m 10s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 unit 51m 44s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 193m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790088/HDFS-9733-v7.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6ef29cf4b525 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d7fdec1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14624/artifact/patchprocess/diff-checkstyle-root.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14624/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14624/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 38s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 8m 31s trunk passed
          +1 compile 9m 9s trunk passed with JDK v1.8.0_72
          +1 compile 10m 31s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 47s trunk passed
          +1 mvnsite 3m 41s trunk passed
          +1 mvneclipse 1m 5s trunk passed
          +1 findbugs 7m 38s trunk passed
          +1 javadoc 4m 47s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 48s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 17s the patch passed
          +1 compile 9m 5s the patch passed with JDK v1.8.0_72
          +1 javac 9m 5s the patch passed
          +1 compile 7m 22s the patch passed with JDK v1.7.0_95
          +1 javac 7m 22s the patch passed
          -1 checkstyle 1m 9s root: patch generated 14 new + 525 unchanged - 5 fixed = 539 total (was 530)
          +1 mvnsite 2m 35s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 45s the patch passed
          +1 javadoc 3m 39s the patch passed with JDK v1.8.0_72
          +1 javadoc 4m 44s the patch passed with JDK v1.7.0_95
          -1 unit 11m 11s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 90m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 9m 17s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 105m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 37s Patch does not generate ASF License warnings.
          311m 58s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790100/HDFS-9733-v8.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0921a1bafacb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d7fdec1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14625/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14625/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 38s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 8m 31s trunk passed +1 compile 9m 9s trunk passed with JDK v1.8.0_72 +1 compile 10m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 47s trunk passed +1 mvnsite 3m 41s trunk passed +1 mvneclipse 1m 5s trunk passed +1 findbugs 7m 38s trunk passed +1 javadoc 4m 47s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 48s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 17s the patch passed +1 compile 9m 5s the patch passed with JDK v1.8.0_72 +1 javac 9m 5s the patch passed +1 compile 7m 22s the patch passed with JDK v1.7.0_95 +1 javac 7m 22s the patch passed -1 checkstyle 1m 9s root: patch generated 14 new + 525 unchanged - 5 fixed = 539 total (was 530) +1 mvnsite 2m 35s the patch passed +1 mvneclipse 0m 52s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 45s the patch passed +1 javadoc 3m 39s the patch passed with JDK v1.8.0_72 +1 javadoc 4m 44s the patch passed with JDK v1.7.0_95 -1 unit 11m 11s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 90m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 9m 17s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 105m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 37s Patch does not generate ASF License warnings. 311m 58s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790100/HDFS-9733-v8.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0921a1bafacb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d7fdec1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14625/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14625/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Cleared more checking styles. The following ones were not fixed, as it's an often used practice. Sure Uma Maheswara Rao G please let me know if this works for you or not.

          void setBlockLocations(LocatedBlocks blockLocations) {:42: 'blockLocations' hides a field.
          void setTimeout(int timeout) {:25: 'timeout' hides a field.
          void setLocatedBlocks(List<LocatedBlock> locatedBlocks) {:46: 'locatedBlocks' hides a field.
          void setRemaining(long remaining) {:28: 'remaining' hides a field.
          void setBytesPerCRC(int bytesPerCRC) {:29: 'bytesPerCRC' hides a field.
          void setCrcType(DataChecksum.Type crcType) {:39: 'crcType' hides a field.
          void setCrcPerBlock(long crcPerBlock) {:30: 'crcPerBlock' hides a field.
          void setRefetchBlocks(boolean refetchBlocks) {:35: 'refetchBlocks' hides a field.
          void setLastRetriedIndex(int lastRetriedIndex) {:34: 'lastRetriedIndex' hides a field.
          
          Show
          drankye Kai Zheng added a comment - Cleared more checking styles. The following ones were not fixed, as it's an often used practice. Sure Uma Maheswara Rao G please let me know if this works for you or not. void setBlockLocations(LocatedBlocks blockLocations) {:42: 'blockLocations' hides a field. void setTimeout( int timeout) {:25: 'timeout' hides a field. void setLocatedBlocks(List<LocatedBlock> locatedBlocks) {:46: 'locatedBlocks' hides a field. void setRemaining( long remaining) {:28: 'remaining' hides a field. void setBytesPerCRC( int bytesPerCRC) {:29: 'bytesPerCRC' hides a field. void setCrcType(DataChecksum.Type crcType) {:39: 'crcType' hides a field. void setCrcPerBlock( long crcPerBlock) {:30: 'crcPerBlock' hides a field. void setRefetchBlocks( boolean refetchBlocks) {:35: 'refetchBlocks' hides a field. void setLastRetriedIndex( int lastRetriedIndex) {:34: 'lastRetriedIndex' hides a field.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 20s Maven dependency ordering for branch
          +1 mvninstall 9m 9s trunk passed
          +1 compile 11m 37s trunk passed with JDK v1.8.0_72
          +1 compile 9m 34s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 14s trunk passed
          +1 mvnsite 2m 40s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 5m 21s trunk passed
          +1 javadoc 2m 55s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 31s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 10s the patch passed
          +1 compile 10m 13s the patch passed with JDK v1.8.0_72
          +1 javac 10m 13s the patch passed
          +1 compile 9m 33s the patch passed with JDK v1.7.0_95
          +1 javac 9m 33s the patch passed
          -1 checkstyle 1m 24s root: patch generated 10 new + 524 unchanged - 5 fixed = 534 total (was 529)
          +1 mvnsite 3m 9s the patch passed
          +1 mvneclipse 0m 51s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 31s the patch passed
          +1 javadoc 3m 48s the patch passed with JDK v1.8.0_72
          +1 javadoc 4m 21s the patch passed with JDK v1.7.0_95
          -1 unit 11m 4s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 24s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          -1 unit 75m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 8m 43s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 65m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          256m 44s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname
            hadoop.ha.TestZKFailoverController
            hadoop.fs.shell.find.TestPrint
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.TestFileAppend
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
            org.apache.hadoop.hdfs.TestWriteReadStripedFile
            org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
            org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.TestFileAppend
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790412/HDFS-9733-v9.patch
          JIRA Issue HDFS-9733
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e172908de11e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e3ac231
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14650/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14650/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 9m 9s trunk passed +1 compile 11m 37s trunk passed with JDK v1.8.0_72 +1 compile 9m 34s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 14s trunk passed +1 mvnsite 2m 40s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 5m 21s trunk passed +1 javadoc 2m 55s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 31s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 10s the patch passed +1 compile 10m 13s the patch passed with JDK v1.8.0_72 +1 javac 10m 13s the patch passed +1 compile 9m 33s the patch passed with JDK v1.7.0_95 +1 javac 9m 33s the patch passed -1 checkstyle 1m 24s root: patch generated 10 new + 524 unchanged - 5 fixed = 534 total (was 529) +1 mvnsite 3m 9s the patch passed +1 mvneclipse 0m 51s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 31s the patch passed +1 javadoc 3m 48s the patch passed with JDK v1.8.0_72 +1 javadoc 4m 21s the patch passed with JDK v1.7.0_95 -1 unit 11m 4s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 1m 24s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 75m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 8m 43s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 65m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 256m 44s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.fs.shell.find.TestIname   hadoop.ha.TestZKFailoverController   hadoop.fs.shell.find.TestPrint   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestFileAppend JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs   org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.TestFileAppend   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790412/HDFS-9733-v9.patch JIRA Issue HDFS-9733 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e172908de11e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e3ac231 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14650/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14650/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Having checked the test failures and they're passed locally as not related to this.
          The refactoring strictly follows the current behavior and existing tests can ensure that. Will add more tests along with striped file checksum computing.

          Show
          drankye Kai Zheng added a comment - Having checked the test failures and they're passed locally as not related to this. The refactoring strictly follows the current behavior and existing tests can ensure that. Will add more tests along with striped file checksum computing.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          +1 on the latest patch.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - +1 on the latest patch.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          I have just committed this to trunk. Thanks a lot, Kai for the work.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - I have just committed this to trunk. Thanks a lot, Kai for the work.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Uma for the review and commit! Then I can go on with HDFS-9694, for the striped file checksum computing.

          Show
          drankye Kai Zheng added a comment - Thanks Uma for the review and commit! Then I can go on with HDFS-9694 , for the striped file checksum computing.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9399 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9399/)
          HDFS-9733. Refactor DFSClient#getFileChecksum and (uma.gangumalla: rev 307ec80acae3b4a41d21b2d4b3a55032e55fcdc6)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/DataChecksum.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/MD5Hash.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/IOStreamPair.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9399 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9399/ ) HDFS-9733 . Refactor DFSClient#getFileChecksum and (uma.gangumalla: rev 307ec80acae3b4a41d21b2d4b3a55032e55fcdc6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/DataChecksum.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/MD5Hash.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/IOStreamPair.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java

            People

            • Assignee:
              drankye Kai Zheng
              Reporter:
              drankye Kai Zheng
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development