Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Makes the getFileChecksum API works with striped layout EC files. Checksum computation done by block level in the distributed fashion. The current API does not support to compare the checksum generated with normal file and the checksum generated for the same file but in striped layout.
      Show
      Makes the getFileChecksum API works with striped layout EC files. Checksum computation done by block level in the distributed fashion. The current API does not support to compare the checksum generated with normal file and the checksum generated for the same file but in striped layout.

      Description

      This is a sub-task of HDFS-8430 and will get the existing API FileSystem#getFileChecksum(path) work for striped files. It will also refactor existing codes and layout basic work for subsequent tasks like support of the new API proposed there.

      1. HDFS-9694-v1.patch
        60 kB
        Kai Zheng
      2. HDFS-9694-v2.patch
        100 kB
        Kai Zheng
      3. HDFS-9694-v3.patch
        50 kB
        Kai Zheng
      4. HDFS-9694-v4.patch
        52 kB
        Kai Zheng
      5. HDFS-9694-v5.patch
        52 kB
        Kai Zheng
      6. HDFS-9694-v6.patch
        52 kB
        Kai Zheng
      7. HDFS-9694-v7.patch
        53 kB
        Kai Zheng
      8. HDFS-9694-v8.patch
        53 kB
        Kai Zheng
      9. HDFS-9694-v9.patch
        53 kB
        Kai Zheng

        Issue Links

          Activity

          Hide
          drankye Kai Zheng added a comment -

          Oops, the result patch seems too large. Will do the not-so-relevant refactoring separately.

          Show
          drankye Kai Zheng added a comment - Oops, the result patch seems too large. Will do the not-so-relevant refactoring separately.
          Hide
          drankye Kai Zheng added a comment -

          Uploaded a patch.
          Tsz Wo Nicholas Sze, could you help take a quick look at it? As the patch refactors the existing DFSClient#getFileChecksum and DataXceiver#blockChecksum as I wanted to reuse the codes for striping case, do you think we should do the refactoring separately? Thanks for your hint.

          Show
          drankye Kai Zheng added a comment - Uploaded a patch. Tsz Wo Nicholas Sze , could you help take a quick look at it? As the patch refactors the existing DFSClient#getFileChecksum and DataXceiver#blockChecksum as I wanted to reuse the codes for striping case, do you think we should do the refactoring separately? Thanks for your hint.
          Hide
          drankye Kai Zheng added a comment -

          Am working on datanode failure error handling case where data of missed/corrupted data blocks need to be reconstructed for checksum recomputing.

          Show
          drankye Kai Zheng added a comment - Am working on datanode failure error handling case where data of missed/corrupted data blocks need to be reconstructed for checksum recomputing.
          Hide
          drankye Kai Zheng added a comment -

          Some work from HDFS-9719 will help a lot to reuse some existing codes in ErasureCodingWorker for the reconstructing. The checksum recomputing in block missed/corrupted can be done separately.

          Show
          drankye Kai Zheng added a comment - Some work from HDFS-9719 will help a lot to reuse some existing codes in ErasureCodingWorker for the reconstructing. The checksum recomputing in block missed/corrupted can be done separately.
          Hide
          drankye Kai Zheng added a comment -

          Vinayakumar B or anyone else, would you help spend some time do the review? Thanks.

          Show
          drankye Kai Zheng added a comment - Vinayakumar B or anyone else, would you help spend some time do the review? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 31s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 36s trunk passed with JDK v1.8.0_66
          +1 compile 6m 55s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 2m 32s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 6m 2s trunk passed
          +1 javadoc 2m 43s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 31s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 25s Maven dependency ordering for patch
          -1 mvninstall 0m 22s hadoop-hdfs-client in the patch failed.
          -1 mvninstall 0m 26s hadoop-hdfs in the patch failed.
          -1 compile 1m 22s root in the patch failed with JDK v1.8.0_66.
          -1 cc 1m 22s root in the patch failed with JDK v1.8.0_66.
          -1 javac 1m 22s root in the patch failed with JDK v1.8.0_66.
          -1 compile 1m 21s root in the patch failed with JDK v1.7.0_91.
          -1 cc 1m 21s root in the patch failed with JDK v1.7.0_91.
          -1 javac 1m 21s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 1m 13s root: patch generated 15 new + 659 unchanged - 6 fixed = 674 total (was 665)
          -1 mvnsite 0m 25s hadoop-hdfs-client in the patch failed.
          -1 mvnsite 0m 28s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 37s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 findbugs 0m 25s hadoop-hdfs-client in the patch failed.
          -1 findbugs 0m 28s hadoop-hdfs in the patch failed.
          -1 javadoc 5m 17s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66 with JDK v1.8.0_66 generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)
          -1 javadoc 5m 17s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 11 new + 7 unchanged - 0 fixed = 18 total (was 7)
          +1 javadoc 2m 41s the patch passed with JDK v1.8.0_66
          -1 javadoc 9m 4s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)
          -1 javadoc 9m 4s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 11 new + 7 unchanged - 0 fixed = 18 total (was 7)
          +1 javadoc 3m 30s the patch passed with JDK v1.7.0_91
          -1 unit 7m 29s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 21s hadoop-hdfs-client in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 54s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 25s hadoop-hdfs-client in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          74m 4s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784812/HDFS-9694-v1.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 444a2cb60e6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8f2622b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          cc https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          cc https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt
          javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14316/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14316/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 36s trunk passed with JDK v1.8.0_66 +1 compile 6m 55s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 13s trunk passed +1 mvnsite 2m 32s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 6m 2s trunk passed +1 javadoc 2m 43s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 31s trunk passed with JDK v1.7.0_91 0 mvndep 0m 25s Maven dependency ordering for patch -1 mvninstall 0m 22s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 26s hadoop-hdfs in the patch failed. -1 compile 1m 22s root in the patch failed with JDK v1.8.0_66. -1 cc 1m 22s root in the patch failed with JDK v1.8.0_66. -1 javac 1m 22s root in the patch failed with JDK v1.8.0_66. -1 compile 1m 21s root in the patch failed with JDK v1.7.0_91. -1 cc 1m 21s root in the patch failed with JDK v1.7.0_91. -1 javac 1m 21s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 13s root: patch generated 15 new + 659 unchanged - 6 fixed = 674 total (was 665) -1 mvnsite 0m 25s hadoop-hdfs-client in the patch failed. -1 mvnsite 0m 28s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 37s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 0m 25s hadoop-hdfs-client in the patch failed. -1 findbugs 0m 28s hadoop-hdfs in the patch failed. -1 javadoc 5m 17s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66 with JDK v1.8.0_66 generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1) -1 javadoc 5m 17s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 11 new + 7 unchanged - 0 fixed = 18 total (was 7) +1 javadoc 2m 41s the patch passed with JDK v1.8.0_66 -1 javadoc 9m 4s hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1) -1 javadoc 9m 4s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 11 new + 7 unchanged - 0 fixed = 18 total (was 7) +1 javadoc 3m 30s the patch passed with JDK v1.7.0_91 -1 unit 7m 29s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 21s hadoop-hdfs-client in the patch failed with JDK v1.8.0_66. -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 7m 54s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 0m 25s hadoop-hdfs-client in the patch failed with JDK v1.7.0_91. -1 unit 0m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 74m 4s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784812/HDFS-9694-v1.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 444a2cb60e6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8f2622b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt cc https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt cc https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javadoc hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14316/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14316/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14316/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Oops, missed some new files. Fixing...

          Show
          drankye Kai Zheng added a comment - Oops, missed some new files. Fixing...
          Hide
          drankye Kai Zheng added a comment -

          Wondering if to fix the following issues, they're there to be consistent with existing codes. Guess better to fix them separately if needed.

          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:118:        opRawBlockChecksum(in);: 'block' child have incorrect indentation level 8, expected level should be 6.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:119:        break;: 'block' child have incorrect indentation level 8, expected level should be 6.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:303:  /** Receive OP_RAW_BLOCK_CHECKSUM */: First sentence should end with a period.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:304:  private void opRawBlockChecksum(DataInputStream in) throws IOException {:51: 'in' hides a field.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:305:    OpRawBlockChecksumProto proto = OpRawBlockChecksumProto.parseFrom(vintPrefixed(in));: Line is longer than 80 characters (found 88).
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:313:      if (traceScope != null) traceScope.close();: 'if' construct must use '{}'s.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:317:  /** Receive OP_STRIPED_BLOCK_CHECKSUM */: First sentence should end with a period.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:318:  private void opStripedBlockChecksum(DataInputStream in) throws IOException {:55: 'in' hides a field.
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:332:          PBHelperClient.convert(proto.getHeader().getToken()), proto.getMode());: Line is longer than 80 characters (found 81).
          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:334:      if (traceScope != null) traceScope.close();: 'if' construct must use '{}'s.
          
          Show
          drankye Kai Zheng added a comment - Wondering if to fix the following issues, they're there to be consistent with existing codes. Guess better to fix them separately if needed. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:118: opRawBlockChecksum(in);: 'block' child have incorrect indentation level 8, expected level should be 6. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:119: break;: 'block' child have incorrect indentation level 8, expected level should be 6. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:303: /** Receive OP_RAW_BLOCK_CHECKSUM */: First sentence should end with a period. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:304: private void opRawBlockChecksum(DataInputStream in) throws IOException {:51: 'in' hides a field. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:305: OpRawBlockChecksumProto proto = OpRawBlockChecksumProto.parseFrom(vintPrefixed(in));: Line is longer than 80 characters (found 88). ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:313: if (traceScope != null) traceScope.close();: 'if' construct must use '{}'s. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:317: /** Receive OP_STRIPED_BLOCK_CHECKSUM */: First sentence should end with a period. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:318: private void opStripedBlockChecksum(DataInputStream in) throws IOException {:55: 'in' hides a field. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:332: PBHelperClient.convert(proto.getHeader().getToken()), proto.getMode());: Line is longer than 80 characters (found 81). ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:334: if (traceScope != null) traceScope.close();: 'if' construct must use '{}'s.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch, adding missed files and fixing some checking styles.

          Show
          drankye Kai Zheng added a comment - Updated the patch, adding missed files and fixing some checking styles.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 6m 55s trunk passed
          +1 compile 6m 15s trunk passed with JDK v1.8.0_66
          +1 compile 7m 0s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 12s trunk passed
          +1 mvnsite 2m 32s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 5m 40s trunk passed
          +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 15s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 24s Maven dependency ordering for patch
          +1 mvninstall 1m 58s the patch passed
          +1 compile 6m 24s the patch passed with JDK v1.8.0_66
          +1 cc 6m 24s the patch passed
          -1 javac 8m 46s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 738 unchanged - 1 fixed = 739 total (was 739)
          +1 javac 6m 24s the patch passed
          +1 compile 7m 2s the patch passed with JDK v1.7.0_91
          +1 cc 7m 2s the patch passed
          -1 javac 15m 48s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 734 unchanged - 1 fixed = 735 total (was 735)
          +1 javac 7m 2s the patch passed
          -1 checkstyle 1m 14s root: patch generated 71 new + 656 unchanged - 6 fixed = 727 total (was 662)
          +1 mvnsite 2m 28s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 2m 10s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          -1 findbugs 2m 9s hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 2m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91
          +1 unit 6m 32s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
          -1 unit 52m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 6m 47s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
          -1 unit 49m 24s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          187m 24s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 58]
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 54]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 45]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 44]
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper$RawBlockChecksumComputer.readBlockCrc() ignores result of java.io.DataInputStream.read(byte[]) At BlockChecksumHelper.java: At BlockChecksumHelper.java:[line 252]
            org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper$RawBlockChecksumComputer.readBlockCrc() ignores result of java.io.DataInputStream.skip(long) At BlockChecksumHelper.java: At BlockChecksumHelper.java:[line 248]
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestFsDatasetCache
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785503/HDFS-9694-v2.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 23504cab4314 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8f2622b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14319/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14319/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 6m 55s trunk passed +1 compile 6m 15s trunk passed with JDK v1.8.0_66 +1 compile 7m 0s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 12s trunk passed +1 mvnsite 2m 32s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 5m 40s trunk passed +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 15s trunk passed with JDK v1.7.0_91 0 mvndep 0m 24s Maven dependency ordering for patch +1 mvninstall 1m 58s the patch passed +1 compile 6m 24s the patch passed with JDK v1.8.0_66 +1 cc 6m 24s the patch passed -1 javac 8m 46s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 738 unchanged - 1 fixed = 739 total (was 739) +1 javac 6m 24s the patch passed +1 compile 7m 2s the patch passed with JDK v1.7.0_91 +1 cc 7m 2s the patch passed -1 javac 15m 48s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 734 unchanged - 1 fixed = 735 total (was 735) +1 javac 7m 2s the patch passed -1 checkstyle 1m 14s root: patch generated 71 new + 656 unchanged - 6 fixed = 727 total (was 662) +1 mvnsite 2m 28s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 10s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) -1 findbugs 2m 9s hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 2m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91 +1 unit 6m 32s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 52m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 6m 47s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 49m 24s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 187m 24s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 58]   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 54]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 45]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 44] FindBugs module:hadoop-hdfs-project/hadoop-hdfs   org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper$RawBlockChecksumComputer.readBlockCrc() ignores result of java.io.DataInputStream.read(byte[]) At BlockChecksumHelper.java: At BlockChecksumHelper.java: [line 252]   org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper$RawBlockChecksumComputer.readBlockCrc() ignores result of java.io.DataInputStream.skip(long) At BlockChecksumHelper.java: At BlockChecksumHelper.java: [line 248] JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestFsDatasetCache JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785503/HDFS-9694-v2.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 23504cab4314 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8f2622b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14319/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14319/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          As the patch is too large, opened HDFS-9733 to do the refactoring of DFSClient#getFileChecksum and DataXceiver#blockChecksum first.

          Show
          drankye Kai Zheng added a comment - As the patch is too large, opened HDFS-9733 to do the refactoring of DFSClient#getFileChecksum and DataXceiver#blockChecksum first.
          Hide
          drankye Kai Zheng added a comment -

          Rebased and refined.

          Show
          drankye Kai Zheng added a comment - Rebased and refined.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 41s Maven dependency ordering for branch
          +1 mvninstall 7m 7s trunk passed
          +1 compile 1m 43s trunk passed with JDK v1.8.0_74
          +1 compile 1m 26s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 36s trunk passed
          +1 javadoc 1m 39s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 16s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 1m 40s the patch passed with JDK v1.8.0_74
          +1 cc 1m 40s the patch passed
          -1 javac 3m 7s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 40s the patch passed
          +1 compile 1m 26s the patch passed with JDK v1.7.0_95
          +1 cc 1m 26s the patch passed
          -1 javac 4m 34s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 26s the patch passed
          -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 18 new + 263 unchanged - 0 fixed = 281 total (was 263)
          +1 mvnsite 1m 24s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 10s the patch passed with JDK v1.7.0_95
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 77m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 75m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          193m 50s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 58]
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 54]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 45]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 44]
          JDK v1.8.0_74 Failed junit tests hadoop.cli.TestHDFSCLI
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
          JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791655/HDFS-9694-v3.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux d6353998f677 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 19ee185
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14728/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14728/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 41s Maven dependency ordering for branch +1 mvninstall 7m 7s trunk passed +1 compile 1m 43s trunk passed with JDK v1.8.0_74 +1 compile 1m 26s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 36s trunk passed +1 javadoc 1m 39s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 1m 40s the patch passed with JDK v1.8.0_74 +1 cc 1m 40s the patch passed -1 javac 3m 7s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 40s the patch passed +1 compile 1m 26s the patch passed with JDK v1.7.0_95 +1 cc 1m 26s the patch passed -1 javac 4m 34s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 26s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 18 new + 263 unchanged - 0 fixed = 281 total (was 263) +1 mvnsite 1m 24s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 10s the patch passed with JDK v1.7.0_95 +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 77m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 75m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 193m 50s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 58]   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 54]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 45]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 44] JDK v1.8.0_74 Failed junit tests hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791655/HDFS-9694-v3.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux d6353998f677 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19ee185 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14728/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14728/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch, fixing the related test failure and addressing the check styles. The findbugs were not fixed as they're intended.

          Show
          drankye Kai Zheng added a comment - Updated the patch, fixing the related test failure and addressing the check styles. The findbugs were not fixed as they're intended.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 6m 52s trunk passed
          +1 compile 1m 31s trunk passed with JDK v1.8.0_74
          +1 compile 1m 22s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 3m 31s trunk passed
          +1 javadoc 1m 32s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 13s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 30s the patch passed with JDK v1.8.0_74
          +1 cc 1m 30s the patch passed
          -1 javac 2m 55s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 30s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.7.0_95
          +1 cc 1m 20s the patch passed
          -1 javac 4m 15s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 20s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 12s the patch passed with JDK v1.7.0_95
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 63m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 58m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          160m 18s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 55]
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 51]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 42]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 41]
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791694/HDFS-9694-v4.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 9376cdbb32fd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 19ee185
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14730/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14730/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 compile 1m 31s trunk passed with JDK v1.8.0_74 +1 compile 1m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 1m 32s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 13s trunk passed with JDK v1.7.0_95 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 1m 30s the patch passed with JDK v1.8.0_74 +1 cc 1m 30s the patch passed -1 javac 2m 55s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 30s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_95 +1 cc 1m 20s the patch passed -1 javac 4m 15s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 20s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 12s the patch passed with JDK v1.7.0_95 +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 63m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 58m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 160m 18s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 55]   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 51]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 42]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 41] JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791694/HDFS-9694-v4.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 9376cdbb32fd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19ee185 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14730/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14730/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Hi Andrew Wang, the reported findbugs were introduced by the following code block. I'm wondering how to avoid them but meanwhile not to complicate the simple struct like class. Could you give a hint? Thanks.

          +  public StripedBlockInfo(ExtendedBlock block, DatanodeInfo[] datanodes,
          +                          Token<BlockTokenIdentifier>[] blockTokens,
          +                          ErasureCodingPolicy ecPolicy) {
          +    this.block = block;
          +    this.datanodes = datanodes;
          +    this.blockTokens = blockTokens;
          +    this.ecPolicy = ecPolicy;
          +  }
          +
          +  public ExtendedBlock getBlock() {
          +    return block;
          +  }
          +
          +  public DatanodeInfo[] getDatanodes() {
          +    return datanodes;
          +  }
          +
          +  public Token<BlockTokenIdentifier>[] getBlockTokens() {
          +    return blockTokens;
          +  }
          +
          +  public ErasureCodingPolicy getErasureCodingPolicy() {
          +    return ecPolicy;
          +  }
          +}
          
          Show
          drankye Kai Zheng added a comment - Hi Andrew Wang , the reported findbugs were introduced by the following code block. I'm wondering how to avoid them but meanwhile not to complicate the simple struct like class. Could you give a hint? Thanks. + public StripedBlockInfo(ExtendedBlock block, DatanodeInfo[] datanodes, + Token<BlockTokenIdentifier>[] blockTokens, + ErasureCodingPolicy ecPolicy) { + this .block = block; + this .datanodes = datanodes; + this .blockTokens = blockTokens; + this .ecPolicy = ecPolicy; + } + + public ExtendedBlock getBlock() { + return block; + } + + public DatanodeInfo[] getDatanodes() { + return datanodes; + } + + public Token<BlockTokenIdentifier>[] getBlockTokens() { + return blockTokens; + } + + public ErasureCodingPolicy getErasureCodingPolicy() { + return ecPolicy; + } +}
          Hide
          andrew.wang Andrew Wang added a comment -

          Findbugs might be sensing confusion because the member references are all final, but the contents themselves are still mutable.

          If removing the final doesn't work, we can just add these to the findbugs exclude list at ./hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml.

          Show
          andrew.wang Andrew Wang added a comment - Findbugs might be sensing confusion because the member references are all final , but the contents themselves are still mutable. If removing the final doesn't work, we can just add these to the findbugs exclude list at ./hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml .
          Hide
          drankye Kai Zheng added a comment -

          Thanks Andrew Wang for the nice hint and I will try it!

          Show
          drankye Kai Zheng added a comment - Thanks Andrew Wang for the nice hint and I will try it!
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch for addressing the findbugs.

          Show
          drankye Kai Zheng added a comment - Updated the patch for addressing the findbugs.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 31s Maven dependency ordering for branch
          +1 mvninstall 6m 53s trunk passed
          +1 compile 1m 16s trunk passed with JDK v1.8.0_74
          +1 compile 1m 21s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 36s trunk passed
          +1 javadoc 1m 29s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 18s the patch passed with JDK v1.8.0_74
          +1 cc 1m 18s the patch passed
          -1 javac 2m 43s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 18s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.7.0_95
          +1 cc 1m 20s the patch passed
          -1 javac 4m 4s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 20s the patch passed
          +1 checkstyle 0m 28s the patch passed
          +1 mvnsite 1m 23s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 9s the patch passed with JDK v1.7.0_95
          +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          +1 unit 71m 4s hadoop-hdfs in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 71m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          180m 50s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 55]
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 51]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 42]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 41]
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792152/HDFS-9694-v5.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 0e7b0417c1ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 55f73a1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14748/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14748/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_74 +1 compile 1m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 36s trunk passed +1 javadoc 1m 29s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 18s the patch passed with JDK v1.8.0_74 +1 cc 1m 18s the patch passed -1 javac 2m 43s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 18s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_95 +1 cc 1m 20s the patch passed -1 javac 4m 4s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 20s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 23s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 9s the patch passed with JDK v1.7.0_95 +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. +1 unit 71m 4s hadoop-hdfs in the patch passed with JDK v1.8.0_74. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 71m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 180m 50s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 55]   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 51]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 42]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 41] JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792152/HDFS-9694-v5.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 0e7b0417c1ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 55f73a1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14748/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14748/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14748/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          TestDataNodeLifeline has an unrelated intermittent failure, already tracked in HDFS-9911.

          Show
          cnauroth Chris Nauroth added a comment - TestDataNodeLifeline has an unrelated intermittent failure, already tracked in HDFS-9911 .
          Hide
          drankye Kai Zheng added a comment -

          Thanks Chris Nauroth for the nice hint!

          Show
          drankye Kai Zheng added a comment - Thanks Chris Nauroth for the nice hint!
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Kai Zheng, Thanks for working on this patch. Great work.
          Here is my comments/questions

          1. StripedBlockChecksumComputer : Seems like we will actually don’t do anything with stripes here. We are calculating checksum by block levels right. So, this should be like StripedBGBlockCheksumComputer/BlockGroupBlockChecksumComputer ? So that later When we implement pure stripe based checksum calculation we could name it as StripedBGStripeCheksumComputer/BlockGroupStripedChecksumComputer? Just a thought.
          2. StripedFileChecksumComputer : Here also same as above. But I am not strong on name at this time but below is my thought, How about StripedFileBlkLevelChecksumComputer and Later when we compute stripe based computer we name it as StripedFileStripeLevelChecksumComputer? Just a thought, it will great if we get more better meaningful naming.
          3. I think client’s getFileCheckSum should have proper java doc which would explain that when we call this API on striped file, it should say that block level checksum would be calculated but not stripe level and checksum result can’t be compared with replicated file checksum result.
          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Kai Zheng , Thanks for working on this patch. Great work. Here is my comments/questions StripedBlockChecksumComputer : Seems like we will actually don’t do anything with stripes here. We are calculating checksum by block levels right. So, this should be like StripedBGBlockCheksumComputer/BlockGroupBlockChecksumComputer ? So that later When we implement pure stripe based checksum calculation we could name it as StripedBGStripeCheksumComputer/BlockGroupStripedChecksumComputer? Just a thought. StripedFileChecksumComputer : Here also same as above. But I am not strong on name at this time but below is my thought, How about StripedFileBlkLevelChecksumComputer and Later when we compute stripe based computer we name it as StripedFileStripeLevelChecksumComputer? Just a thought, it will great if we get more better meaningful naming. I think client’s getFileCheckSum should have proper java doc which would explain that when we call this API on striped file, it should say that block level checksum would be calculated but not stripe level and checksum result can’t be compared with replicated file checksum result.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Uma Maheswara Rao G for the review and nice suggestions. The renaming makes a lot sense to consider the following work for the real striped approach for striped file and blocks. I absorbed your thinkings and adapted some bit, resulting this updated patch.
          Change summary:

          • Javadoc update for getFileChecksum, done;
          • Renamed: StripedFileChecksumComputer => StripedFileNonStripedChecksumComputer; StripedBlockChecksumComputer => NonStripedBlockGroupChecksumComputer.

          Please let me know if this works for you or not, thanks.

          Show
          drankye Kai Zheng added a comment - Thanks Uma Maheswara Rao G for the review and nice suggestions. The renaming makes a lot sense to consider the following work for the real striped approach for striped file and blocks. I absorbed your thinkings and adapted some bit, resulting this updated patch. Change summary: Javadoc update for getFileChecksum , done; Renamed: StripedFileChecksumComputer => StripedFileNonStripedChecksumComputer; StripedBlockChecksumComputer => NonStripedBlockGroupChecksumComputer. Please let me know if this works for you or not, thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 1m 18s trunk passed with JDK v1.8.0_74
          +1 compile 1m 21s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 35s trunk passed
          +1 javadoc 1m 23s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 18s the patch passed with JDK v1.8.0_74
          +1 cc 1m 18s the patch passed
          -1 javac 2m 44s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 18s the patch passed
          +1 compile 1m 19s the patch passed with JDK v1.7.0_95
          +1 cc 1m 19s the patch passed
          -1 javac 4m 3s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 19s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 javadoc 1m 25s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 6s the patch passed with JDK v1.7.0_95
          +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 58m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          149m 57s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 55]
            org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 51]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:[line 42]
            new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:[line 41]
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793522/HDFS-9694-v6.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 88253bfa36f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5de848c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14825/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14825/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 1m 18s trunk passed with JDK v1.8.0_74 +1 compile 1m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 35s trunk passed +1 javadoc 1m 23s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 1m 18s the patch passed with JDK v1.8.0_74 +1 cc 1m 18s the patch passed -1 javac 2m 44s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 18s the patch passed +1 compile 1m 19s the patch passed with JDK v1.7.0_95 +1 cc 1m 19s the patch passed -1 javac 4m 3s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 19s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 javadoc 1m 25s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 6s the patch passed with JDK v1.7.0_95 +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 58m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 53m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 149m 57s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getBlockTokens() may expose internal representation by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java:by returning StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 55]   org.apache.hadoop.hdfs.protocol.StripedBlockInfo.getDatanodes() may expose internal representation by returning StripedBlockInfo.datanodes At StripedBlockInfo.java:by returning StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 51]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.blockTokens At StripedBlockInfo.java: [line 42]   new org.apache.hadoop.hdfs.protocol.StripedBlockInfo(ExtendedBlock, DatanodeInfo[], Token[], ErasureCodingPolicy) may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java:may expose internal representation by storing an externally mutable object into StripedBlockInfo.datanodes At StripedBlockInfo.java: [line 41] JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793522/HDFS-9694-v6.patch JIRA Issue HDFS-9694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 88253bfa36f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5de848c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14825/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14825/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14825/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks Kai Zheng for the update. Better now when considering Stripe and NonStripe way for checksum computers.

          Findbug comments still showing up. I think you need to add the find bug comments in ./hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml file.
          You may want to add you class in this section

          <Match>
              <Or>
                <Class name="org.apache.hadoop.fs.XAttr"/>
                <Class name="org.apache.hadoop.fs.XAttr$Builder"/>
                <Class name="org.apache.hadoop.hdfs.inotify.EventBatch"/>
                <Class name="org.apache.hadoop.hdfs.protocol.HdfsFileStatus"/>
                <Class name="org.apache.hadoop.hdfs.protocol.LocatedBlock"/>
                <Class name="org.apache.hadoop.hdfs.protocol.BlockStoragePolicy"/>
                <Class name="org.apache.hadoop.hdfs.protocol.CorruptFileBlocks"/>
                <Class name="org.apache.hadoop.hdfs.protocol.DirectoryListing"/>
                <Class name="org.apache.hadoop.hdfs.security.token.block.BlockTokenIdentifier"/>
                <Class name="org.apache.hadoop.hdfs.security.token.block.DataEncryptionKey"/>
                <Class name="org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry"/>
                <Class name="org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus"/>
                <Class name="org.apache.hadoop.hdfs.server.protocol.DatanodeStorageReport"/>
                <Class name="org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslResponseWithNegotiatedCipherOption"/>
                <Class name="org.apache.hadoop.hdfs.DFSPacket"/>
                <Class name="org.apache.hadoop.hdfs.protocol.LocatedStripedBlock"/>
                <Class name="org.apache.hadoop.hdfs.util.StripedBlockUtil$ChunkByteArray"/>
              </Or>
              <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
          </Match>
          
          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks Kai Zheng for the update. Better now when considering Stripe and NonStripe way for checksum computers. Findbug comments still showing up. I think you need to add the find bug comments in ./hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml file. You may want to add you class in this section <Match> <Or> <Class name="org.apache.hadoop.fs.XAttr"/> <Class name="org.apache.hadoop.fs.XAttr$Builder"/> <Class name="org.apache.hadoop.hdfs.inotify.EventBatch"/> <Class name="org.apache.hadoop.hdfs.protocol.HdfsFileStatus"/> <Class name="org.apache.hadoop.hdfs.protocol.LocatedBlock"/> <Class name="org.apache.hadoop.hdfs.protocol.BlockStoragePolicy"/> <Class name="org.apache.hadoop.hdfs.protocol.CorruptFileBlocks"/> <Class name="org.apache.hadoop.hdfs.protocol.DirectoryListing"/> <Class name="org.apache.hadoop.hdfs.security.token.block.BlockTokenIdentifier"/> <Class name="org.apache.hadoop.hdfs.security.token.block.DataEncryptionKey"/> <Class name="org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry"/> <Class name="org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus"/> <Class name="org.apache.hadoop.hdfs.server.protocol.DatanodeStorageReport"/> <Class name="org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslResponseWithNegotiatedCipherOption"/> <Class name="org.apache.hadoop.hdfs.DFSPacket"/> <Class name="org.apache.hadoop.hdfs.protocol.LocatedStripedBlock"/> <Class name="org.apache.hadoop.hdfs.util.StripedBlockUtil$ChunkByteArray"/> </Or> <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" /> </Match>
          Hide
          drankye Kai Zheng added a comment -

          Thanks Uma Maheswara Rao G for the reminding! I had thought I need to do it separately to fix the findbugs checking, but as you suggested, we should do it right now here, just add the new class in the list. Will update the patch accordingly.

          Show
          drankye Kai Zheng added a comment - Thanks Uma Maheswara Rao G for the reminding! I had thought I need to do it separately to fix the findbugs checking, but as you suggested, we should do it right now here, just add the new class in the list. Will update the patch accordingly.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch to avoid the findbugs checking on StripedBlockInfo.java file.

          Show
          drankye Kai Zheng added a comment - Updated the patch to avoid the findbugs checking on StripedBlockInfo.java file.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 52s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 1m 23s trunk passed with JDK v1.8.0_74
          +1 compile 1m 19s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 33s trunk passed
          +1 javadoc 1m 27s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.8.0_74
          +1 cc 1m 22s the patch passed
          -1 javac 2m 47s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 22s the patch passed
          +1 compile 1m 18s the patch passed with JDK v1.7.0_95
          +1 cc 1m 18s the patch passed
          -1 javac 4m 5s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 18s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 55s the patch passed
          +1 javadoc 1m 20s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95
          +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          +1 unit 61m 15s hadoop-hdfs in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 4s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          155m 5s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.qjournal.TestSecureNNWithQJM



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793938/HDFS-9694-v7.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux a45c529241e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 80fa70c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14851/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14851/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 52s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 1m 23s trunk passed with JDK v1.8.0_74 +1 compile 1m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 33s trunk passed +1 javadoc 1m 27s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 22s the patch passed with JDK v1.8.0_74 +1 cc 1m 22s the patch passed -1 javac 2m 47s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 22s the patch passed +1 compile 1m 18s the patch passed with JDK v1.7.0_95 +1 cc 1m 18s the patch passed -1 javac 4m 5s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 18s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 55s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95 +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. +1 unit 61m 15s hadoop-hdfs in the patch passed with JDK v1.8.0_74. +1 unit 1m 4s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 55m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 155m 5s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.qjournal.TestSecureNNWithQJM Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793938/HDFS-9694-v7.patch JIRA Issue HDFS-9694 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux a45c529241e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 80fa70c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14851/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14851/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14851/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Hi Kai Zheng, I have a question,

           send(out, Op.BLOCK_GROUP_CHECKSUM, proto);
          

          Are you planning to have a flag to indicate striped or non striped modes later? or you want to have separate flag itself?

          NonStripedBlockGroupChecksumComputer --> BlockGroupNonStripedChecksumComputer is more consistent with StripedFileNonStripedChecksumComputer?

          Other than this mostly looks good to me. Once they addressed and if no objections from others, I plan to commit this.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Hi Kai Zheng , I have a question, send(out, Op.BLOCK_GROUP_CHECKSUM, proto); Are you planning to have a flag to indicate striped or non striped modes later? or you want to have separate flag itself? NonStripedBlockGroupChecksumComputer --> BlockGroupNonStripedChecksumComputer is more consistent with StripedFileNonStripedChecksumComputer? Other than this mostly looks good to me. Once they addressed and if no objections from others, I plan to commit this.
          Hide
          drankye Kai Zheng added a comment -

          Hi Uma Maheswara Rao G, thanks for the more review!

          Are you planning to have a flag to indicate striped or non striped modes later? or you want to have separate flag itself?

          Good question! In my early work I had a flag in the new OpBlockGroupChecksumProto where I added the flag. The code was as follows.

          +  @Override
          +  public void blockGroupChecksum(StripedBlockInfo stripedBlockInfo,
          +         Token<BlockTokenIdentifier> blockToken, int mode) throws IOException {
          +    OpBlockGroupChecksumProto proto = OpBlockGroupChecksumProto.newBuilder()
          +        .setHeader(DataTransferProtoUtil.buildBaseHeader(
          +            stripedBlockInfo.getBlock(), blockToken))
          +        .setDatanodes(PBHelperClient.convertToProto(
          +            stripedBlockInfo.getDatanodes()))
          +        .addAllBlockTokens(PBHelperClient.convert(
          +            stripedBlockInfo.getBlockTokens()))
          +        .setEcPolicy(PBHelperClient.convertErasureCodingPolicy(
          +            stripedBlockInfo.getErasureCodingPolicy()))
          +        .setMode(mode)
          +        .build();
          +
          +    send(out, Op.BLOCK_GROUP_CHECKSUM, proto);
          +  }
          

          I guess I'd better incorporate the change in the patch to be in together, so we may avoid the further change into the protocol. Sounds good?

          NonStripedBlockGroupChecksumComputer --> BlockGroupNonStripedChecksumComputer is more consistent with StripedFileNonStripedChecksumComputer?

          Yeah, agree. Will do the change.

          Show
          drankye Kai Zheng added a comment - Hi Uma Maheswara Rao G , thanks for the more review! Are you planning to have a flag to indicate striped or non striped modes later? or you want to have separate flag itself? Good question! In my early work I had a flag in the new OpBlockGroupChecksumProto where I added the flag. The code was as follows. + @Override + public void blockGroupChecksum(StripedBlockInfo stripedBlockInfo, + Token<BlockTokenIdentifier> blockToken, int mode) throws IOException { + OpBlockGroupChecksumProto proto = OpBlockGroupChecksumProto.newBuilder() + .setHeader(DataTransferProtoUtil.buildBaseHeader( + stripedBlockInfo.getBlock(), blockToken)) + .setDatanodes(PBHelperClient.convertToProto( + stripedBlockInfo.getDatanodes())) + .addAllBlockTokens(PBHelperClient.convert( + stripedBlockInfo.getBlockTokens())) + .setEcPolicy(PBHelperClient.convertErasureCodingPolicy( + stripedBlockInfo.getErasureCodingPolicy())) + .setMode(mode) + .build(); + + send(out, Op.BLOCK_GROUP_CHECKSUM, proto); + } I guess I'd better incorporate the change in the patch to be in together, so we may avoid the further change into the protocol. Sounds good? NonStripedBlockGroupChecksumComputer --> BlockGroupNonStripedChecksumComputer is more consistent with StripedFileNonStripedChecksumComputer? Yeah, agree. Will do the change.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          I guess I'd better incorporate the change in the patch to be in together, so we may avoid the further change into the protocol. Sounds good?

          I would recommend not to incorporate future related changes in this JIRA. Let that change go into other JIRA when thats needed. I just wanted to know your idea because, if the plan is not by handling with flag, then op name might need to refine. But flag is good idea in general. So, I am good with flag and leave that change to next JIRA.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - I guess I'd better incorporate the change in the patch to be in together, so we may avoid the further change into the protocol. Sounds good? I would recommend not to incorporate future related changes in this JIRA. Let that change go into other JIRA when thats needed. I just wanted to know your idea because, if the plan is not by handling with flag, then op name might need to refine. But flag is good idea in general. So, I am good with flag and leave that change to next JIRA.
          Hide
          drankye Kai Zheng added a comment -

          So, I am good with flag and leave that change to next JIRA.

          Thanks Uma for this suggestion. Sounds good and I will update the patch as discussed.

          Show
          drankye Kai Zheng added a comment - So, I am good with flag and leave that change to next JIRA. Thanks Uma for this suggestion. Sounds good and I will update the patch as discussed.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch as discussed above.

          Show
          drankye Kai Zheng added a comment - Updated the patch as discussed above.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 6m 36s trunk passed
          +1 compile 1m 18s trunk passed with JDK v1.8.0_74
          +1 compile 1m 22s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 39s trunk passed
          +1 javadoc 1m 30s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 11s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.8.0_74
          +1 cc 1m 20s the patch passed
          -1 javac 2m 46s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49)
          +1 javac 1m 20s the patch passed
          +1 compile 1m 19s the patch passed with JDK v1.7.0_95
          +1 cc 1m 19s the patch passed
          -1 javac 4m 6s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51)
          +1 javac 1m 19s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 4s the patch passed
          +1 javadoc 1m 24s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 10s the patch passed with JDK v1.7.0_95
          +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 56m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 unit 54m 4s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          147m 59s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.balancer.TestBalancer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794913/HDFS-9694-v8.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 8da1ac336349 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a7d8f2b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt
          javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14902/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14902/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 1m 18s trunk passed with JDK v1.8.0_74 +1 compile 1m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 39s trunk passed +1 javadoc 1m 30s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 11s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 1m 20s the patch passed with JDK v1.8.0_74 +1 cc 1m 20s the patch passed -1 javac 2m 46s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) +1 javac 1m 20s the patch passed +1 compile 1m 19s the patch passed with JDK v1.7.0_95 +1 cc 1m 19s the patch passed -1 javac 4m 6s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 50 unchanged - 1 fixed = 51 total (was 51) +1 javac 1m 19s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 4s the patch passed +1 javadoc 1m 24s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 10s the patch passed with JDK v1.7.0_95 +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 56m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 unit 54m 4s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 147m 59s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794913/HDFS-9694-v8.patch JIRA Issue HDFS-9694 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 8da1ac336349 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7d8f2b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_74.txt javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14902/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14902/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Attempted to resolve the Javac issue.

          Show
          drankye Kai Zheng added a comment - Attempted to resolve the Javac issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 1m 13s trunk passed with JDK v1.8.0_74
          +1 compile 1m 18s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 33s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 15s the patch passed
          +1 compile 1m 10s the patch passed with JDK v1.8.0_74
          +1 cc 1m 10s the patch passed
          +1 javac 2m 34s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49)
          +1 javac 1m 10s hadoop-hdfs-project in the patch passed with JDK v1.8.0_74.
          +1 compile 1m 18s the patch passed with JDK v1.7.0_95
          +1 cc 1m 18s the patch passed
          +1 javac 3m 52s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 50 unchanged - 1 fixed = 50 total (was 51)
          +1 javac 1m 18s hadoop-hdfs-project in the patch passed with JDK v1.7.0_95.
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 58s the patch passed
          +1 javadoc 1m 19s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 8s the patch passed with JDK v1.7.0_95
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          +1 unit 62m 10s hadoop-hdfs in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 52m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          151m 5s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795180/HDFS-9694-v9.patch
          JIRA Issue HDFS-9694
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux aa3d181d6222 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 19b645c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14922/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14922/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14922/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14922/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 1m 13s trunk passed with JDK v1.8.0_74 +1 compile 1m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 33s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_74 +1 cc 1m 10s the patch passed +1 javac 2m 34s hadoop-hdfs-project-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) +1 javac 1m 10s hadoop-hdfs-project in the patch passed with JDK v1.8.0_74. +1 compile 1m 18s the patch passed with JDK v1.7.0_95 +1 cc 1m 18s the patch passed +1 javac 3m 52s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 50 unchanged - 1 fixed = 50 total (was 51) +1 javac 1m 18s hadoop-hdfs-project in the patch passed with JDK v1.7.0_95. +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 8s the patch passed with JDK v1.7.0_95 +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. +1 unit 62m 10s hadoop-hdfs in the patch passed with JDK v1.8.0_74. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 52m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 151m 5s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795180/HDFS-9694-v9.patch JIRA Issue HDFS-9694 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux aa3d181d6222 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19b645c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14922/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14922/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14922/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14922/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Overall latest patch looking good to me. +1
          I will go ahead and push this patch shortly. Thanks Kai for your hard work on this.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Overall latest patch looking good to me. +1 I will go ahead and push this patch shortly. Thanks Kai for your hard work on this.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          I have just committed this patch to trunk.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - I have just committed this patch to trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9503 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9503/)
          HDFS-9694. Make existing DFSClient#getFileChecksum() work for striped (uma.gangumalla: rev e5ff0ea7ba087984262f1f27200ae5bb40d9b838)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9503 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9503/ ) HDFS-9694 . Make existing DFSClient#getFileChecksum() work for striped (uma.gangumalla: rev e5ff0ea7ba087984262f1f27200ae5bb40d9b838) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java
          Hide
          lewuathe Kai Sasaki added a comment -

          Uma Maheswara Rao G Did you commit the latest patch? We cannot find StripedBlockInfo and building trunk fails.

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-hdfs-client: Compilation failure: Compilation failure:
          [ERROR] /Users/sasakikai/dev/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java:[31,39] cannot find symbol
          [ERROR] symbol:   class StripedBlockInfo
          [ERROR] location: package org.apache.hadoop.hdfs.protocol
          [ERROR] /Users/sasakikai/dev/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java:[31,39] cannot find symbol
          

          https://github.com/apache/hadoop/commit/e5ff0ea7ba087984262f1f27200ae5bb40d9b838

          Show
          lewuathe Kai Sasaki added a comment - Uma Maheswara Rao G Did you commit the latest patch? We cannot find StripedBlockInfo and building trunk fails. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile ( default -compile) on project hadoop-hdfs-client: Compilation failure: Compilation failure: [ERROR] /Users/sasakikai/dev/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java:[31,39] cannot find symbol [ERROR] symbol: class StripedBlockInfo [ERROR] location: package org.apache.hadoop.hdfs.protocol [ERROR] /Users/sasakikai/dev/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java:[31,39] cannot find symbol https://github.com/apache/hadoop/commit/e5ff0ea7ba087984262f1f27200ae5bb40d9b838
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Reopening - I've reverted this commit for now as it broke the trunk build.

          Show
          arpitagarwal Arpit Agarwal added a comment - Reopening - I've reverted this commit for now as it broke the trunk build.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9504 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9504/)
          Revert "HDFS-9694. Make existing DFSClient#getFileChecksum() work for (arp: rev a337ceb74e984991dbf976236d2e785cf5921b16)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9504 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9504/ ) Revert " HDFS-9694 . Make existing DFSClient#getFileChecksum() work for (arp: rev a337ceb74e984991dbf976236d2e785cf5921b16) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Hide
          lewuathe Kai Sasaki added a comment -

          Arpit Agarwal Thank you so much!

          Show
          lewuathe Kai Sasaki added a comment - Arpit Agarwal Thank you so much!
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks Arpit Agarwal and Kai Sasaki for noticing and reverting. I will check and recommit it. Thanks

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks Arpit Agarwal and Kai Sasaki for noticing and reverting. I will check and recommit it. Thanks
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          I have just committed this. Before it was my mistake, missed to add newly added file. Thanks

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - I have just committed this. Before it was my mistake, missed to add newly added file. Thanks
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9505 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9505/)
          HDFS-9694. Make existing DFSClient#getFileChecksum() work for striped (uma.gangumalla: rev 3a4ff7776e8fab6cc87932b9aa8fb48f7b69c720)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/StripedBlockInfo.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileChecksum.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9505 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9505/ ) HDFS-9694 . Make existing DFSClient#getFileChecksum() work for striped (uma.gangumalla: rev 3a4ff7776e8fab6cc87932b9aa8fb48f7b69c720) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/StripedBlockInfo.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileChecksum.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/datatransfer.proto
          Hide
          drankye Kai Zheng added a comment -

          Thanks all for the takings!
          Thanks Uma Maheswara Rao G for the great review and committing of this!

          Show
          drankye Kai Zheng added a comment - Thanks all for the takings! Thanks Uma Maheswara Rao G for the great review and committing of this!

            People

            • Assignee:
              drankye Kai Zheng
              Reporter:
              drankye Kai Zheng
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development