Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9677

Rename generationStampV1/generationStampV2 to legacyGenerationStamp/generationStamp

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      comment from Kai Zheng in HDFS-9542:

      Just wonder if it's a good idea to rename: generationStampV1 => legacyGenerationStamp; generationStampV2 => generationStamp, similar for other variables, as we have legacy block and block.

      This jira plans to do this rename.

      1. HDFS-9677-branch-2.000.patch
        26 kB
        Mingliang Liu
      2. HDFS-9677.001.patch
        29 kB
        Mingliang Liu
      3. HDFS-9677.000.patch
        42 kB
        Mingliang Liu

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9196 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9196/)
        Revert "HDFS-9677. Rename generationStampV1/generationStampV2 to (jing9: rev 3a9571308e99cc374681bbc451a517d41a150aa0)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          HDFS-9677. Rename generationStampV1/generationStampV2 to (jing9: rev ec25c7f9c7e60c077d8c4143253c20445fcdaecf)
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9196 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9196/ ) Revert " HDFS-9677 . Rename generationStampV1/generationStampV2 to (jing9: rev 3a9571308e99cc374681bbc451a517d41a150aa0) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java HDFS-9677 . Rename generationStampV1/generationStampV2 to (jing9: rev ec25c7f9c7e60c077d8c4143253c20445fcdaecf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9195 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9195/)
        HDFS-9677. Rename generationStampV1/generationStampV2 to (jing9: rev 8a91109d16394310f2568717f103e6fff7cbddb0)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9195 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9195/ ) HDFS-9677 . Rename generationStampV1/generationStampV2 to (jing9: rev 8a91109d16394310f2568717f103e6fff7cbddb0) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfLegacyGenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/OutOfV1GenerationStampsException.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for the commit, Jing Zhao!

        Show
        liuml07 Mingliang Liu added a comment - Thanks for the commit, Jing Zhao !
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for the branch-2 patch, Mingliang. I've committed this to trunk and branch-2.

        Show
        jingzhao Jing Zhao added a comment - Thanks for the branch-2 patch, Mingliang. I've committed this to trunk and branch-2.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for your review Jing Zhao. Attached the patch for branch-2.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for your review Jing Zhao . Attached the patch for branch-2.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for the work Mingliang! Thanks for the review, Vinayakumar B! The patch also looks good to me. +1. Will commit the patch shortly.

        Mingliang Liu, could you also post a patch for branch-2?

        Show
        jingzhao Jing Zhao added a comment - Thanks for the work Mingliang! Thanks for the review, Vinayakumar B ! The patch also looks good to me. +1. Will commit the patch shortly. Mingliang Liu , could you also post a patch for branch-2?
        Hide
        liuml07 Mingliang Liu added a comment -

        This makes perfect sense to me. Thanks for your comment and review, Vinayakumar B!

        Show
        liuml07 Mingliang Liu added a comment - This makes perfect sense to me. Thanks for your comment and review, Vinayakumar B !
        Hide
        vinayrpet Vinayakumar B added a comment -

        I feel current change is fine. legacyGenerationStamp looks better and inline with similar legacy things.

        Suppose a new user plays with generation stamp for the very first time, she needs to know implementation details before she is able to tell which one is legacy or deprecated. Even with current V1/V2 naming, we should not blame a new user who wonders whether a generationStampV3 version exists.

        First of all, Genstamp is not user-controlled or user-exposed. ( I mean, exactly user, not the developer ).
        Second, Since its legacy, its kept there just to support old blocks. Not to generate new blocks with that. New blocks will always be generated with newGenstamp itself.
        So IMO, its fine. No need to be so specific on implementation details.

        Show
        vinayrpet Vinayakumar B added a comment - I feel current change is fine. legacyGenerationStamp looks better and inline with similar legacy things. Suppose a new user plays with generation stamp for the very first time, she needs to know implementation details before she is able to tell which one is legacy or deprecated. Even with current V1/V2 naming, we should not blame a new user who wonders whether a generationStampV3 version exists. First of all, Genstamp is not user-controlled or user-exposed. ( I mean, exactly user, not the developer ). Second, Since its legacy, its kept there just to support old blocks. Not to generate new blocks with that. New blocks will always be generated with newGenstamp itself. So IMO, its fine. No need to be so specific on implementation details.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v1 patch basically renames the generationStampV1 => legacyGenerationStamp and generationStampV2 => generationStamp. I think the renaming is reasonable as I don't see any loss of readability. Meanwhile, there are existing comments for the usages of the variables to elaborate the difference. We have other cases using "legacy" in class/variable names, e.g. BlockReaderLocalLegacy, legacyBlock.
        Another option is to change generationStampV1 to generationStampRandom, generationStampV2 to generationStampSequential. These are real names. However, they're representing how it does, not exactly "what it does" 'cause they're implementation specific. Suppose a new user plays with generation stamp for the very first time, she needs to know implementation details before she is able to tell which one is legacy or deprecated. Even with current V1/V2 naming, we should not blame a new user who wonders whether a generationStampV3 version exists.

        I'd happy to refine the patch for further useful input.

        Show
        liuml07 Mingliang Liu added a comment - The v1 patch basically renames the generationStampV1 => legacyGenerationStamp and generationStampV2 => generationStamp . I think the renaming is reasonable as I don't see any loss of readability. Meanwhile, there are existing comments for the usages of the variables to elaborate the difference. We have other cases using "legacy" in class/variable names, e.g. BlockReaderLocalLegacy , legacyBlock . Another option is to change generationStampV1 to generationStampRandom , generationStampV2 to generationStampSequential . These are real names. However, they're representing how it does, not exactly "what it does" 'cause they're implementation specific. Suppose a new user plays with generation stamp for the very first time, she needs to know implementation details before she is able to tell which one is legacy or deprecated. Even with current V1/V2 naming, we should not blame a new user who wonders whether a generationStampV3 version exists. I'd happy to refine the patch for further useful input.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Change looks good.
        +1

        Show
        vinayrpet Vinayakumar B added a comment - Change looks good. +1
        Hide
        liuml07 Mingliang Liu added a comment -

        The failing tests seem unrelated. Specially, the TestBlockManagerSafeMode is tracked by HDFS-9691.

        Show
        liuml07 Mingliang Liu added a comment - The failing tests seem unrelated. Specially, the TestBlockManagerSafeMode is tracked by HDFS-9691 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 9m 10s trunk passed
        +1 compile 0m 56s trunk passed with JDK v1.8.0_66
        +1 compile 0m 45s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 13s trunk passed
        +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 1s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 54s the patch passed
        +1 compile 1m 1s the patch passed with JDK v1.8.0_66
        +1 cc 1m 1s the patch passed
        +1 javac 1m 1s the patch passed
        +1 compile 0m 49s the patch passed with JDK v1.7.0_91
        +1 cc 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 744 unchanged - 2 fixed = 745 total (was 746)
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 31s the patch passed
        +1 javadoc 1m 27s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 19s the patch passed with JDK v1.7.0_91
        -1 unit 61m 30s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 53m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        147m 21s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.TestSafeModeWithStripedFile
          hadoop.hdfs.server.datanode.TestBlockScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783994/HDFS-9677.001.patch
        JIRA Issue HDFS-9677
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux af09e8240589 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14225/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14225/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 9m 10s trunk passed +1 compile 0m 56s trunk passed with JDK v1.8.0_66 +1 compile 0m 45s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 1s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 54s the patch passed +1 compile 1m 1s the patch passed with JDK v1.8.0_66 +1 cc 1m 1s the patch passed +1 javac 1m 1s the patch passed +1 compile 0m 49s the patch passed with JDK v1.7.0_91 +1 cc 0m 48s the patch passed +1 javac 0m 48s the patch passed -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 744 unchanged - 2 fixed = 745 total (was 746) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 31s the patch passed +1 javadoc 1m 27s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 19s the patch passed with JDK v1.7.0_91 -1 unit 61m 30s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 53m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 147m 21s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783994/HDFS-9677.001.patch JIRA Issue HDFS-9677 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux af09e8240589 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14225/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14225/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14225/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v1 patch fixes the failing test by reverting changes that may break edit stores XML format.

        Show
        liuml07 Mingliang Liu added a comment - The v1 patch fixes the failing test by reverting changes that may break edit stores XML format.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        +1 mvninstall 8m 5s trunk passed
        +1 compile 0m 39s trunk passed with JDK v1.8.0_66
        +1 compile 0m 43s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 50s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_66
        +1 cc 0m 39s the patch passed
        +1 javac 0m 39s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_91
        +1 cc 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -1 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 1130 unchanged - 9 fixed = 1139 total (was 1139)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91
        -1 unit 69m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 73m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        170m 1s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.TestDFSRemove
          hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783979/HDFS-9677.000.patch
        JIRA Issue HDFS-9677
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 2a4dc95f934a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14219/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14219/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. +1 mvninstall 8m 5s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 50s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 48s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_66 +1 cc 0m 39s the patch passed +1 javac 0m 39s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_91 +1 cc 0m 42s the patch passed +1 javac 0m 42s the patch passed -1 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 1130 unchanged - 9 fixed = 1139 total (was 1139) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91 -1 unit 69m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 73m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 170m 1s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestDFSRemove   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer JDK v1.7.0_91 Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783979/HDFS-9677.000.patch JIRA Issue HDFS-9677 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 2a4dc95f934a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14219/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14219/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14219/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v0 patch is to rename the variables and methods according to the description. The basic change includes BlockIdManager and FSEditLogOp. The protobuf is intact for backward compatibility, though renaming fields may be safe.

        Will refine the patch if it is either too aggressive or incomplete.

        Show
        liuml07 Mingliang Liu added a comment - The v0 patch is to rename the variables and methods according to the description. The basic change includes BlockIdManager and FSEditLogOp . The protobuf is intact for backward compatibility, though renaming fields may be safe. Will refine the patch if it is either too aggressive or incomplete.
        Hide
        liuml07 Mingliang Liu added a comment -

        The "legacy" is along with the old name e.g. legacyGenerationStamp. Any suggestion for a real name in this example? Thanks.

        Show
        liuml07 Mingliang Liu added a comment - The "legacy" is along with the old name e.g. legacyGenerationStamp . Any suggestion for a real name in this example? Thanks.
        Hide
        aw Allen Wittenauer added a comment -

        Calling something "legacy" is just as useless as calling something "default". Give it a real name to represent what it does.

        Show
        aw Allen Wittenauer added a comment - Calling something "legacy" is just as useless as calling something "default". Give it a real name to represent what it does.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            jingzhao Jing Zhao
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development