Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9398

Make ByteArraryManager log message in one-line format

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: hdfs-client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Per discussion in HDFS-8971, the ByteArrayManager should use one-line message. It's for sure easy to read, especially in case of multiple-threads. The easy fix is to use the old format before HDFS-8971.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2520 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2520/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2520 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2520/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #581 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/581/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #581 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/581/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for your review and commit.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for your review and commit.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/640/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/640/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2580 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2580/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2580 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2580/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1373 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1373/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1373 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1373/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #650 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/650/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #650 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/650/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8771 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8771/)
        HDFS-9398. Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8771 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8771/ ) HDFS-9398 . Make ByteArraryManager log message in one-line format. (szetszwo: rev 9614dea71a9700741388956044c5e6fde1754e28) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks Mingliang!

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks Mingliang!
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 4m 7s trunk passed
        +1 compile 0m 37s trunk passed with JDK v1.8.0_60
        +1 compile 0m 32s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 13s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 15s trunk passed
        +1 javadoc 0m 28s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_60
        +1 javac 0m 35s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.7.0_79
        +1 javac 0m 34s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 28s the patch passed
        +1 javadoc 0m 27s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 29s the patch passed with JDK v1.7.0_79
        +1 unit 1m 32s hadoop-hdfs-client in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 7s hadoop-hdfs-client in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        21m 20s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-07
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771143/HDFS-9398.000.patch
        JIRA Issue HDFS-9398
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 0a08e6ac7939 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / bf6aa30
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13427/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13427/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 4m 7s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_60 +1 compile 0m 32s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 13s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 15s trunk passed +1 javadoc 0m 28s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 38s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_60 +1 javac 0m 35s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_79 +1 javac 0m 34s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 0m 27s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_79 +1 unit 1m 32s hadoop-hdfs-client in the patch passed with JDK v1.8.0_60. +1 unit 1m 7s hadoop-hdfs-client in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 21m 20s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-07 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771143/HDFS-9398.000.patch JIRA Issue HDFS-9398 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 0a08e6ac7939 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / bf6aa30 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13427/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13427/console This message was automatically generated.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development