Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6200 Create a separate jar for hdfs-client
  3. HDFS-8971

Remove guards when calling LOG.debug() and LOG.trace() in client package

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We moved the shortcircuit package from hadoop-hdfs to hadoop-hdfs-client module in JIRA HDFS-8934 and HDFS-8951, and BlockReader in HDFS-8925. Meanwhile, we also replaced the log4j log with slf4j logger. There were existing code in the client package to guard the log when calling LOG.debug() and LOG.trace(), e.g. in ShortCircuitCache.java, we have code like this:

      Trace with guards
      724    if (LOG.isTraceEnabled()) {
      725      LOG.trace(this + ": found waitable for " + key);
      726    }
      

      In slf4j, this kind of guard is not necessary. We should clean the code by removing the guard from the client package.

      Trace without guards
      724    LOG.trace("{}: found waitable for {}", this, key);
      
      1. HDFS-8971.001.patch
        82 kB
        Mingliang Liu
      2. HDFS-8971.000.patch
        82 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuml07 commented on the issue:

          https://github.com/apache/hadoop/pull/46

          Can you create a JIRA on https://issues.apache.org/jira/browse/HDFS and change the title of this PR to link the JIRA here? See https://wiki.apache.org/hadoop/GithubIntegration for more information.

          For the code, the DataNode logging has switched to slf4j. Please use placeholders and guard statement like `if (LOG.isTraceEnabled())` is unnecessary. Please refer to https://issues.apache.org/jira/browse/HDFS-8971 for examples.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuml07 commented on the issue: https://github.com/apache/hadoop/pull/46 Can you create a JIRA on https://issues.apache.org/jira/browse/HDFS and change the title of this PR to link the JIRA here? See https://wiki.apache.org/hadoop/GithubIntegration for more information. For the code, the DataNode logging has switched to slf4j. Please use placeholders and guard statement like `if (LOG.isTraceEnabled())` is unnecessary. Please refer to https://issues.apache.org/jira/browse/HDFS-8971 for examples.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your suggestion Tsz Wo Nicholas Sze. I filed HDFS-9398 to track the effort of reverting changes in ByteArrayManager regarding the log message.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for your suggestion Tsz Wo Nicholas Sze . I filed HDFS-9398 to track the effort of reverting changes in ByteArrayManager regarding the log message.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Sure, please file a JIRA to revert the change. Thanks!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Sure, please file a JIRA to revert the change. Thanks!
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for reporting this Tsz Wo Nicholas Sze. I totally agree with you that we should consider one-line message in ByteArrayManager. It's for sure easy to read, especially in case of multiple-threads. Perhaps we can simply revert the changes in this class? I revisited the patch and other classes should be fine.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for reporting this Tsz Wo Nicholas Sze . I totally agree with you that we should consider one-line message in ByteArrayManager . It's for sure easy to read, especially in case of multiple-threads. Perhaps we can simply revert the changes in this class? I revisited the patch and other classes should be fine.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -
          • Before the change
            2015-11-06 23:56:12,610 [pool-1-thread-3] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(225): count=2, belowThreshold, return byte[256]
            2015-11-06 23:56:12,610 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(208): count=3, belowThreshold, return byte[256]
            2015-11-06 23:56:12,610 [pool-1-thread-5] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(7): count=1, belowThreshold, return byte[32]
            2015-11-06 23:56:12,610 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - recycle: array.length=128, freeQueueSize=-1
            
          • After the change
            2015-11-06 23:50:52,202 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(228)
            2015-11-06 23:50:52,202 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(110)
            2015-11-06 23:50:52,204 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold
            2015-11-06 23:50:52,205 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold
            2015-11-06 23:50:52,206 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte[256]
            2015-11-06 23:50:52,206 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte[128]
            2015-11-06 23:50:52,299 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(38)
            2015-11-06 23:50:52,300 [pool-1-thread-7] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(63)
            2015-11-06 23:50:52,299 [pool-1-thread-5] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(183)
            2015-11-06 23:50:52,300 [pool-1-thread-11] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(87)
            2015-11-06 23:50:52,300 [pool-1-thread-10] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(136)
            2015-11-06 23:50:52,300 [pool-1-thread-9] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(71)
            2015-11-06 23:50:52,300 [pool-1-thread-7] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=2, belowThreshold
            2015-11-06 23:50:52,301 [pool-1-thread-13] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(362)) - recycle: array.length=128
            2015-11-06 23:50:52,303 [pool-1-thread-13] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(372)) - , freeQueueSize=-1
            2015-11-06 23:50:52,300 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(211)
            2015-11-06 23:50:52,303 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=4, belowThreshold
            2015-11-06 23:50:52,300 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(114)
            2015-11-06 23:50:52,300 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold
            2015-11-06 23:50:52,300 [pool-1-thread-3] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(14)
            2015-11-06 23:50:52,303 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte[64]
            2015-11-06 23:50:52,303 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=4, belowThreshold
            2015-11-06 23:50:52,303 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte[256]
            2015-11-06 23:50:52,301 [pool-1-thread-18] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(143)
            2015-11-06 23:50:52,301 [pool-1-thread-17] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(180)
            2015-11-06 23:50:52,301 [pool-1-thread-16] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(133)
            2015-11-06 23:50:52,301 [pool-1-thread-15] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(121)
            2015-11-06 23:50:52,301 [pool-1-thread-14] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(362)) - recycle: array.length=256
            
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Before the change 2015-11-06 23:56:12,610 [pool-1-thread-3] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(225): count=2, belowThreshold, return byte [256] 2015-11-06 23:56:12,610 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(208): count=3, belowThreshold, return byte [256] 2015-11-06 23:56:12,610 [pool-1-thread-5] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - allocate(7): count=1, belowThreshold, return byte [32] 2015-11-06 23:56:12,610 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:logDebugMessage(48)) - recycle: array.length=128, freeQueueSize=-1 After the change 2015-11-06 23:50:52,202 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(228) 2015-11-06 23:50:52,202 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(110) 2015-11-06 23:50:52,204 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold 2015-11-06 23:50:52,205 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold 2015-11-06 23:50:52,206 [pool-1-thread-2] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte [256] 2015-11-06 23:50:52,206 [pool-1-thread-1] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte [128] 2015-11-06 23:50:52,299 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(38) 2015-11-06 23:50:52,300 [pool-1-thread-7] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(63) 2015-11-06 23:50:52,299 [pool-1-thread-5] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(183) 2015-11-06 23:50:52,300 [pool-1-thread-11] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(87) 2015-11-06 23:50:52,300 [pool-1-thread-10] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(136) 2015-11-06 23:50:52,300 [pool-1-thread-9] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(71) 2015-11-06 23:50:52,300 [pool-1-thread-7] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=2, belowThreshold 2015-11-06 23:50:52,301 [pool-1-thread-13] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(362)) - recycle: array.length=128 2015-11-06 23:50:52,303 [pool-1-thread-13] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(372)) - , freeQueueSize=-1 2015-11-06 23:50:52,300 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(211) 2015-11-06 23:50:52,303 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=4, belowThreshold 2015-11-06 23:50:52,300 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(114) 2015-11-06 23:50:52,300 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=1, belowThreshold 2015-11-06 23:50:52,300 [pool-1-thread-3] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(14) 2015-11-06 23:50:52,303 [pool-1-thread-4] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte [64] 2015-11-06 23:50:52,303 [pool-1-thread-6] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(342)) - : count=4, belowThreshold 2015-11-06 23:50:52,303 [pool-1-thread-8] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(347)) - , return byte [256] 2015-11-06 23:50:52,301 [pool-1-thread-18] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(143) 2015-11-06 23:50:52,301 [pool-1-thread-17] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(180) 2015-11-06 23:50:52,301 [pool-1-thread-16] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(133) 2015-11-06 23:50:52,301 [pool-1-thread-15] DEBUG util.ByteArrayManager (ByteArrayManager.java:newByteArray(328)) - allocate(121) 2015-11-06 23:50:52,301 [pool-1-thread-14] DEBUG util.ByteArrayManager (ByteArrayManager.java:release(362)) - recycle: array.length=256
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Hi, I appreciate using the new log API in order to make the code shorter in general but it may not be possible to remove the isDebugEnabled guards and keeping the same debug message format at the same time.

          It is hard to read the debug messages printed by ByteArrayManager after the change here since some one-line messages are printed in multiple lines. It is even worse when there are multiple threads. See the output of TestByteArrayManager (or the attached log in HDFS-9383).

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Hi, I appreciate using the new log API in order to make the code shorter in general but it may not be possible to remove the isDebugEnabled guards and keeping the same debug message format at the same time. It is hard to read the debug messages printed by ByteArrayManager after the change here since some one-line messages are printed in multiple lines. It is even worse when there are multiple threads. See the output of TestByteArrayManager (or the attached log in HDFS-9383 ).
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #437 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/437/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #437 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/437/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2377 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2377/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2377 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2377/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2405/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2405/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #470 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/470/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #470 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/470/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1201/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1201/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #462 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/462/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #462 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/462/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you Haohui Mai for reviewing and committing this patch.

          Show
          liuml07 Mingliang Liu added a comment - Thank you Haohui Mai for reviewing and committing this patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8544 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8544/)
          HDFS-8971. Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8544 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8544/ ) HDFS-8971 . Remove guards when calling LOG.debug() and LOG.trace() in client package. Contributed by Mingliang Liu. (wheat9: rev 39285e6a1978ea5e53bdc1b0aef62421382124a8) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitReplica.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitShm.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/TokenAspect.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Sender.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/ByteArrayManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.
          Hide
          wheat9 Haohui Mai added a comment -

          +1. Will commit shortly.

          Show
          wheat9 Haohui Mai added a comment - +1. Will commit shortly.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 13s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 37s The applied patch generated 3 new checkstyle issues (total was 801, now 778).
          +1 whitespace 0m 7s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 16s Pre-build of native portion
          +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.
              45m 54s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764336/HDFS-8971.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6f335e4
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12748/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12748/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12748/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12748/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 13s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 37s The applied patch generated 3 new checkstyle issues (total was 801, now 778). +1 whitespace 0m 7s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.     45m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764336/HDFS-8971.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6f335e4 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12748/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12748/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12748/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12748/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v1 patch addresses the whitespace and checkstyle warnings. Some existing (and independent) warning can be addressed separately as they are not related to this issue.

          Show
          liuml07 Mingliang Liu added a comment - The v1 patch addresses the whitespace and checkstyle warnings. Some existing (and independent) warning can be addressed separately as they are not related to this issue.
          Hide
          wheat9 Haohui Mai added a comment -

          The patch looks good to me. +1 after fixing the checkstyle / whitespace issues.

          Show
          wheat9 Haohui Mai added a comment - The patch looks good to me. +1 after fixing the checkstyle / whitespace issues.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 29s The applied patch generated 11 new checkstyle issues (total was 802, now 787).
          -1 whitespace 0m 7s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 10s Pre-build of native portion
          +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.
              44m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764309/HDFS-8971.000.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 80d33b5
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/whitespace.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12745/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12745/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 29s The applied patch generated 11 new checkstyle issues (total was 802, now 787). -1 whitespace 0m 7s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.     44m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764309/HDFS-8971.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 80d33b5 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/whitespace.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12745/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12745/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12745/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v0 patch removes the guards when calling LOG.trace and LOG.debug for the slf4j logger, and uses placeholders for passing parameters. The code to change was found by script:

          find hadoop-hdfs-project/hadoop-hdfs-client -name "*.java" |xargs egrep "LOG.isTraceEnabled|LOG.isDebugEnabled" -n
          

          Some of the existing usage of the is{Trace,Debug}Enabled was not removed because it's necessary, largely because of the overhead of calculating the parameters. Those excluded guards are for Arrays.asList(), StringUtils.getStackTrace(Thread.currentThread())) and user-defined methods. For example,

          LeaseRenewer.java
            if (LOG.isDebugEnabled()) {
              LOG.debug("Lease renewer daemon for " + clientsString() + " with renew id " + id + " exited");
            }
          
              ....
          
            /** Get the names of all clients */
            private synchronized String clientsString() {
              if (dfsclients.isEmpty()) {
                return "[]";
              } else {
                final StringBuilder b = new StringBuilder("[").append(
                    dfsclients.get(0).getClientName());
                for(int i = 1; i < dfsclients.size(); i++) {
                  b.append(", ").append(dfsclients.get(i).getClientName());
                }
                return b.append("]").toString();
              }
            }
          

          The clientString() is considered time-consuming and we should not simply remove the guard when calling the LOG.isDebugEnabled().

          Show
          liuml07 Mingliang Liu added a comment - The v0 patch removes the guards when calling LOG.trace and LOG.debug for the slf4j logger, and uses placeholders for passing parameters. The code to change was found by script: find hadoop-hdfs-project/hadoop-hdfs-client -name "*.java" |xargs egrep "LOG.isTraceEnabled|LOG.isDebugEnabled" -n Some of the existing usage of the is{Trace,Debug}Enabled was not removed because it's necessary, largely because of the overhead of calculating the parameters. Those excluded guards are for Arrays.asList() , StringUtils.getStackTrace(Thread.currentThread())) and user-defined methods. For example, LeaseRenewer.java if (LOG.isDebugEnabled()) { LOG.debug( "Lease renewer daemon for " + clientsString() + " with renew id " + id + " exited" ); } .... /** Get the names of all clients */ private synchronized String clientsString() { if (dfsclients.isEmpty()) { return "[]" ; } else { final StringBuilder b = new StringBuilder( "[" ).append( dfsclients.get(0).getClientName()); for ( int i = 1; i < dfsclients.size(); i++) { b.append( ", " ).append(dfsclients.get(i).getClientName()); } return b.append( "]" ).toString(); } } The clientString() is considered time-consuming and we should not simply remove the guard when calling the LOG.isDebugEnabled() .
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Walter Su! I'll also change the log parameter passing with placeholder to avoid unnecessary string concatenation.

          Show
          liuml07 Mingliang Liu added a comment - Thanks Walter Su ! I'll also change the log parameter passing with placeholder to avoid unnecessary string concatenation.
          Hide
          walter.k.su Walter Su added a comment -

          Before you removes the guard, you should change the log to slf4j-style with placeholder, to eliminate String concatenation. That's what the guard used for.

          Show
          walter.k.su Walter Su added a comment - Before you removes the guard, you should change the log to slf4j-style with placeholder, to eliminate String concatenation. That's what the guard used for.
          Hide
          liuml07 Mingliang Liu added a comment -

          We can fix this after moving BlockReader to client module.

          Show
          liuml07 Mingliang Liu added a comment - We can fix this after moving BlockReader to client module.

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development