[HDFS-9347] Invariant assumption in TestQuorumJournalManager.shutdown() is wrong

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 30/Oct/15 17:21
• Updated: 02/Oct/19 17:15
• Resolved: 19/Dec/15 00:07

Description

The code

TestTestQuorumJournalManager.java

@After
  public void shutdown() throws IOException {
    IOUtils.cleanup(LOG, toClose.toArray(new Closeable[0]));
    
    // Should not leak clients between tests -- this can cause flaky tests.
    // (See HDFS-4643)
    GenericTestUtils.assertNoThreadsMatching(".*IPC Client.*");
    
    if (cluster != null) {
      cluster.shutdown();
    }
  }

implicitly assumes when the call returns from IOUtils.cleanup() (which calls close() on QuorumJournalManager object), all IPC client connection threads are terminated. However, there is no internal implementation that enforces this assumption. Even if the bug reported in HADOOP-12532 is fixed, the internal code still only ensures IPC connections are terminated, but not the thread.

Issue Links

• duplicates: HDFS-4925 TestQuorumJournalManager.testPurgeLogs intermittently Fails assertNoThreadsMatching
• is blocked by: HADOOP-12532 Data race in IPC client Client.stop()