Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12532

Data race in IPC client Client.stop()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: ipc
    • Labels:
      None

      Description

      I found a data race in ipc.Client.stop()

      ipc.Client maintains a hash map of connection threads. When stop() is called, it interrupts all connection threads; the threads are supposed to remove itself from the hash map as part of the clean up work; and stop() periodically checks to see if the hash map is empty and then returns.

      The bug is, this checking operation is not synchronized, and the connection thread actually removes itself from the hash map before terminating connections.

      This bug causes regression for HDFS-4925. In fact, the fix in HDFS-4925 may not be correct, because it assumes when it returns from QuorumJournalManager.close(), IPC client connection threads are terminated. But the reality is the IPC code assumes connections are closed, not the IPC connection threads (which in any case is buggy as well).

      This is also likely related to the bug reported in HDFS-4925 (TestQuorumJournalManager.testPurgeLogs intermittently Fails assertNoThreadsMatching)

        Attachments

        1. HADOOP-12532.001.patch
          1 kB
          Wei-Chiu Chuang

          Issue Links

            Activity

              People

              • Assignee:
                jojochuang Wei-Chiu Chuang
                Reporter:
                jojochuang Wei-Chiu Chuang
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: