[HDFS-9304] Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: build
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 25/Oct/15 07:24
• Updated: 30/Aug/16 01:24
• Resolved: 26/Oct/15 19:04

Description

tl;dr Since HdfsClientConfigKeys holds client side config keys, we need to add this class to TestHdfsConfigFields#configurationClasses.

Now the TestHdfsConfigFields unit test passes because DFSConfigKeys still contains all the client side config keys, though marked @deprecated. As we add new client config keys (e.g. HDFS-9259), the unit test will fail with the following error:

hdfs-default.xml has 1 properties missing in class org.apache.hadoop.hdfs.DFSConfigKeys

If the logic is to make the DFSConfigKeys and HdfsClientConfigKeys together cover all config keys in hdfs-default.xml, we need to put both of them in TestHdfsConfigFields#configurationClasses.