Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6200 Create a separate jar for hdfs-client
  3. HDFS-9304

Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      tl;dr Since HdfsClientConfigKeys holds client side config keys, we need to add this class to TestHdfsConfigFields#configurationClasses.

      Now the TestHdfsConfigFields unit test passes because DFSConfigKeys still contains all the client side config keys, though marked @deprecated. As we add new client config keys (e.g. HDFS-9259), the unit test will fail with the following error:

      hdfs-default.xml has 1 properties missing in class org.apache.hadoop.hdfs.DFSConfigKeys

      If the logic is to make the DFSConfigKeys and HdfsClientConfigKeys together cover all config keys in hdfs-default.xml, we need to put both of them in TestHdfsConfigFields#configurationClasses.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 8m 28s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 31s There were no new javac warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 31s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 10s Pre-build of native portion
        -1 hdfs tests 66m 3s Tests failed in hadoop-hdfs.
            90m 53s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768625/HDFS-9304.000.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / ab8eb87
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13187/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13187/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13187/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13187/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 8m 28s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 31s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 31s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 10s Pre-build of native portion -1 hdfs tests 66m 3s Tests failed in hadoop-hdfs.     90m 53s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768625/HDFS-9304.000.patch Optional Tests javac unit findbugs checkstyle git revision trunk / ab8eb87 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13187/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13187/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13187/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13187/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        +1. The failed unit tests are unrelated. Committing it shortly.

        Show
        wheat9 Haohui Mai added a comment - +1. The failed unit tests are unrelated. Committing it shortly.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks to Haohui Mai for your review and commit.

        Show
        liuml07 Mingliang Liu added a comment - Thanks to Haohui Mai for your review and commit.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8709/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8709 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8709/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/587/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/587/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1323 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1323/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1323 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1323/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #599 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/599/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #599 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/599/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2477 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2477/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2477 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2477/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2530 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2530/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2530 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2530/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #540 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/540/)
        HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #540 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/540/ ) HDFS-9304 . Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development