Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6200 Create a separate jar for hdfs-client
  3. HDFS-9304

Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      tl;dr Since HdfsClientConfigKeys holds client side config keys, we need to add this class to TestHdfsConfigFields#configurationClasses.

      Now the TestHdfsConfigFields unit test passes because DFSConfigKeys still contains all the client side config keys, though marked @deprecated. As we add new client config keys (e.g. HDFS-9259), the unit test will fail with the following error:

      hdfs-default.xml has 1 properties missing in class org.apache.hadoop.hdfs.DFSConfigKeys

      If the logic is to make the DFSConfigKeys and HdfsClientConfigKeys together cover all config keys in hdfs-default.xml, we need to put both of them in TestHdfsConfigFields#configurationClasses.

        Attachments

          Activity

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: