Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9217

Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client module

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The findbugsExcludeFile.xml file was broken and the findbugs complains as follows:

      [INFO] ------------------------------------------------------------------------
      [INFO] Building Apache Hadoop HDFS Client 3.0.0-SNAPSHOT
      [INFO] ------------------------------------------------------------------------
      [INFO]
      [INFO] --- findbugs-maven-plugin:3.0.0:findbugs (default-cli) @ hadoop-hdfs-client ---
      [INFO] Fork Value is true
           [java] The following errors occurred during analysis:
           [java]   Unable to read filter: /Users/mliu/Workspace/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/target/findbugsExcludeFile.xml : The value of attribute "name" associated with an element type "Class" must not contain the '<' character.
           [java]     java.io.IOException: The value of attribute "name" associated with an element type "Class" must not contain the '<' character.
           [java]       At edu.umd.cs.findbugs.filter.Filter.<init>(Filter.java:134)
           [java]       At edu.umd.cs.findbugs.FindBugs.configureFilter(FindBugs.java:516)
           [java]       At edu.umd.cs.findbugs.FindBugs2.addFilter(FindBugs2.java:374)
           [java]       At edu.umd.cs.findbugs.FindBugs2.configureFilters(FindBugs2.java:521)
           [java]       At edu.umd.cs.findbugs.FindBugs2.setUserPreferences(FindBugs2.java:475)
           [java]       At edu.umd.cs.findbugs.TextUICommandLine.configureEngine(TextUICommandLine.java:685)
           [java]       At edu.umd.cs.findbugs.FindBugs.processCommandLine(FindBugs.java:361)
           [java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1188)
           [java] Warnings generated: 748
      [INFO] Done FindBugs Analysis....
      

      The reason is that in HDFS-9182, the newly added lines contain “ character, which should be ".

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2412 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2412/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2412 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2412/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/502/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/502/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/474/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/474/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1239 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1239/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1239 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1239/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #511 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/511/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #511 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/511/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2446 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2446/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2446 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2446/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8597 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8597/)
          HDFS-9217. Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7)

          • hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8597 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8597/ ) HDFS-9217 . Fix broken findbugsExcludeFile.xml for hadoop-hdfs-client (aajisaka: rev b4390d5ab87e68789c6c24a8c71f5bb89a3588b7) hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you Akira Ajisaka for reviewing and committing the patch!

          Show
          liuml07 Mingliang Liu added a comment - Thank you Akira Ajisaka for reviewing and committing the patch!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Mingliang Liu for your contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Mingliang Liu for your contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1

          Show
          ajisakaa Akira Ajisaka added a comment - +1
          Hide
          liuml07 Mingliang Liu added a comment -

          The release audit is unrelated.

          Show
          liuml07 Mingliang Liu added a comment - The release audit is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 release audit 0m 14s The applied patch generated 1 release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 17s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765704/HDFS-9217.000.patch
          Optional Tests  
          git revision trunk / 8d22622
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12876/artifact/patchprocess/patchReleaseAuditProblems.txt
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12876/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 release audit 0m 14s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765704/HDFS-9217.000.patch Optional Tests   git revision trunk / 8d22622 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12876/artifact/patchprocess/patchReleaseAuditProblems.txt Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12876/console This message was automatically generated.

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development