Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9013

Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      NameNodeMXBean#getNNStarted() metric is deprecated in branch-2 and removed from trunk.
    1. HDFS-9013.001.patch
      5 kB
      Surendra Singh Lilhore
    2. HDFS-9013.001-branch-2.patch
      3 kB
      Surendra Singh Lilhore
    3. HDFS-9013.002-branch-2.patch
      5 kB
      Surendra Singh Lilhore
    4. HDFS-9013-branch-2.003.patch
      5 kB
      Surendra Singh Lilhore
    5. HDFS-9013-branch-2.004.patch
      5 kB
      Surendra Singh Lilhore

      Activity

      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk #2345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2345/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2345/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/407/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/407/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk #2372 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2372/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2372 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2372/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk #1166 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1166/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1166 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1166/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #426 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/426/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #426 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/426/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #434 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/434/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #434 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/434/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #8502 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8502/)
      HDFS-9013. Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d)

      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
      • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8502 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8502/ ) HDFS-9013 . Deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev a2c76e5f26301d4b01e56b347442f3dec171591d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
      Hide
      vinayrpet Vinayakumar B added a comment -

      Committed to trunk and branch-2.
      Thanks Surendra Singh Lilhore for the contribution.
      Thanks Haohui Mai and Akira Ajisaka for initial suggestion.

      Show
      vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution. Thanks Haohui Mai and Akira Ajisaka for initial suggestion.
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      -1 pre-patch 23m 29s Pre-patch branch-2 has 5 extant Findbugs (version 3.0.0) warnings.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
      +1 javac 6m 9s There were no new javac warning messages.
      +1 javadoc 9m 56s There were no new javadoc warning messages.
      +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
      +1 site 3m 6s Site still builds.
      -1 checkstyle 2m 29s The applied patch generated 1 new checkstyle issues (total was 304, now 304).
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 install 1m 11s mvn install still works.
      +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
      +1 findbugs 4m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      +1 common tests 22m 37s Tests passed in hadoop-common.
      -1 hdfs tests 174m 30s Tests failed in hadoop-hdfs.
          248m 49s  



      Reason Tests
      Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
        hadoop.hdfs.TestDistributedFileSystem



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12761659/HDFS-9013-branch-2.004.patch
      Optional Tests site javadoc javac unit findbugs checkstyle
      git revision branch-2 / 96e3fbf
      Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/branch-2FindbugsWarningshadoop-common.html
      checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/testrun_hadoop-hdfs.txt
      Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12597/testReport/
      Java 1.7.0_55
      uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12597/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 23m 29s Pre-patch branch-2 has 5 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 6m 9s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 6s Site still builds. -1 checkstyle 2m 29s The applied patch generated 1 new checkstyle issues (total was 304, now 304). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 11s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 37s Tests passed in hadoop-common. -1 hdfs tests 174m 30s Tests failed in hadoop-hdfs.     248m 49s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761659/HDFS-9013-branch-2.004.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision branch-2 / 96e3fbf Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/branch-2FindbugsWarningshadoop-common.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12597/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12597/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12597/console This message was automatically generated.
      Hide
      surendrasingh Surendra Singh Lilhore added a comment -

      Thanks Vinayakumar B for review..
      Fixed checkstyle comment.
      Attached updated patch, please review..

      Show
      surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review.. Fixed checkstyle comment. Attached updated patch, please review..
      Hide
      vinayrpet Vinayakumar B added a comment -

      @link org.apache.hadoop.hdfs.server.namenode.NameNodeMXBean#getNNStartedTimeInMillis() instead.
      I think this is the checkstyle comment you got, this link can be updated with just #getNNStartedTimeInMillis().

      Test failures seems unrelated.

      +1 once addressed.

      Show
      vinayrpet Vinayakumar B added a comment - @link org.apache.hadoop.hdfs.server.namenode.NameNodeMXBean#getNNStartedTimeInMillis() instead. I think this is the checkstyle comment you got, this link can be updated with just #getNNStartedTimeInMillis() . Test failures seems unrelated. +1 once addressed.
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      -1 pre-patch 24m 8s Pre-patch branch-2 has 5 extant Findbugs (version 3.0.0) warnings.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
      +1 javac 6m 15s There were no new javac warning messages.
      +1 javadoc 10m 14s There were no new javadoc warning messages.
      +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
      +1 site 3m 14s Site still builds.
      -1 checkstyle 2m 34s The applied patch generated 2 new checkstyle issues (total was 304, now 305).
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 install 1m 17s mvn install still works.
      +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
      +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      -1 common tests 23m 12s Tests failed in hadoop-common.
      -1 hdfs tests 188m 59s Tests failed in hadoop-hdfs.
          265m 23s  



      Reason Tests
      Failed unit tests hadoop.ha.TestZKFailoverController
        hadoop.hdfs.TestDistributedFileSystem



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12761579/HDFS-9013-branch-2.003.patch
      Optional Tests site javadoc javac unit findbugs checkstyle
      git revision branch-2 / 52cc2ca
      Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/branch-2FindbugsWarningshadoop-common.html
      checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/testrun_hadoop-hdfs.txt
      Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12583/testReport/
      Java 1.7.0_55
      uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12583/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 24m 8s Pre-patch branch-2 has 5 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 6m 15s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 14s Site still builds. -1 checkstyle 2m 34s The applied patch generated 2 new checkstyle issues (total was 304, now 305). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 17s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 23m 12s Tests failed in hadoop-common. -1 hdfs tests 188m 59s Tests failed in hadoop-hdfs.     265m 23s   Reason Tests Failed unit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761579/HDFS-9013-branch-2.003.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision branch-2 / 52cc2ca Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/branch-2FindbugsWarningshadoop-common.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12583/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12583/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12583/console This message was automatically generated.
      Hide
      surendrasingh Surendra Singh Lilhore added a comment -

      Changed patch name, so it will apply on branch-2

      Show
      surendrasingh Surendra Singh Lilhore added a comment - Changed patch name, so it will apply on branch-2
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      -1 patch 0m 0s The patch command could not apply the patch during dryrun.



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12761268/HDFS-9013.003-branch-2.patch
      Optional Tests site javadoc javac unit findbugs checkstyle
      git revision trunk / e3ace31
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12556/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761268/HDFS-9013.003-branch-2.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision trunk / e3ace31 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12556/console This message was automatically generated.
      Hide
      surendrasingh Surendra Singh Lilhore added a comment -

      Testing HDFS-9013 patch on trunk.
      Checking patch hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md...

      looks like branch-2 patch applied on trunk..

      Show
      surendrasingh Surendra Singh Lilhore added a comment - Testing HDFS-9013 patch on trunk. Checking patch hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md... looks like branch-2 patch applied on trunk..
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      -1 patch 0m 0s The patch command could not apply the patch during dryrun.



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12755555/HDFS-9013.002-branch-2.patch
      Optional Tests site javadoc javac unit findbugs checkstyle
      git revision trunk / d845547
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12414/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755555/HDFS-9013.002-branch-2.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision trunk / d845547 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12414/console This message was automatically generated.
      Hide
      surendrasingh Surendra Singh Lilhore added a comment -

      Thanks Vinayakumar B for review.
      Attached updated patch for branch 2..

      Show
      surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review. Attached updated patch for branch 2..
      Hide
      vinayrpet Vinayakumar B added a comment -

      in branch-2 patch,
      1. All the references made in tests can be updated same as trunk patch.
      2. Document should be updated to indicate deprecation and should suggest alternative

      Show
      vinayrpet Vinayakumar B added a comment - in branch-2 patch, 1. All the references made in tests can be updated same as trunk patch. 2. Document should be updated to indicate deprecation and should suggest alternative
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 17m 49s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
      +1 javac 7m 55s There were no new javac warning messages.
      +1 javadoc 10m 11s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 302, now 302).
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 install 1m 28s mvn install still works.
      +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
      +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      +1 native 3m 12s Pre-build of native portion
      -1 hdfs tests 160m 10s Tests failed in hadoop-hdfs.
          205m 32s  



      Reason Tests
      Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12753971/HDFS-9013.001-branch-2.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / b469ac5
      checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12276/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
      hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12276/artifact/patchprocess/testrun_hadoop-hdfs.txt
      Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12276/testReport/
      Java 1.7.0_55
      uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12276/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 302, now 302). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 160m 10s Tests failed in hadoop-hdfs.     205m 32s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753971/HDFS-9013.001-branch-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b469ac5 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12276/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12276/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12276/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12276/console This message was automatically generated.
      Hide
      surendrasingh Surendra Singh Lilhore added a comment -

      Attached patch for trunk and branch-2.

      Please review..

      Show
      surendrasingh Surendra Singh Lilhore added a comment - Attached patch for trunk and branch-2. Please review..

        People

        • Assignee:
          surendrasingh Surendra Singh Lilhore
          Reporter:
          surendrasingh Surendra Singh Lilhore
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development