Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8388

Time and Date format need to be in sync in NameNode UI page

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In NameNode UI Page, Date and Time FORMAT displayed on the page are not in sync currently.

      Started:Wed May 13 12:28:02 IST 2015

      Compiled:23 Apr 2015 12:22:59

      Block Deletion Start Time 13 May 2015 12:28:02

      We can keep a common format in all the above places.

      1. HDFS-8388-006.patch
        8 kB
        Surendra Singh Lilhore
      2. HDFS-8388-005.patch
        8 kB
        Surendra Singh Lilhore
      3. HDFS-8388-004.patch
        4 kB
        Surendra Singh Lilhore
      4. HDFS-8388-003.patch
        4 kB
        Surendra Singh Lilhore
      5. ScreenShot-InvalidDate.png
        53 kB
        Akira Ajisaka
      6. HDFS-8388-002.patch
        106 kB
        Surendra Singh Lilhore
      7. HDFS-8388_1.patch
        105 kB
        Surendra Singh Lilhore
      8. HDFS-8388.patch
        7 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Created new Jira HDFS-9013 to deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Created new Jira HDFS-9013 to deprecate NameNodeMXBean#getNNStarted in branch2 and remove from trunk
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B and Haohui Mai for the reviews. Thanks Akira Ajisaka for review and commit ..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B and Haohui Mai for the reviews. Thanks Akira Ajisaka for review and commit ..
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #324 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/324/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #324 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/324/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2263/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2263/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1068 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1068/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1068 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1068/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2282 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2282/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2282 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2282/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #341 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/341/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #341 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/341/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #333 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/333/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #333 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/333/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8385 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8385/)
          HDFS-8388. Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8385 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8385/ ) HDFS-8388 . Time and Date format need to be in sync in NameNode UI page. Contributed by Surendra Singh Lilhore. (aajisaka: rev 65ccf2b1252a5c83755fa24a93cf1d30ee59b2c3) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution, and thanks Vinayakumar B and Haohui Mai for the review.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution, and thanks Vinayakumar B and Haohui Mai for the review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the failed tests are not related to the patch. I ran the tests locally and all of them passed.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the failed tests are not related to the patch. I ran the tests locally and all of them passed.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          It’s better to handle this in HADOOP-7088. Is it ok ?

          I'm okay to do the followings in separate jiras.

          • Deprecate NameNodeMXBean#getNNStarted
          • Remove NameNodeMXBean#getNNStarted from trunk
          • HADOOP-7088
          • Deprecate NameNodeMXBean#getCompileInfo
          • Remove NameNodeMXBean#getCompileInfo from trunk
          Show
          ajisakaa Akira Ajisaka added a comment - It’s better to handle this in HADOOP-7088 . Is it ok ? I'm okay to do the followings in separate jiras. Deprecate NameNodeMXBean#getNNStarted Remove NameNodeMXBean#getNNStarted from trunk HADOOP-7088 Deprecate NameNodeMXBean#getCompileInfo Remove NameNodeMXBean#getCompileInfo from trunk
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B and Haohui Mai for reviews.

          Currently CompileInfo metric contain three values.
          1. Compile time.
          2. User
          3. Branch

          Here we need to create three new metrics. It’s better to handle this in HADOOP-7088.
          Is it ok ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B and Haohui Mai for reviews. Currently CompileInfo metric contain three values. 1. Compile time. 2. User 3. Branch Here we need to create three new metrics. It’s better to handle this in HADOOP-7088 . Is it ok ?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 22m 34s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 0s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 3s Site still builds.
          -1 checkstyle 2m 30s The applied patch generated 1 new checkstyle issues (total was 303, now 303).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 32s Tests passed in hadoop-common.
          -1 hdfs tests 161m 1s Tests failed in hadoop-hdfs.
              236m 20s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
            hadoop.hdfs.TestPread
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.server.blockmanagement.TestAvailableSpaceBlockPlacementPolicy



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751980/HDFS-8388-006.patch
          Optional Tests site javadoc javac unit findbugs checkstyle
          git revision trunk / feaf034
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12089/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12089/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 22m 34s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 3s Site still builds. -1 checkstyle 2m 30s The applied patch generated 1 new checkstyle issues (total was 303, now 303). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 32s Tests passed in hadoop-common. -1 hdfs tests 161m 1s Tests failed in hadoop-hdfs.     236m 20s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup   hadoop.hdfs.TestPread   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.server.blockmanagement.TestAvailableSpaceBlockPlacementPolicy Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751980/HDFS-8388-006.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision trunk / feaf034 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12089/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12089/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12089/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          I think if we're going down to the route of adding new JMX to make things cleaner, then it might make sense to change the compile string to return a timestamp as well.

          And it would be nice to remove all these deprecated metrics in trunk.

          Show
          wheat9 Haohui Mai added a comment - I think if we're going down to the route of adding new JMX to make things cleaner, then it might make sense to change the compile string to return a timestamp as well. And it would be nice to remove all these deprecated metrics in trunk.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks for the update Surendra Singh Lilhore.

          These two checkstyles is applicable for all the API available in NameNodeMXBean interface. Do we need to fix these ??

          As for as this Jira is concerned, latest update is fine. Though you can raise a follow-up and address in that Jira. ex: HDFS-8620 fixed such issues for ClientProtocol

          +1, Changes looks good to me.
          pending jenkins for one final report.

          Akira Ajisaka and Haohui Mai, do you you also want to take a look?

          Show
          vinayrpet Vinayakumar B added a comment - Thanks for the update Surendra Singh Lilhore . These two checkstyles is applicable for all the API available in NameNodeMXBean interface. Do we need to fix these ?? As for as this Jira is concerned, latest update is fine. Though you can raise a follow-up and address in that Jira. ex: HDFS-8620 fixed such issues for ClientProtocol +1, Changes looks good to me. pending jenkins for one final report. Akira Ajisaka and Haohui Mai , do you you also want to take a look?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B for review.

          Attached updated patch , Please review..

          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:226:3: Redundant 'public' modifier.

          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:228: First sentence should end with a period.

          These two checkstyles is applicable for all the API available in NameNodeMXBean interface. Do we need to fix these ??

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review. Attached updated patch , Please review.. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:226:3: Redundant 'public' modifier. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java:228: First sentence should end with a period. These two checkstyles is applicable for all the API available in NameNodeMXBean interface. Do we need to fix these ??
          Hide
          vinayrpet Vinayakumar B added a comment -

          1.

               var HELPERS = {
                 'helper_date_tostring' : function (chunk, ctx, bodies, params) {
                   var value = dust.helpers.tap(params.value, chunk, ctx);
          -        return chunk.write('' + new Date(Number(value)).toLocaleString());
          +        return chunk.write('' + moment(Number(v)).format('ddd MMM DD HH:mm:ss ZZ YYYY'));
                 }
               };

          Here, Number(v), there is no v. You need to replace with value.

          2. Need to fix 2 checkstyles out of 3 shown
          3. You can clean lines with whitespace endings, though this can be done during commit.

          In addition to the above changes, just remove duplicate line in dfshealth.html. Its not from this issue, but i think that also can go along with this patch.
          </script><script type="text/javascript" src="/static/moment.min.js">

          Show
          vinayrpet Vinayakumar B added a comment - 1. var HELPERS = { 'helper_date_tostring' : function (chunk, ctx, bodies, params) { var value = dust.helpers.tap(params.value, chunk, ctx); - return chunk.write('' + new Date( Number (value)).toLocaleString()); + return chunk.write('' + moment( Number (v)).format('ddd MMM DD HH:mm:ss ZZ YYYY')); } }; Here, Number(v) , there is no v . You need to replace with value . 2. Need to fix 2 checkstyles out of 3 shown 3. You can clean lines with whitespace endings, though this can be done during commit. In addition to the above changes, just remove duplicate line in dfshealth.html . Its not from this issue, but i think that also can go along with this patch. </script><script type="text/javascript" src="/static/moment.min.js">
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 22m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 56s There were no new javac warning messages.
          +1 javadoc 9m 48s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 1s Site still builds.
          -1 checkstyle 2m 31s The applied patch generated 3 new checkstyle issues (total was 303, now 305).
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
          +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 21s Tests passed in hadoop-common.
          -1 hdfs tests 177m 7s Tests failed in hadoop-hdfs.
              252m 29s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.TestPread



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751718/HDFS-8388-005.patch
          Optional Tests site javadoc javac unit findbugs checkstyle
          git revision trunk / 22de7c1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12072/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12072/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 56s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. -1 checkstyle 2m 31s The applied patch generated 3 new checkstyle issues (total was 303, now 305). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 21s Tests passed in hadoop-common. -1 hdfs tests 177m 7s Tests failed in hadoop-hdfs.     252m 29s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestPread Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751718/HDFS-8388-005.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision trunk / 22de7c1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12072/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12072/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12072/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached updated patch, Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached updated patch, Please review...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B for review

          I feel, if we are unifying, then unify everywhere. agree?

          yes

          I will update the patch.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review I feel, if we are unifying, then unify everywhere. agree? yes I will update the patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Patch looks great.

          I feel there are some other places in NameNode UI where this unification could be done.
          ex: Datanode last contact time, file last modification time, datanode volume failure time, etc.

          I feel, if we are unifying, then unify everywhere.
          agree?

          Show
          vinayrpet Vinayakumar B added a comment - Patch looks great. I feel there are some other places in NameNode UI where this unification could be done. ex: Datanode last contact time, file last modification time, datanode volume failure time, etc. I feel, if we are unifying, then unify everywhere. agree?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review
          Attached new patch , Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review Attached new patch , Please review...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          yes, I will do this and update the patch here soon..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - yes, I will do this and update the patch here soon..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I didn't see any document for NNStarted, so I didn't added for new metric.

          I'm thinking NNStarted should be documented as well. Would you document both NNStarted and the new metric?

          Show
          ajisakaa Akira Ajisaka added a comment - I didn't see any document for NNStarted, so I didn't added for new metric. I'm thinking NNStarted should be documented as well. Would you document both NNStarted and the new metric?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for comments..
          I didn't see any document for NNStarted, so I didn't added for new metric.
          http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Metrics.html

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for comments.. I didn't see any document for NNStarted , so I didn't added for new metric. http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Metrics.html
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm thinking moment-timezone.js can parse the format by using user.timezone property via JMX, however, it needs a lot of work. I prefer adding a new metric rather than parsing the date. Please correct me if I am wrong.

          By the way, v3 patch needs documentation for the new metric.

          Show
          ajisakaa Akira Ajisaka added a comment - I'm thinking moment-timezone.js can parse the format by using user.timezone property via JMX, however, it needs a lot of work. I prefer adding a new metric rather than parsing the date. Please correct me if I am wrong. By the way, v3 patch needs documentation for the new metric.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Is it possible to use moment.js to parse the date instead?

          No, moment.js cannot parse zz format. I'll check whether moment-timezone.js can parse zz. If it can parse the timezone, we can use it instead of adding a new metric.

          Show
          ajisakaa Akira Ajisaka added a comment - Is it possible to use moment.js to parse the date instead? No, moment.js cannot parse zz format. I'll check whether moment-timezone.js can parse zz . If it can parse the timezone, we can use it instead of adding a new metric.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Haohui Mai for review...

          I tried to parse NNstart date in 002 patch using moment.js , but some time it is giving "invalid date" message...

          Please check attached image "ScreenShot-InvalidDate.png".

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Haohui Mai for review... I tried to parse NNstart date in 002 patch using moment.js , but some time it is giving "invalid date" message... Please check attached image "ScreenShot-InvalidDate.png".
          Hide
          wheat9 Haohui Mai added a comment -

          I wonder why you need to change the JMX? Is it possible to use moment.js to parse the date instead?

          Show
          wheat9 Haohui Mai added a comment - I wonder why you need to change the JMX? Is it possible to use moment.js to parse the date instead?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 53s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 27s The applied patch generated 3 new checkstyle issues (total was 305, now 307).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 2s Pre-build of native portion
          -1 hdfs tests 176m 31s Tests failed in hadoop-hdfs.
              221m 0s  



          Reason Tests
          Timed out tests org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12749600/HDFS-8388-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8f73bdd
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11952/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11952/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 27s The applied patch generated 3 new checkstyle issues (total was 305, now 307). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 2s Pre-build of native portion -1 hdfs tests 176m 31s Tests failed in hadoop-hdfs.     221m 0s   Reason Tests Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749600/HDFS-8388-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8f73bdd checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11952/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11952/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11952/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for suggestions
          Attached new patch, Please review....

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for suggestions Attached new patch, Please review....
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Surendra Singh Lilhore for the comment. I'm thinking we should convert the started time to ZZ (ex. +0530) to be sync. Javascript does not support timezone correctly and that's why moment.js "zz" format support is deprecated.
          We cannot change the format of NNStarted metric for keeping compatibility, so we need to create a new metric such as NNStartedTimeInMillis and parse it by moment.js.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Surendra Singh Lilhore for the comment. I'm thinking we should convert the started time to ZZ (ex. +0530) to be sync. Javascript does not support timezone correctly and that's why moment.js "zz" format support is deprecated. We cannot change the format of NNStarted metric for keeping compatibility, so we need to create a new metric such as NNStartedTimeInMillis and parse it by moment.js.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review..

          2. Would you use "ddd MMM DD HH:mm:ss ZZ YYYY" format instead of "ddd MMM DD HH:mm:ss YYYY" to be consistent with YARN Web UI?

          If I use "ddd MMM DD HH:mm:ss ZZ YYYY" format then "Block Deletion Start Time" and "Compiled" time is coming like this

          Compiled:	Mon Jul 06 12:20:00 +0530 2015 by sslilhore from trunk
          Block Deletion Start Time:	Thu Jul 30 14:31:30 +0530 2015
          

          and Started time is like this

          Started:	Thu Jul 30 17:01:30 CST 2015
          

          here Compiled time zone is "+0530" but Started time zone is "CST".

          is this ok ??

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review.. 2. Would you use "ddd MMM DD HH:mm:ss ZZ YYYY" format instead of "ddd MMM DD HH:mm:ss YYYY" to be consistent with YARN Web UI? If I use "ddd MMM DD HH:mm:ss ZZ YYYY" format then "Block Deletion Start Time" and "Compiled" time is coming like this Compiled: Mon Jul 06 12:20:00 +0530 2015 by sslilhore from trunk Block Deletion Start Time: Thu Jul 30 14:31:30 +0530 2015 and Started time is like this Started: Thu Jul 30 17:01:30 CST 2015 here Compiled time zone is "+0530" but Started time zone is "CST". is this ok ??
          Hide
          ajisakaa Akira Ajisaka added a comment -

          1. Started time looks invalid. Would you fix it?

          Started time is already rendered by Date.toString(), so I'm thinking we don't need to re-format by moment.js.

          I have an additional comment: Would you use moment.min.js instead of moment.js to minimize the source code as HDFS-8816?

          Show
          ajisakaa Akira Ajisaka added a comment - 1. Started time looks invalid. Would you fix it? Started time is already rendered by Date.toString(), so I'm thinking we don't need to re-format by moment.js. I have an additional comment: Would you use moment.min.js instead of moment.js to minimize the source code as HDFS-8816 ?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a screenshot.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a screenshot.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Surendra Singh Lilhore for updating the patch. Two comments from me.
          1. Started time looks invalid. Would you fix it?
          2. Would you use "ddd MMM DD HH:mm:ss ZZ YYYY" format instead of "ddd MMM DD HH:mm:ss YYYY" to be consistent with YARN Web UI?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Surendra Singh Lilhore for updating the patch. Two comments from me. 1. Started time looks invalid. Would you fix it? 2. Would you use "ddd MMM DD HH:mm:ss ZZ YYYY" format instead of "ddd MMM DD HH:mm:ss YYYY" to be consistent with YARN Web UI?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 54s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 native 3m 5s Pre-build of native portion
          +1 hdfs tests 160m 53s Tests passed in hadoop-hdfs.
              198m 34s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744632/HDFS-8388-002.patch
          Optional Tests javadoc javac unit
          git revision trunk / 1a0752d
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11652/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11652/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11652/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 native 3m 5s Pre-build of native portion +1 hdfs tests 160m 53s Tests passed in hadoop-hdfs.     198m 34s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744632/HDFS-8388-002.patch Optional Tests javadoc javac unit git revision trunk / 1a0752d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11652/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11652/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11652/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for reviewing...

          Attached updated patch.. Please review.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for reviewing... Attached updated patch.. Please review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          One comment from me.

          The applied patch generated 1 release audit warnings.

          We need to add a line to the pom.xml not to check moment.js.

          hadoop-hdfs-project/hadoop-hdfs/pom.xml
                <plugin>
                  <groupId>org.apache.rat</groupId>
                  <artifactId>apache-rat-plugin</artifactId>
                  <configuration>
                    <excludes>
                      <exclude>CHANGES.txt</exclude>
                      ...
          
          Show
          ajisakaa Akira Ajisaka added a comment - One comment from me. The applied patch generated 1 release audit warnings. We need to add a line to the pom.xml not to check moment.js. hadoop-hdfs-project/hadoop-hdfs/pom.xml <plugin> <groupId>org.apache.rat</groupId> <artifactId>apache-rat-plugin</artifactId> <configuration> <excludes> <exclude>CHANGES.txt</exclude> ...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Akira Ajisaka and Haohui Mai , Would you please review ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Akira Ajisaka and Haohui Mai , Would you please review ?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 21s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12739584/HDFS-8388_1.patch
          Optional Tests  
          git revision trunk / 4c5da9b
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/11356/artifact/patchprocess/patchReleaseAuditProblems.txt
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11356/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739584/HDFS-8388_1.patch Optional Tests   git revision trunk / 4c5da9b Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/11356/artifact/patchprocess/patchReleaseAuditProblems.txt Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11356/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka and Haohui Mai for suggestion.

          I attached new patch, Please review...

          Now this patch will format date in local time zone and display like this:

          Started:	                Tue Jun 16 04:53:21 2015
          Compiled:	                Tue Jun 02 12:40:00 2015 by xyz from Unknown
          Block Deletion Start Time	Mon Jun 15 14:53:21 2015
          
          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka and Haohui Mai for suggestion. I attached new patch, Please review... Now this patch will format date in local time zone and display like this: Started: Tue Jun 16 04:53:21 2015 Compiled: Tue Jun 02 12:40:00 2015 by xyz from Unknown Block Deletion Start Time Mon Jun 15 14:53:21 2015
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Haohui Mai. Using dedicated library like moment.js seems better than implementing it.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Haohui Mai . Using dedicated library like moment.js seems better than implementing it.
          Hide
          wheat9 Haohui Mai added a comment -

          The formatting should be fully done in the client side instead of server side due to complications such as locale and DST. A robust solution should use dedicated library like moment.hs

          Show
          wheat9 Haohui Mai added a comment - The formatting should be fully done in the client side instead of server side due to complications such as locale and DST. A robust solution should use dedicated library like moment.hs
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Surendra Singh Lilhore for taking this issue.

             @Override
          -  public long getBlockDeletionStartTime() {
          -    return startTime + blockManager.getStartupDelayBlockDeletionInMs();
          +  public String getBlockDeletionStartTime() {
          +    return Time.DATEFORMAT.get().format(
          +        new Date(startTime + blockManager.getStartupDelayBlockDeletionInMs()));
             }
          
             @Override  // NameNodeMXBean
             public String getNNStarted() {
          -    return getStartTime().toString();
          +    return Time.DATEFORMAT.get().format(new Date(startTime));
             }
          

          I'm thinking changing the return value of these method is incompatible because the method is used for metrics and JMX. http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-common/Compatibility.html#MetricsJMX
          Would you fix the formatting in helper_date_tostring of dfshealth.js? I've implemented similar function in YARN WebUI by YARN-570, so you can re-use the code.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Surendra Singh Lilhore for taking this issue. @Override - public long getBlockDeletionStartTime() { - return startTime + blockManager.getStartupDelayBlockDeletionInMs(); + public String getBlockDeletionStartTime() { + return Time.DATEFORMAT.get().format( + new Date(startTime + blockManager.getStartupDelayBlockDeletionInMs())); } @Override // NameNodeMXBean public String getNNStarted() { - return getStartTime().toString(); + return Time.DATEFORMAT.get().format( new Date(startTime)); } I'm thinking changing the return value of these method is incompatible because the method is used for metrics and JMX. http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-common/Compatibility.html#MetricsJMX Would you fix the formatting in helper_date_tostring of dfshealth.js ? I've implemented similar function in YARN WebUI by YARN-570 , so you can re-use the code.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 23s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 22s The applied patch generated 2 new checkstyle issues (total was 2, now 4).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 5m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 43s Tests passed in hadoop-common.
          +1 maven tests 0m 13s Tests passed in hadoop-maven-plugins.
          +1 hdfs tests 164m 34s Tests passed in hadoop-hdfs.
              237m 55s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735549/HDFS-8388.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e830207
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-maven-plugins test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-maven-plugins.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11229/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11229/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 22s The applied patch generated 2 new checkstyle issues (total was 2, now 4). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 5m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 43s Tests passed in hadoop-common. +1 maven tests 0m 13s Tests passed in hadoop-maven-plugins. +1 hdfs tests 164m 34s Tests passed in hadoop-hdfs.     237m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735549/HDFS-8388.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e830207 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-common.txt hadoop-maven-plugins test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-maven-plugins.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11229/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11229/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11229/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached patch , Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached patch , Please review...

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              archanat Archana T
            • Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development