Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9009

Send metrics logs to NullAppender by default

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: logging
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Disable the metrics logger by default by directing logs to the NullAppender.

      1. HDFS-9009.02.patch
        0.8 kB
        Arpit Agarwal
      2. HDFS-9009.01.patch
        0.8 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2269/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2269/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #331 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/331/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #331 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/331/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2290 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2290/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2290 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2290/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1079 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1079/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1079 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1079/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #342 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/342/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #342 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/342/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #348 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/348/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #348 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/348/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8398/)
          HDFS-9009. Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94)

          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8398/ ) HDFS-9009 . Send metrics logs to NullAppender by default. (Arpit Agarwal) (arp: rev 524ba8708b8e3e17e806748e1f819dec2183bf94) hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the reviews Xiaoyu Yao. Committed for 2.8.0.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the reviews Xiaoyu Yao . Committed for 2.8.0.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 47s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 52s There were no new javac warning messages.
          +1 javadoc 10m 3s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 common tests 23m 10s Tests passed in hadoop-common.
              59m 20s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753872/HDFS-9009.02.patch
          Optional Tests javadoc javac unit
          git revision trunk / d31a41c
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12261/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12261/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12261/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 52s There were no new javac warning messages. +1 javadoc 10m 3s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 common tests 23m 10s Tests passed in hadoop-common.     59m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753872/HDFS-9009.02.patch Optional Tests javadoc javac unit git revision trunk / d31a41c hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12261/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12261/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12261/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 10m 5s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 common tests 23m 11s Tests passed in hadoop-common.
              59m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753863/HDFS-9009.01.patch
          Optional Tests javadoc javac unit
          git revision trunk / de928d5
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12260/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12260/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12260/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 5s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 23m 11s Tests passed in hadoop-common.     59m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753863/HDFS-9009.01.patch Optional Tests javadoc javac unit git revision trunk / de928d5 hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12260/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12260/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12260/console This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          +1 for v2 patch, pending Jenkins.

          Show
          xyao Xiaoyu Yao added a comment - +1 for v2 patch, pending Jenkins.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thankx Xiaoyu Yao. v2 patch restores the level to INFO.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thankx Xiaoyu Yao . v2 patch restores the level to INFO.
          Hide
          xyao Xiaoyu Yao added a comment -

          Patch LGTM. One question: Do we need to change the level from INFO to DEBUG in log4j.properties? From namenode MetricsLoggerTask, it seems all the metrics logs are written at INFO level.

          Show
          xyao Xiaoyu Yao added a comment - Patch LGTM. One question: Do we need to change the level from INFO to DEBUG in log4j.properties? From namenode MetricsLoggerTask, it seems all the metrics logs are written at INFO level.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development