Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-8880 added metrics logging at NameNode. Similarly, this JIRA is to add a separate logger for metrics at DN

      1. HDFS-8953-01.patch
        32 kB
        Kanaka Kumar Avvaru
      2. HDFS-8953-02.patch
        32 kB
        Kanaka Kumar Avvaru
      3. HDFS-8953-03.patch
        32 kB
        Kanaka Kumar Avvaru
      4. HDFS-8953-04.patch
        44 kB
        Kanaka Kumar Avvaru
      5. HDFS-8953-05.patch
        36 kB
        Kanaka Kumar Avvaru
      6. HDFS-8953-06.patch
        36 kB
        Kanaka Kumar Avvaru

        Issue Links

          Activity

          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Attached initial patch to add Metrics logs to DataNode which is logged to NullAppender by default.
          Arpit Agarwal, can you have a look at patch as I had to refactor MetricsLoggerTask added in HDFS-8880 and changed the test log4j configuration to use NullAppender by default for NN metric logs also. Is it fine or I can handle this in seperate JIRA if you suggest so.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Attached initial patch to add Metrics logs to DataNode which is logged to NullAppender by default. Arpit Agarwal , can you have a look at patch as I had to refactor MetricsLoggerTask added in HDFS-8880 and changed the test log4j configuration to use NullAppender by default for NN metric logs also. Is it fine or I can handle this in seperate JIRA if you suggest so.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 23s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 javadoc 10m 10s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 29s The applied patch generated 10 new checkstyle issues (total was 719, now 724).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 6s Tests passed in hadoop-common.
          -1 hdfs tests 162m 41s Tests failed in hadoop-hdfs.
              232m 36s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
            hadoop.hdfs.web.TestWebHDFSOAuth2
            hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754493/HDFS-8953-01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1dbd8e3
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12331/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12331/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 10s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 29s The applied patch generated 10 new checkstyle issues (total was 719, now 724). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 6s Tests passed in hadoop-common. -1 hdfs tests 162m 41s Tests failed in hadoop-hdfs.     232m 36s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger   hadoop.hdfs.web.TestWebHDFSOAuth2   hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754493/HDFS-8953-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1dbd8e3 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12331/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12331/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12331/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Setting NullAppender in test log4j.properties caused the test case failure. So changed patch to use actual appender.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Setting NullAppender in test log4j.properties caused the test case failure. So changed patch to use actual appender.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 22m 56s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 9m 27s There were no new javac warning messages.
          +1 javadoc 9m 57s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 52s The applied patch generated 3 new checkstyle issues (total was 719, now 717).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 54s Tests passed in hadoop-common.
          -1 hdfs tests 188m 45s Tests failed in hadoop-hdfs.
              264m 58s  



          Reason Tests
          Failed unit tests hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.server.blockmanagement.TestNodeCount



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754584/HDFS-8953-02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6f72f1e
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12336/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12336/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 56s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 9m 27s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 52s The applied patch generated 3 new checkstyle issues (total was 719, now 717). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 54s Tests passed in hadoop-common. -1 hdfs tests 188m 45s Tests failed in hadoop-hdfs.     264m 58s   Reason Tests Failed unit tests hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754584/HDFS-8953-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6f72f1e checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12336/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12336/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12336/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          test failures doesn't seem to be related to this patch changes.
          MetricsLoggerTask.java:41: First sentence should end with a period- check style issue and whitespace issue I will fix along with comments on patch from reviewers.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - test failures doesn't seem to be related to this patch changes. MetricsLoggerTask.java:41: First sentence should end with a period - check style issue and whitespace issue I will fix along with comments on patch from reviewers.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Kanaka Kumar Avvaru for the effort.

          Here are some comments on the patch.

          1. datanode.metrics.logger=INFO,NullAppender, I think default we can set to enable metrics logs as done for nnmetrics. I feel both should be in sync in defualt behaviour. If NullAppender is used, same is preferred for nnmetrics too.

          2. I see no trim() happens for dn-metrics but done for NN. Any particular reason for this?

          3. public ScheduledThreadPoolExecutor getMetricsLoggerTimer(), I think default accessor is enough. No need of public. agree?

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Kanaka Kumar Avvaru for the effort. Here are some comments on the patch. 1. datanode.metrics.logger=INFO,NullAppender , I think default we can set to enable metrics logs as done for nnmetrics. I feel both should be in sync in defualt behaviour. If NullAppender is used, same is preferred for nnmetrics too. 2. I see no trim() happens for dn-metrics but done for NN. Any particular reason for this? 3. public ScheduledThreadPoolExecutor getMetricsLoggerTimer() , I think default accessor is enough. No need of public. agree?
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Thanks for the review Vinayakumar B.

          1. After HDFS-9009, NN metrics are also configured to NullAppender by default. So, we can keep as it is.
          2. Yes, some of the attribute values like VolumeInfo are long. So, I avoided trim in DN metrics log.
          3. Thanks for pointing, I have removed the public accessor in latest patch.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Thanks for the review Vinayakumar B . 1. After HDFS-9009 , NN metrics are also configured to NullAppender by default. So, we can keep as it is. 2. Yes, some of the attribute values like VolumeInfo are long. So, I avoided trim in DN metrics log. 3. Thanks for pointing, I have removed the public accessor in latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 44s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 57s There were no new javac warning messages.
          +1 javadoc 10m 9s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 38s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 56s Tests passed in hadoop-common.
          -1 hdfs tests 176m 58s Tests failed in hadoop-hdfs.
              244m 25s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestBackupNode



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754958/HDFS-8953-03.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0f0e897
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12359/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12359/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12359/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12359/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 44s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 38s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 56s Tests passed in hadoop-common. -1 hdfs tests 176m 58s Tests failed in hadoop-hdfs.     244m 25s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.ha.TestHASafeMode Timed out tests org.apache.hadoop.hdfs.server.namenode.TestBackupNode Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754958/HDFS-8953-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0f0e897 hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12359/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12359/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12359/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12359/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Test failures in the build doesn't seem to be related to the patch changes

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Test failures in the build doesn't seem to be related to the patch changes
          Hide
          vinayrpet Vinayakumar B added a comment -

          1. After HDFS-9009, NN metrics are also configured to NullAppender by default. So, we can keep as it is.

          Okay. Thanks for pointing out.

          2. Yes, some of the attribute values like VolumeInfo are long. So, I avoided trim in DN metrics log.

          Fine.

          3. Thanks for pointing, I have removed the public accessor in latest patch.

          Okay.

          +1, changes looks good to me.

          Arpit Agarwal, do you also want to take a look?

          Will wait for a day before commit.
          -Thanks

          Show
          vinayrpet Vinayakumar B added a comment - 1. After HDFS-9009 , NN metrics are also configured to NullAppender by default. So, we can keep as it is. Okay. Thanks for pointing out. 2. Yes, some of the attribute values like VolumeInfo are long. So, I avoided trim in DN metrics log. Fine. 3. Thanks for pointing, I have removed the public accessor in latest patch. Okay. +1, changes looks good to me. Arpit Agarwal , do you also want to take a look? Will wait for a day before commit. -Thanks
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          Thanks for the heads up Vinayakumar B.

          Kanaka Kumar Avvaru, the patch looks good. Two comments, +1 otherwise

          1. Can we avoid changing the visibility of DataNode methods for the test case? It looks like a couple of other tests are already subclassing DataNode.
          2. DataNode#startMetricsLogger(conf) should probably be called at the end of the startDataNode routine, at least after the DN metrics system is initialized.
          Show
          arpitagarwal Arpit Agarwal added a comment - - edited Thanks for the heads up Vinayakumar B . Kanaka Kumar Avvaru , the patch looks good. Two comments, +1 otherwise Can we avoid changing the visibility of DataNode methods for the test case? It looks like a couple of other tests are already subclassing DataNode. DataNode#startMetricsLogger(conf) should probably be called at the end of the startDataNode routine, at least after the DN metrics system is initialized.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Thanks for the review Arpit Agarwal, Vinayakumar B. Please review the latest patch.
          1.Agree, I have refactored and reused the DN creation with mocked NN from TestBlockRecovery
          2.Ok, moved.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Thanks for the review Arpit Agarwal , Vinayakumar B . Please review the latest patch. 1.Agree, I have refactored and reused the DN creation with mocked NN from TestBlockRecovery 2.Ok, moved.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 57s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 26s The applied patch generated 2 new checkstyle issues (total was 719, now 716).
          -1 whitespace 0m 1s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 26s Tests passed in hadoop-common.
          -1 hdfs tests 79m 57s Tests failed in hadoop-hdfs.
              150m 21s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.datanode.TestBlockRecovery
          Timed out tests org.apache.hadoop.hdfs.TestDecommission
            org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755379/HDFS-8953-04.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 486d5cb
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12395/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12395/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 26s The applied patch generated 2 new checkstyle issues (total was 719, now 716). -1 whitespace 0m 1s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 26s Tests passed in hadoop-common. -1 hdfs tests 79m 57s Tests failed in hadoop-hdfs.     150m 21s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestBlockRecovery Timed out tests org.apache.hadoop.hdfs.TestDecommission   org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755379/HDFS-8953-04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 486d5cb checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12395/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12395/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12395/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Refactoring to util class & refer from other class caused failures in TestBlockRecovery. So reverting changes in the file TestBlockRecovery.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Refactoring to util class & refer from other class caused failures in TestBlockRecovery . So reverting changes in the file TestBlockRecovery.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 22m 53s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 9m 1s There were no new javac warning messages.
          +1 javadoc 11m 49s There were no new javadoc warning messages.
          +1 release audit 0m 28s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 55s The applied patch generated 2 new checkstyle issues (total was 719, now 716).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 42s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          +1 findbugs 5m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 26m 58s Tests failed in hadoop-common.
          -1 hdfs tests 63m 40s Tests failed in hadoop-hdfs.
              145m 14s  



          Reason Tests
          Failed unit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.security.token.delegation.web.TestWebDelegationToken
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.blockmanagement.TestNodeCount
          Timed out tests org.apache.hadoop.hdfs.TestDistributedFileSystem
            org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755412/HDFS-8953-05.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 486d5cb
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12399/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12399/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 9m 1s There were no new javac warning messages. +1 javadoc 11m 49s There were no new javadoc warning messages. +1 release audit 0m 28s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 55s The applied patch generated 2 new checkstyle issues (total was 719, now 716). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 42s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 5m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 26m 58s Tests failed in hadoop-common. -1 hdfs tests 63m 40s Tests failed in hadoop-hdfs.     145m 14s   Reason Tests Failed unit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.security.token.delegation.web.TestWebDelegationToken   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.blockmanagement.TestNodeCount Timed out tests org.apache.hadoop.hdfs.TestDistributedFileSystem   org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755412/HDFS-8953-05.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 486d5cb checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12399/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12399/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12399/console This message was automatically generated.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          test failures doesn't seem to be related and check style issues reported can be ignored as stated in earlier comments

          Show
          kanaka Kanaka Kumar Avvaru added a comment - test failures doesn't seem to be related and check style issues reported can be ignored as stated in earlier comments
          Hide
          stevel@apache.org Steve Loughran added a comment -

          -1. uses a hard coded port for tests. Use ServerSocketUtil to find a free one

          Show
          stevel@apache.org Steve Loughran added a comment - -1. uses a hard coded port for tests. Use ServerSocketUtil to find a free one
          Hide
          vinayrpet Vinayakumar B added a comment -
          . +  private final static InetSocketAddress NN_ADDR = new InetSocketAddress(
          +      "localhost", 5020);

          Steve Loughran, Refering to this part of the code?
          This address is just for Mocking DN only. No server/connection will be made using this. So don't think is a problem.

          Show
          vinayrpet Vinayakumar B added a comment - . + private final static InetSocketAddress NN_ADDR = new InetSocketAddress( + "localhost" , 5020); Steve Loughran , Refering to this part of the code? This address is just for Mocking DN only. No server/connection will be made using this. So don't think is a problem.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          If you are confident that it doesn't open a port, then I revert my veto. It's just I'd identified HDFS-8880 as a source of intermittent jenkins port-in-use failures, so was auditing adjacent patches for similar issues.

          Show
          stevel@apache.org Steve Loughran added a comment - If you are confident that it doesn't open a port, then I revert my veto. It's just I'd identified HDFS-8880 as a source of intermittent jenkins port-in-use failures, so was auditing adjacent patches for similar issues.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks for reverting the veto Steve Loughran.
          Yes I am confident. NN_ADDR = new InetSocketAddress("localhost", 5020); is used DatanodeTestUtils#startDNWithMockNN which will mock the NameNode communication for testing purpose, which also added with this patch.

          Show
          vinayrpet Vinayakumar B added a comment - Thanks for reverting the veto Steve Loughran . Yes I am confident. NN_ADDR = new InetSocketAddress("localhost", 5020); is used DatanodeTestUtils#startDNWithMockNN which will mock the NameNode communication for testing purpose, which also added with this patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1 for the v5 patch.

          Will commit shortly.

          Show
          vinayrpet Vinayakumar B added a comment - +1 for the v5 patch. Will commit shortly.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Seems patch doesnt apply on latest trunk.

          Kanaka Kumar Avvaru, please update the patch against latest trunk.

          Show
          vinayrpet Vinayakumar B added a comment - Seems patch doesnt apply on latest trunk. Kanaka Kumar Avvaru , please update the patch against latest trunk.
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Thanks Vinayakumar B for follow-up & pointing. I have updated patch against trunk changes. V6 is same as V5 except a line change in import of NameNode.java

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Thanks Vinayakumar B for follow-up & pointing. I have updated patch against trunk changes. V6 is same as V5 except a line change in import of NameNode.java
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk and branch-2.
          Thanks Kanaka Kumar Avvaru for the contribution.
          Thanks Arpit Agarwal and Steve Loughran.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Kanaka Kumar Avvaru for the contribution. Thanks Arpit Agarwal and Steve Loughran .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8456/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8456/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 46s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 19s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 40s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 40s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 45s Tests passed in hadoop-common.
          -1 hdfs tests 71m 51s Tests failed in hadoop-hdfs.
              139m 24s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDFSOutputStream
          Timed out tests org.apache.hadoop.hdfs.crypto.TestHdfsCryptoStreams



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756035/HDFS-8953-06.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ae5308f
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12453/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12453/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12453/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12453/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 46s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 19s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 40s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 40s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 45s Tests passed in hadoop-common. -1 hdfs tests 71m 51s Tests failed in hadoop-hdfs.     139m 24s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSOutputStream Timed out tests org.apache.hadoop.hdfs.crypto.TestHdfsCryptoStreams Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756035/HDFS-8953-06.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ae5308f hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12453/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12453/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12453/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12453/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1129 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1129/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1129 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1129/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #396 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/396/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #396 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/396/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/390/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/390/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #374 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/374/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #374 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/374/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2338 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2338/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2338 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2338/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2314 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2314/)
          HDFS-8953. DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2314 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2314/ ) HDFS-8953 . DataNode Metrics logging (Contributed by Kanaka Kumar Avvaru) (vinayakumarb: rev ce69c9b54c642cfbe789fc661cfc7dcbb07b4ac5) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetricsLogger.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/MetricsLoggerTask.java hadoop-common-project/hadoop-common/src/main/conf/log4j.properties hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          Hide
          kanaka Kanaka Kumar Avvaru added a comment -

          Thanks Arpit Agarwal, Steve Loughran for reviews.
          Thanks Vinayakumar B for reviews and commit.

          Show
          kanaka Kanaka Kumar Avvaru added a comment - Thanks Arpit Agarwal , Steve Loughran for reviews. Thanks Vinayakumar B for reviews and commit.

            People

            • Assignee:
              kanaka Kanaka Kumar Avvaru
              Reporter:
              kanaka Kanaka Kumar Avvaru
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development