[HDFS-8971] Remove guards when calling LOG.debug() and LOG.trace() in client package

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: build
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 27/Aug/15 05:29
• Updated: 03/Dec/16 00:53
• Resolved: 30/Sep/15 00:54

Description

We moved the shortcircuit package from hadoop-hdfs to hadoop-hdfs-client module in JIRA HDFS-8934 and HDFS-8951, and BlockReader in HDFS-8925. Meanwhile, we also replaced the log4j log with slf4j logger. There were existing code in the client package to guard the log when calling LOG.debug() and LOG.trace(), e.g. in ShortCircuitCache.java, we have code like this:

Trace with guards

724    if (LOG.isTraceEnabled()) {
725      LOG.trace(this + ": found waitable for " + key);
726    }

In slf4j, this kind of guard is not necessary. We should clean the code by removing the guard from the client package.

Trace without guards

724    LOG.trace("{}: found waitable for {}", this, key);

Issue Links

• is blocked by: HDFS-8053 Move DFSIn/OutputStream and related classes to hadoop-hdfs-client
• is blocked by: HDFS-8740 Move DistributedFileSystem to hadoop-hdfs-client
• is blocked by: HDFS-8925 Move BlockReaderLocal to hdfs-client
• is blocked by: HDFS-9002 Move o.a.h.hdfs.net/*Peer classes to hdfs-client
• is blocked by: HDFS-9099 Move DistributedFileSystem to hadoop-hdfs-client
• is related to: HDFS-9383 TestByteArrayManager#testByteArrayManager fails
• links to: GitHub Pull Request #46