Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8356

Document missing properties in hdfs-default.xml

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The following properties are currently not defined in hdfs-default.xml. These properties should either be
      A) documented in hdfs-default.xml OR
      B) listed as an exception (with comments, e.g. for internal use) in the TestHdfsConfigFields unit test

      1. HDFS-8356.001.patch
        20 kB
        Ray Chiang
      2. HDFS-8356.002.patch
        20 kB
        Ray Chiang
      3. HDFS-8356.003.patch
        34 kB
        Ray Chiang
      4. HDFS-8356.004.patch
        33 kB
        Ray Chiang
      5. HDFS-8356.005.patch
        34 kB
        Ray Chiang
      6. HDFS-8356.006.patch
        35 kB
        Ray Chiang
      7. HDFS-8356.007.patch
        35 kB
        Ray Chiang
      8. HDFS-8356.008.patch
        35 kB
        Ray Chiang
      9. HDFS-8356.009.patch
        35 kB
        Ray Chiang
      10. HDFS-8356.010.patch
        36 kB
        Ray Chiang
      11. HDFS-8356.011.patch
        36 kB
        Ray Chiang
      12. HDFS-8356.012.patch
        36 kB
        Ray Chiang
      13. HDFS-8356.013.patch
        36 kB
        Ray Chiang
      14. HDFS-8356.014.branch-2.patch
        36 kB
        Ray Chiang
      15. HDFS-8356.014.patch
        36 kB
        Ray Chiang
      16. HDFS-8356.015.branch-2.patch
        36 kB
        Ray Chiang
      17. HDFS-8356.015.patch
        35 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -
          • Initial version with all the missing properties added
          • Still needs lots of description fields filled in
          • Fields without default values still need manual verification (can get list once HADOOP-12101 is committed)
          Show
          rchiang Ray Chiang added a comment - Initial version with all the missing properties added Still needs lots of description fields filled in Fields without default values still need manual verification (can get list once HADOOP-12101 is committed)
          Hide
          rchiang Ray Chiang added a comment -

          Submit initial version for testing

          Show
          rchiang Ray Chiang added a comment - Submit initial version for testing
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 54s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 0s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 51s There were no new checkstyle issues.
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 40s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 30s Pre-build of native portion
          -1 hdfs tests 18m 9s Tests failed in hadoop-hdfs.
              62m 26s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestReplication
            hadoop.hdfs.TestLeaseRecovery
            hadoop.hdfs.TestFileAppend4
            hadoop.hdfs.TestRead
            hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.server.namenode.TestSecondaryWebUi
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional
            hadoop.hdfs.TestPread
            hadoop.hdfs.tools.TestGetGroups
            hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.server.datanode.TestRefreshNamenodes
            hadoop.hdfs.TestHdfsAdmin
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.fs.viewfs.TestViewFsWithXAttrs
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
            hadoop.hdfs.TestClientReportBadBlock
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.TestParallelShortCircuitRead
            hadoop.hdfs.server.namenode.TestFSEditLogLoader
            hadoop.hdfs.server.namenode.TestAuditLogger
            hadoop.hdfs.TestFSInputChecker
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestDatanodeRegistration
            hadoop.hdfs.tools.TestDebugAdmin
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
            hadoop.hdfs.qjournal.TestNNWithQJM
            hadoop.hdfs.TestSetrepIncreasing
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestDatanodeReport
            hadoop.hdfs.TestAppendSnapshotTruncate
            hadoop.hdfs.TestDFSShellGenericOptions
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
            hadoop.fs.TestEnhancedByteBufferAccess
            hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
            hadoop.tracing.TestTraceAdmin
            hadoop.hdfs.server.namenode.TestNameNodeRpcServer
            hadoop.hdfs.TestFileAppendRestart
            hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
            hadoop.hdfs.TestMultiThreadedHflush
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.tools.TestStoragePolicyCommands
            hadoop.hdfs.TestDFSRemove
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.namenode.TestHDFSConcat
            hadoop.hdfs.tools.TestDFSHAAdmin
            hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            hadoop.TestRefreshCallQueue
            hadoop.hdfs.TestSetTimes
            hadoop.hdfs.TestListFilesInDFS
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.server.namenode.TestMalformedURLs
            hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.TestParallelShortCircuitReadNoChecksum
            hadoop.hdfs.TestBlocksScheduledCounter
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.TestMiniDFSCluster
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.server.datanode.TestBPOfferService
            hadoop.net.TestNetworkTopology
            hadoop.security.TestPermissionSymlinks
            hadoop.hdfs.TestDFSRollback
            hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica
            hadoop.fs.TestUnbuffer
            hadoop.hdfs.TestParallelShortCircuitLegacyRead
            hadoop.hdfs.TestQuota
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.TestFileConcurrentReader
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.server.datanode.TestDataNodeExit
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.server.namenode.TestFSImage
            hadoop.hdfs.server.namenode.TestCreateEditsLog
            hadoop.security.TestRefreshUserMappings
            hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
            hadoop.tracing.TestTracing
            hadoop.hdfs.server.namenode.TestCheckpoint
            hadoop.hdfs.tools.TestDFSAdmin
            hadoop.hdfs.server.datanode.TestSimulatedFSDataset
            hadoop.hdfs.server.namenode.TestMetadataVersionOutput
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.fs.contract.hdfs.TestHDFSContractAppend
            hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
            hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
            hadoop.hdfs.server.namenode.TestAllowFormat
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.TestReadWhileWriting
            hadoop.hdfs.TestDatanodeLayoutUpgrade
            hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA
            hadoop.hdfs.TestClientBlockVerification
            hadoop.hdfs.TestDataTransferProtocol
            hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.namenode.TestDeadDatanode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
            hadoop.hdfs.server.namenode.TestAuditLogs
            hadoop.hdfs.crypto.TestHdfsCryptoStreams
            hadoop.hdfs.web.TestWebHdfsFileSystemContract
            hadoop.hdfs.server.namenode.TestFsLimits
            hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
            hadoop.hdfs.server.blockmanagement.TestAvailableSpaceBlockPlacementPolicy
            hadoop.fs.TestFcHdfsPermission
            hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.namenode.TestFSDirectory
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.tracing.TestTracingShortCircuitLocalRead
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.TestParallelImageWrite
            hadoop.hdfs.server.namenode.TestEditLogRace
            hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            hadoop.hdfs.TestDFSUpgrade
            hadoop.hdfs.server.blockmanagement.TestBlockReportRateLimiting
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestGetBlocks
            hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
            hadoop.fs.contract.hdfs.TestHDFSContractSeek
            hadoop.hdfs.server.namenode.TestEditLogJournalFailures
            hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.datanode.TestIncrementalBrVariations
            hadoop.fs.permission.TestStickyBit
            hadoop.hdfs.TestLeaseRecovery2
            hadoop.hdfs.server.namenode.ha.TestHAConfiguration
            hadoop.hdfs.server.namenode.TestAclConfigFlag
            hadoop.cli.TestXAttrCLI
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.fs.TestGlobPaths
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure
            hadoop.fs.TestFcHdfsCreateMkdir
            hadoop.hdfs.TestParallelUnixDomainRead
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestDFSRename
            hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
            hadoop.hdfs.server.namenode.TestFSImageWithAcl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.TestFSOutputSummer
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestConnCache
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.TestDFSMkdirs
            hadoop.hdfs.TestWriteRead
            hadoop.hdfs.server.namenode.TestFSImageWithXAttr
            hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.hdfs.TestEncryptionZonesWithHA
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.datanode.TestDiskError
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.datanode.TestDataNodeECN
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.security.TestPermission
            hadoop.fs.contract.hdfs.TestHDFSContractOpen
            hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
            hadoop.hdfs.TestBlockReaderFactory
            hadoop.hdfs.server.datanode.TestDataNodeInitStorage
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
            hadoop.hdfs.TestSetrepDecreasing
            hadoop.hdfs.server.namenode.ha.TestNNHealthCheck
            hadoop.hdfs.TestIsMethodSupported
            hadoop.hdfs.TestDFSFinalize
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
            hadoop.hdfs.TestFileCreationEmpty
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.fs.viewfs.TestViewFileSystemWithAcls
            hadoop.hdfs.TestDatanodeConfig
            hadoop.hdfs.TestFileCreationDelete
            hadoop.fs.TestFcHdfsSetUMask
            hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
            hadoop.hdfs.TestLargeBlock
            hadoop.fs.viewfs.TestViewFsWithAcls
            hadoop.fs.TestUrlStreamHandler
            hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.TestGenericRefresh
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.TestDFSStorageStateRecovery
            hadoop.hdfs.TestDisableConnCache
            hadoop.hdfs.tools.TestDFSHAAdminMiniCluster
            hadoop.hdfs.server.namenode.TestTransferFsImage
            hadoop.hdfs.TestRemoteBlockReader2
            hadoop.hdfs.TestLease
            hadoop.hdfs.server.namenode.TestXAttrConfigFlag
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
            hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
            hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens
            hadoop.hdfs.server.namenode.TestGenericJournalConf
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.hdfs.web.TestHttpsFileSystem
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
            hadoop.hdfs.server.datanode.TestDatanodeProtocolRetryPolicy
            hadoop.hdfs.TestAppendDifferentChecksum
            hadoop.hdfs.TestRemoteBlockReader
            hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter
            hadoop.hdfs.web.TestWebHDFSAcl
            hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
            hadoop.hdfs.TestHDFSTrash
            hadoop.hdfs.TestRestartDFS
            hadoop.hdfs.TestDFSAddressConfig
            hadoop.fs.contract.hdfs.TestHDFSContractConcat
            hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.tools.TestJMXGet
            hadoop.hdfs.TestFileCreation
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.hdfs.tools.TestDFSAdminWithHA
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.viewfs.TestViewFileSystemHdfs
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.fs.TestResolveHdfsSymlink
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.fs.contract.hdfs.TestHDFSContractDelete
            hadoop.hdfs.TestHDFSFileSystemContract
            hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
            hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
            hadoop.hdfs.server.namenode.TestClusterId
            hadoop.cli.TestAclCLI
            hadoop.hdfs.server.datanode.TestDatanodeStartupOptions
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.TestDFSPermission
            hadoop.hdfs.TestHDFSServerPorts
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.fs.viewfs.TestViewFsHdfs
            hadoop.hdfs.web.TestWebHDFSForHA
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.cli.TestCryptoAdminCLI
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.TestBlockMissingException
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.server.datanode.TestStorageReport
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.server.namenode.TestNameNodeResourceChecker
            hadoop.hdfs.TestRollingUpgradeRollback
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestDeleteBlockPool
            hadoop.hdfs.TestBlockReaderLocalLegacy
            hadoop.hdfs.TestSmallBlock
            hadoop.hdfs.TestPipelines
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.hdfs.security.token.block.TestBlockToken
            hadoop.hdfs.server.namenode.TestFileContextAcl
            hadoop.hdfs.TestRenameWhileOpen
            hadoop.hdfs.TestFileCreationClient
            hadoop.hdfs.server.namenode.TestGetBlockLocations
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.server.namenode.TestNameNodeXAttr
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestDFSStartupVersions
            hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
            hadoop.fs.contract.hdfs.TestHDFSContractMkdir
            hadoop.hdfs.TestFileAppend3
            hadoop.fs.contract.hdfs.TestHDFSContractCreate
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.TestBalancerBandwidth
            hadoop.hdfs.TestAbandonBlock
            hadoop.hdfs.TestFetchImage
            hadoop.fs.viewfs.TestViewFsFileStatusHdfs
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
            hadoop.cli.TestCacheAdminCLI
            hadoop.fs.TestSymlinkHdfsDisable
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.server.namenode.TestFSNamesystemMBean
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.hdfs.TestSeekBug
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.server.blockmanagement.TestSequentialBlockId
            hadoop.fs.TestHDFSFileContextMainOperations
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.hdfs.TestDatanodeDeath
            hadoop.hdfs.TestBlockReaderLocal
            hadoop.fs.viewfs.TestViewFsDefaultValue
            hadoop.hdfs.server.namenode.TestFSNamesystem
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestListFilesInFileContext
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestModTime
            hadoop.hdfs.web.TestWebHDFSXAttr
            hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
            hadoop.hdfs.security.TestDelegationToken
            hadoop.hdfs.server.datanode.TestCachingStrategy
            hadoop.hdfs.server.namenode.TestFileLimit
            hadoop.hdfs.TestDFSClientExcludedNodes
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.TestSnapshotCommands
            hadoop.hdfs.TestClose
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
            hadoop.hdfs.server.datanode.TestHSync
            hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
            hadoop.fs.contract.hdfs.TestHDFSContractRename
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
            hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
            hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling
            hadoop.hdfs.TestDFSInputStream
            hadoop.hdfs.server.namenode.TestCommitBlockSynchronization
            hadoop.fs.viewfs.TestViewFsAtHdfsRoot
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.TestDFSOutputStream
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.server.namenode.TestQuotaByStorageType
            hadoop.hdfs.server.datanode.TestDataNodeMXBean
            hadoop.hdfs.server.namenode.TestFileJournalManager
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.TestBlockUnderConstruction
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestDFSInotifyEventInputStream
            hadoop.hdfs.TestFileStatus
            hadoop.hdfs.TestFsShellPermission
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
            hadoop.hdfs.server.namenode.TestMetaSave
            hadoop.fs.loadGenerator.TestLoadGenerator
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
            hadoop.hdfs.TestInjectionForSimulatedStorage
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.server.namenode.TestStartup
            hadoop.hdfs.server.datanode.TestTransferRbw
            hadoop.hdfs.web.TestFSMainOperationsWebHdfs
            hadoop.hdfs.server.namenode.TestAddBlockRetry
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
            hadoop.hdfs.server.namenode.TestFileContextXAttr
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.server.namenode.TestHostsFiles
            hadoop.hdfs.TestReservedRawPaths
            hadoop.hdfs.server.namenode.TestNameNodeRecovery
            hadoop.fs.shell.TestHdfsTextCommand
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.TestFileCorruption
            hadoop.hdfs.server.namenode.TestStorageRestore
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.server.namenode.TestINodeAttributeProvider



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741389/HDFS-8356.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 122cad6
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11453/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11453/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11453/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 54s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 51s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 40s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 30s Pre-build of native portion -1 hdfs tests 18m 9s Tests failed in hadoop-hdfs.     62m 26s   Reason Tests Failed unit tests hadoop.hdfs.TestReplication   hadoop.hdfs.TestLeaseRecovery   hadoop.hdfs.TestFileAppend4   hadoop.hdfs.TestRead   hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.namenode.TestSecondaryWebUi   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional   hadoop.hdfs.TestPread   hadoop.hdfs.tools.TestGetGroups   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.datanode.TestRefreshNamenodes   hadoop.hdfs.TestHdfsAdmin   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.fs.viewfs.TestViewFsWithXAttrs   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler   hadoop.hdfs.TestClientReportBadBlock   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.TestFSInputChecker   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy   hadoop.hdfs.qjournal.TestNNWithQJM   hadoop.hdfs.TestSetrepIncreasing   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestDatanodeReport   hadoop.hdfs.TestAppendSnapshotTruncate   hadoop.hdfs.TestDFSShellGenericOptions   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles   hadoop.fs.TestEnhancedByteBufferAccess   hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement   hadoop.tracing.TestTraceAdmin   hadoop.hdfs.server.namenode.TestNameNodeRpcServer   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.TestParallelRead   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.TestDFSRemove   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.tools.TestDFSHAAdmin   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.TestRefreshCallQueue   hadoop.hdfs.TestSetTimes   hadoop.hdfs.TestListFilesInDFS   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.TestMalformedURLs   hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.TestParallelShortCircuitReadNoChecksum   hadoop.hdfs.TestBlocksScheduledCounter   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.TestMiniDFSCluster   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.server.datanode.TestBPOfferService   hadoop.net.TestNetworkTopology   hadoop.security.TestPermissionSymlinks   hadoop.hdfs.TestDFSRollback   hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.datanode.fsdataset.impl.TestWriteToReplica   hadoop.fs.TestUnbuffer   hadoop.hdfs.TestParallelShortCircuitLegacyRead   hadoop.hdfs.TestQuota   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.TestFileConcurrentReader   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.datanode.TestDataNodeExit   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.server.namenode.TestFSImage   hadoop.hdfs.server.namenode.TestCreateEditsLog   hadoop.security.TestRefreshUserMappings   hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.server.datanode.TestSimulatedFSDataset   hadoop.hdfs.server.namenode.TestMetadataVersionOutput   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.fs.contract.hdfs.TestHDFSContractAppend   hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestAllowFormat   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.TestReadWhileWriting   hadoop.hdfs.TestDatanodeLayoutUpgrade   hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA   hadoop.hdfs.TestClientBlockVerification   hadoop.hdfs.TestDataTransferProtocol   hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.namenode.TestDeadDatanode   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.crypto.TestHdfsCryptoStreams   hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.server.namenode.TestFsLimits   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.server.blockmanagement.TestAvailableSpaceBlockPlacementPolicy   hadoop.fs.TestFcHdfsPermission   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.tracing.TestTracingShortCircuitLocalRead   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.server.namenode.TestEditLogRace   hadoop.hdfs.server.datanode.TestReadOnlySharedStorage   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.TestDFSUpgrade   hadoop.hdfs.server.blockmanagement.TestBlockReportRateLimiting   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestGetBlocks   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.fs.permission.TestStickyBit   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.server.namenode.ha.TestHAConfiguration   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.cli.TestXAttrCLI   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.fs.TestGlobPaths   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure   hadoop.fs.TestFcHdfsCreateMkdir   hadoop.hdfs.TestParallelUnixDomainRead   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSRename   hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.TestFSOutputSummer   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestConnCache   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.TestDFSMkdirs   hadoop.hdfs.TestWriteRead   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.datanode.TestDiskError   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.datanode.TestDataNodeECN   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithNodeGroup   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.security.TestPermission   hadoop.fs.contract.hdfs.TestHDFSContractOpen   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.TestBlockReaderFactory   hadoop.hdfs.server.datanode.TestDataNodeInitStorage   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.TestSetrepDecreasing   hadoop.hdfs.server.namenode.ha.TestNNHealthCheck   hadoop.hdfs.TestIsMethodSupported   hadoop.hdfs.TestDFSFinalize   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory   hadoop.hdfs.TestFileCreationEmpty   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.fs.viewfs.TestViewFileSystemWithAcls   hadoop.hdfs.TestDatanodeConfig   hadoop.hdfs.TestFileCreationDelete   hadoop.fs.TestFcHdfsSetUMask   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.TestLargeBlock   hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.fs.TestUrlStreamHandler   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.TestGenericRefresh   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.TestDFSStorageStateRecovery   hadoop.hdfs.TestDisableConnCache   hadoop.hdfs.tools.TestDFSHAAdminMiniCluster   hadoop.hdfs.server.namenode.TestTransferFsImage   hadoop.hdfs.TestRemoteBlockReader2   hadoop.hdfs.TestLease   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.fs.viewfs.TestViewFileSystemWithXAttrs   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens   hadoop.hdfs.server.namenode.TestGenericJournalConf   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover   hadoop.hdfs.server.datanode.TestDatanodeProtocolRetryPolicy   hadoop.hdfs.TestAppendDifferentChecksum   hadoop.hdfs.TestRemoteBlockReader   hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter   hadoop.hdfs.web.TestWebHDFSAcl   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.TestHDFSTrash   hadoop.hdfs.TestRestartDFS   hadoop.hdfs.TestDFSAddressConfig   hadoop.fs.contract.hdfs.TestHDFSContractConcat   hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestDistributedFileSystem   hadoop.tools.TestJMXGet   hadoop.hdfs.TestFileCreation   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.viewfs.TestViewFileSystemHdfs   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.fs.TestResolveHdfsSymlink   hadoop.hdfs.server.mover.TestStorageMover   hadoop.fs.contract.hdfs.TestHDFSContractDelete   hadoop.hdfs.TestHDFSFileSystemContract   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation   hadoop.hdfs.server.namenode.TestClusterId   hadoop.cli.TestAclCLI   hadoop.hdfs.server.datanode.TestDatanodeStartupOptions   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestDFSPermission   hadoop.hdfs.TestHDFSServerPorts   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.fs.viewfs.TestViewFsHdfs   hadoop.hdfs.web.TestWebHDFSForHA   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.TestBlockMissingException   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.server.datanode.TestStorageReport   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.server.namenode.TestNameNodeResourceChecker   hadoop.hdfs.TestRollingUpgradeRollback   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDeleteBlockPool   hadoop.hdfs.TestBlockReaderLocalLegacy   hadoop.hdfs.TestSmallBlock   hadoop.hdfs.TestPipelines   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.hdfs.security.token.block.TestBlockToken   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.TestFileCreationClient   hadoop.hdfs.server.namenode.TestGetBlockLocations   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestDFSStartupVersions   hadoop.hdfs.TestWriteBlockGetsBlockLengthHint   hadoop.fs.contract.hdfs.TestHDFSContractMkdir   hadoop.hdfs.TestFileAppend3   hadoop.fs.contract.hdfs.TestHDFSContractCreate   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestBalancerBandwidth   hadoop.hdfs.TestAbandonBlock   hadoop.hdfs.TestFetchImage   hadoop.fs.viewfs.TestViewFsFileStatusHdfs   hadoop.hdfs.server.blockmanagement.TestReplicationPolicy   hadoop.cli.TestCacheAdminCLI   hadoop.fs.TestSymlinkHdfsDisable   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.TestSeekBug   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.server.blockmanagement.TestSequentialBlockId   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.TestDatanodeDeath   hadoop.hdfs.TestBlockReaderLocal   hadoop.fs.viewfs.TestViewFsDefaultValue   hadoop.hdfs.server.namenode.TestFSNamesystem   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestListFilesInFileContext   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestModTime   hadoop.hdfs.web.TestWebHDFSXAttr   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.server.datanode.TestCachingStrategy   hadoop.hdfs.server.namenode.TestFileLimit   hadoop.hdfs.TestDFSClientExcludedNodes   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.TestSnapshotCommands   hadoop.hdfs.TestClose   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.hdfs.server.datanode.TestHSync   hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA   hadoop.fs.contract.hdfs.TestHDFSContractRename   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.server.namenode.TestValidateConfigurationSettings   hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.server.namenode.TestCommitBlockSynchronization   hadoop.fs.viewfs.TestViewFsAtHdfsRoot   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.datanode.TestDataNodeMXBean   hadoop.hdfs.server.namenode.TestFileJournalManager   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.TestFileStatus   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.fs.loadGenerator.TestLoadGenerator   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   hadoop.hdfs.TestInjectionForSimulatedStorage   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.datanode.TestTransferRbw   hadoop.hdfs.web.TestFSMainOperationsWebHdfs   hadoop.hdfs.server.namenode.TestAddBlockRetry   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   hadoop.hdfs.server.namenode.TestFileContextXAttr   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.TestReservedRawPaths   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.fs.shell.TestHdfsTextCommand   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.TestINodeAttributeProvider Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741389/HDFS-8356.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 122cad6 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11453/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11453/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11453/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Remove newlines from empty values to allow more unit tests to pass
          • Add appropriate default values for *.startup properties
          • Still lots of properties to document and add default values
          Show
          rchiang Ray Chiang added a comment - Remove newlines from empty values to allow more unit tests to pass Add appropriate default values for *.startup properties Still lots of properties to document and add default values
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 55s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 17s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 17s Pre-build of native portion
          -1 hdfs tests 159m 48s Tests failed in hadoop-hdfs.
              206m 19s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12742202/HDFS-8356.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / aa07dea
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11504/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11504/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11504/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11504/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 55s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 17s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 159m 48s Tests failed in hadoop-hdfs.     206m 19s   Reason Tests Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742202/HDFS-8356.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / aa07dea Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11504/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11504/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11504/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11504/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Pre-patch findbugs

          Fixed in MAPREDUCE-6421

          RE: Failing unit test

          Test passes in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: Pre-patch findbugs Fixed in MAPREDUCE-6421 RE: Failing unit test Test passes in my tree.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Pre-patch findbugs

          Fixed in MAPREDUCE-6421

          RE: Failing unit test

          Test passes in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: Pre-patch findbugs Fixed in MAPREDUCE-6421 RE: Failing unit test Test passes in my tree.
          Hide
          rchiang Ray Chiang added a comment -

          Ugh, ignore last comments. Wrote to wrong JIRA.

          Show
          rchiang Ray Chiang added a comment - Ugh, ignore last comments. Wrote to wrong JIRA.
          Hide
          aw Allen Wittenauer added a comment -

          I'm not sure it's actually helpful to have a list of properties without descriptions...

          Show
          aw Allen Wittenauer added a comment - I'm not sure it's actually helpful to have a list of properties without descriptions...
          Hide
          rchiang Ray Chiang added a comment -

          I've cancelled the patch for now.

          Yeah, I've fallen behind this work doing other stuff. Normally, I try to get an empty minimal .xml file that passes test-patch.sh/Jenkins and then move forward from there. Sadly, hdfs-default.xml has a lot more unit test dependencies than yarn-default.xml.

          Show
          rchiang Ray Chiang added a comment - I've cancelled the patch for now. Yeah, I've fallen behind this work doing other stuff. Normally, I try to get an empty minimal .xml file that passes test-patch.sh/Jenkins and then move forward from there. Sadly, hdfs-default.xml has a lot more unit test dependencies than yarn-default.xml.
          Hide
          rchiang Ray Chiang added a comment -

          Submit for testing

          Show
          rchiang Ray Chiang added a comment - Submit for testing
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 25s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_66
          +1 compile 0m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_66
          +1 javac 0m 35s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_91
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 47s the patch passed with JDK v1.7.0_91
          -1 unit 65m 1s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          155m 14s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
            hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780615/HDFS-8356.003.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 9ecdb0f5accf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 28bd138
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14032/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14032/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_66 +1 compile 0m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_66 +1 javac 0m 35s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_91 +1 javac 0m 39s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 59s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 47s the patch passed with JDK v1.7.0_91 -1 unit 65m 1s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 64m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 155m 14s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780615/HDFS-8356.003.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 9ecdb0f5accf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28bd138 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14032/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14032/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14032/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Fix whitespace.

          Show
          rchiang Ray Chiang added a comment - Fix whitespace.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 39s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_66
          +1 compile 0m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.8.0_66
          +1 javac 0m 38s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_91
          +1 javac 0m 38s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_91
          -1 unit 52m 24s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 50m 33s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          139m 57s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780643/HDFS-8356.004.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 1c9ea1d1183a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 355c0ce
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14039/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14039/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14039/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14039/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 39s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_66 +1 javac 0m 38s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_91 +1 javac 0m 38s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 0s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_91 -1 unit 52m 24s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 50m 33s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 139m 57s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780643/HDFS-8356.004.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 1c9ea1d1183a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 355c0ce Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14039/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14039/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14039/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14039/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing unit tests

          Different set than previous run and both tests using JDK 8 in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: Failing unit tests Different set than previous run and both tests using JDK 8 in my tree.
          Hide
          rchiang Ray Chiang added a comment -

          Just as a quick FYI, I've already run this verifier using HADOOP-12101 locally in my tree, so many of the defaults are already automatically checked. With that change, you can see which values need manual verification (currently 86 out of 344 in my local tree) and which ones are automatically checked (248 out of 344).

          Show
          rchiang Ray Chiang added a comment - Just as a quick FYI, I've already run this verifier using HADOOP-12101 locally in my tree, so many of the defaults are already automatically checked. With that change, you can see which values need manual verification (currently 86 out of 344 in my local tree) and which ones are automatically checked (248 out of 344).
          Hide
          rchiang Ray Chiang added a comment -
          • Add six new undocumented properties
          • Update code to match changes in existing properties
          Show
          rchiang Ray Chiang added a comment - Add six new undocumented properties Update code to match changes in existing properties
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 0m 47s trunk passed with JDK v1.8.0_72
          +1 compile 0m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 42s the patch passed with JDK v1.8.0_72
          +1 javac 0m 42s the patch passed
          +1 compile 0m 43s the patch passed with JDK v1.7.0_95
          +1 javac 0m 43s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
          -1 unit 70m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 68m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          167m 10s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789611/HDFS-8356.005.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 3f4d413d023b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d27d7fc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14597/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14597/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 0m 47s trunk passed with JDK v1.8.0_72 +1 compile 0m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 49s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_72 +1 javac 0m 42s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_95 +1 javac 0m 43s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 17s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 70m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 68m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 167m 10s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789611/HDFS-8356.005.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 3f4d413d023b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d27d7fc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14597/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14597/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing JDK 1.7 tests

          Both tests pass in my tree

          RE: Failing JDK 1.8 tests

          The failing test passes in my patched tree and in a clean upstream tree.

          Show
          rchiang Ray Chiang added a comment - RE: Failing JDK 1.7 tests Both tests pass in my tree RE: Failing JDK 1.8 tests The failing test passes in my patched tree and in a clean upstream tree.
          Hide
          rchiang Ray Chiang added a comment -

          Akira Ajisaka, Tsuyoshi Ozawa, this is the HDFS equivalent of YARN-3069. Let me know if either of you has the time and/or interest to review this. I've already had to update the patch several times as people have added new properties and I'd like to get this pushed through while I've got it fairly up to date. Thanks.

          Show
          rchiang Ray Chiang added a comment - Akira Ajisaka , Tsuyoshi Ozawa , this is the HDFS equivalent of YARN-3069 . Let me know if either of you has the time and/or interest to review this. I've already had to update the patch several times as people have added new properties and I'd like to get this pushed through while I've got it fairly up to date. Thanks.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for the continuous work. I'll review it tomorrow.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for the continuous work. I'll review it tomorrow.
          Hide
          rchiang Ray Chiang added a comment -

          Great. Thanks!

          Show
          rchiang Ray Chiang added a comment - Great. Thanks!
          Hide
          ajisakaa Akira Ajisaka added a comment - - edited

          I reviewed the part before "dfs.client.failover.proxy.provider", and some comments from me.

          • The patch needs to be rebased.
          • Why "name" and "value" is after "description" in the following code?
            <property>
              <description>
                Maximum number of bytes that can be moved by the balancer in a single
                thread.
              </description>
              <name>dfs.balancer.max-size-to-move</name>
              <value>10737418240</value>
            </property>
            

            "dfs.client.retry.interval-ms.get-last-block-length" should be fixed as well.

          • Would you comment that the class specified by "dfs.block.placement.ec.classname" is for striped files and "dfs.block.replicator.classname" is not for striped files?
          Show
          ajisakaa Akira Ajisaka added a comment - - edited I reviewed the part before "dfs.client.failover.proxy.provider", and some comments from me. The patch needs to be rebased. Why "name" and "value" is after "description" in the following code? <property> <description> Maximum number of bytes that can be moved by the balancer in a single thread. </description> <name>dfs.balancer.max-size-to-move</name> <value>10737418240</value> </property> "dfs.client.retry.interval-ms.get-last-block-length" should be fixed as well. Would you comment that the class specified by "dfs.block.placement.ec.classname" is for striped files and "dfs.block.replicator.classname" is not for striped files?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Reviewed the part before "dfs.client.retry.interval-ms.get-last-block-length".

          1. In "dfs.client.failover.proxy.provider", "required hostname" should be "nameservice ID". I'm thinking the description should link to HDFS-HA document. The parameter is well-documented there.
          2. Would you add a description of "dfs.client.read.prefetch.size"? Now it shows only the default value.
          3. In "dfs.client.read.short.curcuit.replica.stale.threshold.ms" and "dfs.client.read.shortcircuit.buffer.size", "local read short circuit" should be "short-circuit local reads".
          4. Would you add a detailed comment for "dfs.client.replica.accessor.builder.classes", such as "Comma-separated classes for building ReplicaAccessor. If the classes are specified, client will use external BlockReader that uses the ReplicaAccessor built by the builder."?
          Show
          ajisakaa Akira Ajisaka added a comment - Reviewed the part before "dfs.client.retry.interval-ms.get-last-block-length". In "dfs.client.failover.proxy.provider", "required hostname" should be "nameservice ID". I'm thinking the description should link to HDFS-HA document. The parameter is well-documented there. Would you add a description of "dfs.client.read.prefetch.size"? Now it shows only the default value. In "dfs.client.read.short.curcuit.replica.stale.threshold.ms" and "dfs.client.read.shortcircuit.buffer.size", "local read short circuit" should be "short-circuit local reads". Would you add a detailed comment for "dfs.client.replica.accessor.builder.classes", such as "Comma-separated classes for building ReplicaAccessor. If the classes are specified, client will use external BlockReader that uses the ReplicaAccessor built by the builder."?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Reviewed from "dfs.client.retry.interval-ms.get-last-block-length" to "dfs.client.write.byte-array-manager.count-threshold".

          1. In "dfs.client.retry.window.base", the wait time is extended linearly, not exponentially.

          DFSInputStream.java
                    // Introducing a random factor to the wait time before another retry.
                    // The wait time is dependent on # of failures and a random factor.
                    // At the first time of getting a BlockMissingException, the wait time
                    // is a random number between 0..3000 ms. If the first retry
                    // still fails, we will wait 3000 ms grace period before the 2nd retry.
                    // Also at the second retry, the waiting window is expanded to 6000 ms
                    // alleviating the request rate from the server. Similarly the 3rd retry
                    // will wait 6000ms grace period before retry and the waiting window is
                    // expanded to 9000ms.
          

          In addition, would you add a time unit to the description?

          2. "dfs.client.hedged.threadpool.size" should be "dfs.client.hedged.read.threadpool.size", and "dfs.client.threshold.millis" should be "dfs.client.hedged.read.threshold.millis". (Please see HDFS-9886 for the detail.)

          Show
          ajisakaa Akira Ajisaka added a comment - Reviewed from "dfs.client.retry.interval-ms.get-last-block-length" to "dfs.client.write.byte-array-manager.count-threshold". 1. In "dfs.client.retry.window.base", the wait time is extended linearly, not exponentially. DFSInputStream.java // Introducing a random factor to the wait time before another retry. // The wait time is dependent on # of failures and a random factor. // At the first time of getting a BlockMissingException, the wait time // is a random number between 0..3000 ms. If the first retry // still fails, we will wait 3000 ms grace period before the 2nd retry. // Also at the second retry, the waiting window is expanded to 6000 ms // alleviating the request rate from the server. Similarly the 3rd retry // will wait 6000ms grace period before retry and the waiting window is // expanded to 9000ms. In addition, would you add a time unit to the description? 2. "dfs.client.hedged.threadpool.size" should be "dfs.client.hedged.read.threadpool.size", and "dfs.client.threshold.millis" should be "dfs.client.hedged.read.threshold.millis". (Please see HDFS-9886 for the detail.)
          Hide
          rchiang Ray Chiang added a comment -
          • Implement all of Akira Ajisaka's feedback
          • Add dfs.blockreport.incremental.intervalMsec property from HDFS-9710
          • Add dfs.namenode.edits.asynclogging from HDFS-7964
          • Remove waivers for dfs.client.failover.* properties due to HDFS-8084 making them accessible
          Show
          rchiang Ray Chiang added a comment - Implement all of Akira Ajisaka 's feedback Add dfs.blockreport.incremental.intervalMsec property from HDFS-9710 Add dfs.namenode.edits.asynclogging from HDFS-7964 Remove waivers for dfs.client.failover.* properties due to HDFS-8084 making them accessible
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for all the feedback so far Akira Ajisaka. I've caught up on all the issues you've found so far, plus a few more that have since gotten added to trunk.

          Show
          rchiang Ray Chiang added a comment - Thanks for all the feedback so far Akira Ajisaka . I've caught up on all the issues you've found so far, plus a few more that have since gotten added to trunk.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 6s trunk passed
          +1 compile 0m 41s trunk passed with JDK v1.8.0_74
          +1 compile 0m 41s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 59s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 51s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_74
          +1 javac 0m 36s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_95
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 48s the patch passed with JDK v1.7.0_95
          -1 unit 70m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 72m 25s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          168m 52s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791515/HDFS-8356.006.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 328697275adc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3e8099a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14719/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14719/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14719/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14719/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 6s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_74 +1 compile 0m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 51s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 48s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_74 +1 javac 0m 36s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_95 -1 unit 70m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 72m 25s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 168m 52s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791515/HDFS-8356.006.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 328697275adc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3e8099a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14719/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14719/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14719/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14719/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing JDK8 unit test

          Unit test passes in my tree

          Show
          rchiang Ray Chiang added a comment - RE: Failing JDK8 unit test Unit test passes in my tree
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you Ray Chiang for the update! Reviewed to "dfs.datanode.min.supported.namenode.version".

          1. Duplicate "during" in the description of "dfs.client.read.prefetch.size".
          2. In "dfs.client.read.short.curcuit.replica.stale.threshold.ms", "local read short circuit" should be "short-circuit local reads".
          3. Would you make the order of "name", "value", "description" consistent?
          4. In "dfs.data.transfer.client.tcpnodelay", the parameter affects only when creating sockets for write pipeline, so it's better to write as "If true, set TCP_NODELAY to sockets for transferring data from DFS client."
          5. Would you document that "dfs.datanode.balance.max.concurrent.moves" is reconfigurable via dfsadmin -reconfig command?
          6. "dfs.datanode.duplicate.replica.deletion" is for testing only, so would you remove it from hdfs-default.xml?
          7. In "dfs.datanode.fsdataset.volume.choosing.policy", would you mention that "If you would like to take into account available disk space, set the value to "org.apache.hadoop.hdfs.server.datanode.fsdataset.AvailableSpaceVolumeChoosingPolicy"."?
          8. Would you remove "dfs.datanode.kerberos.principal" and "dfs.datanode.keytab.file", which are already documented?
          Show
          ajisakaa Akira Ajisaka added a comment - Thank you Ray Chiang for the update! Reviewed to "dfs.datanode.min.supported.namenode.version". Duplicate "during" in the description of "dfs.client.read.prefetch.size". In "dfs.client.read.short.curcuit.replica.stale.threshold.ms", "local read short circuit" should be "short-circuit local reads". Would you make the order of "name", "value", "description" consistent? In "dfs.data.transfer.client.tcpnodelay", the parameter affects only when creating sockets for write pipeline, so it's better to write as "If true, set TCP_NODELAY to sockets for transferring data from DFS client." Would you document that "dfs.datanode.balance.max.concurrent.moves" is reconfigurable via dfsadmin -reconfig command? "dfs.datanode.duplicate.replica.deletion" is for testing only, so would you remove it from hdfs-default.xml? In "dfs.datanode.fsdataset.volume.choosing.policy", would you mention that "If you would like to take into account available disk space, set the value to "org.apache.hadoop.hdfs.server.datanode.fsdataset.AvailableSpaceVolumeChoosingPolicy"."? Would you remove "dfs.datanode.kerberos.principal" and "dfs.datanode.keytab.file", which are already documented?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Reviewed to "dfs.ha.fencing.methods".

          1. "dfs.datanode.min.supported.namenode.version" and "dfs.datanode.startup" are not supposed to be configured by users, so we can remove them from hdfs-default.xml.
          2. In "dfs.datanode.oob.timeout-ms", we should document that OOB types are OOB_RESTART, OOB_RESERVED1, OOB_RESERVED2, and OOB_RESERVED3, and now only OOB_RESTART is used.
          3. In "dfs.datanode.parallel.volumes.load.threads.num", would you document that the default value is the number of storages in the DataNode?
          4. In "dfs.datanode.socket.write.timeout", we should document that the parameter is valid for DataNodes, not for DFSClient.
          5. Would you document that "dfs.datanode.sync.behind.writes.in.background" is valid only when "dfs.datanode.sync.behind.writes" is set to true?
          6. In "dfs.datanode.transferTo.allowed", I'm thinking "If true" should be "If false".
          7. Would you remove unnecessarily whitespace in "m achine" in the description of "dfs.datanode.transferTo.allowed"?
          8. In "dfs.ha.fencing.methods", we can document that
            the parameter is well-documented in HDFS-HA doc, as well as "dfs.client.failover.proxy.provider".
          Show
          ajisakaa Akira Ajisaka added a comment - Reviewed to "dfs.ha.fencing.methods". "dfs.datanode.min.supported.namenode.version" and "dfs.datanode.startup" are not supposed to be configured by users, so we can remove them from hdfs-default.xml. In "dfs.datanode.oob.timeout-ms", we should document that OOB types are OOB_RESTART, OOB_RESERVED1, OOB_RESERVED2, and OOB_RESERVED3, and now only OOB_RESTART is used. In "dfs.datanode.parallel.volumes.load.threads.num", would you document that the default value is the number of storages in the DataNode? In "dfs.datanode.socket.write.timeout", we should document that the parameter is valid for DataNodes, not for DFSClient. Would you document that "dfs.datanode.sync.behind.writes.in.background" is valid only when "dfs.datanode.sync.behind.writes" is set to true? In "dfs.datanode.transferTo.allowed", I'm thinking "If true" should be "If false". Would you remove unnecessarily whitespace in "m achine" in the description of "dfs.datanode.transferTo.allowed"? In "dfs.ha.fencing.methods", we can document that the parameter is well-documented in HDFS-HA doc, as well as "dfs.client.failover.proxy.provider".
          Hide
          rchiang Ray Chiang added a comment -
          • Fixes based on latest feedback from Akira.
          Show
          rchiang Ray Chiang added a comment - Fixes based on latest feedback from Akira.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for updating the patch! Reviewed to "dfs.namenode.name.cache.threshold".

          1. Would you document that "dfs.namenode.available-space-block-placement-policy.balanced-space-preference-fraction" is valid only if "dfs.block.replicator.classname" is set to "org.apache.hadoop.hdfs.server.blockmanagement.AvailableSpaceBlockPlacementPolicy"?
          2. I'm thinking "dfs.namenode.edits.dir.minimum" is the minimum number of edits dirs which have sufficient resources for the NameNode to continue operation. Please see NameNodeResourcePolicy.java for the detail.
          3. In "dfs.namenode.edits.dir.required", the description in HDFS-3677 patch is better, so I'll commit this. Would you remove the parameter from the patch?
          4. "dfs.namenode.kerberos.principal" and "dfs.namenode.keytab.file" can be removed from the patch because they are already documented.
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for updating the patch! Reviewed to "dfs.namenode.name.cache.threshold". Would you document that "dfs.namenode.available-space-block-placement-policy.balanced-space-preference-fraction" is valid only if "dfs.block.replicator.classname" is set to "org.apache.hadoop.hdfs.server.blockmanagement.AvailableSpaceBlockPlacementPolicy"? I'm thinking "dfs.namenode.edits.dir.minimum" is the minimum number of edits dirs which have sufficient resources for the NameNode to continue operation. Please see NameNodeResourcePolicy.java for the detail. In "dfs.namenode.edits.dir.required", the description in HDFS-3677 patch is better, so I'll commit this. Would you remove the parameter from the patch? "dfs.namenode.kerberos.principal" and "dfs.namenode.keytab.file" can be removed from the patch because they are already documented.
          Hide
          rchiang Ray Chiang added a comment -
          • Updated with latest feedback.
          Show
          rchiang Ray Chiang added a comment - Updated with latest feedback.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 56s trunk passed
          +1 compile 0m 43s trunk passed with JDK v1.8.0_74
          +1 compile 0m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 40s the patch passed with JDK v1.8.0_74
          +1 javac 0m 40s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_95
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 19s the patch passed
          +1 javadoc 1m 7s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_95
          -1 unit 73m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 80m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          179m 40s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
            org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795441/HDFS-8356.008.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 4b99d69d28b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2c268cc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14943/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14943/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 56s trunk passed +1 compile 0m 43s trunk passed with JDK v1.8.0_74 +1 compile 0m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 40s the patch passed with JDK v1.8.0_74 +1 javac 0m 40s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 19s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_95 -1 unit 73m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 80m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 179m 40s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795441/HDFS-8356.008.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 4b99d69d28b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c268cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14943/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14943/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing JDK8 unit tests

          All tests pass in my tree

          RE: Failing JDK7 unit tests

          TestFsDatasetImpl passes in my tree
          TestDirectoryScanner fails with the same error in my tree without the patch

          Show
          rchiang Ray Chiang added a comment - RE: Failing JDK8 unit tests All tests pass in my tree RE: Failing JDK7 unit tests TestFsDatasetImpl passes in my tree TestDirectoryScanner fails with the same error in my tree without the patch
          Hide
          rchiang Ray Chiang added a comment -
          • Fix phrasing for dfs.namenode.edits.dir.minimum
          Show
          rchiang Ray Chiang added a comment - Fix phrasing for dfs.namenode.edits.dir.minimum
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 37s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_74
          +1 compile 0m 41s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_74
          +1 javac 0m 35s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_95
          +1 javac 0m 38s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
          -1 unit 72m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 70m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
          167m 57s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795487/HDFS-8356.009.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 6b06aa6ee087 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fde8ac5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14945/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14945/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 37s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_74 +1 compile 0m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_74 +1 javac 0m 35s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 72m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 70m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 167m 57s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795487/HDFS-8356.009.patch JIRA Issue HDFS-8356 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 6b06aa6ee087 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fde8ac5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14945/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14945/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14945/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for updating the patch! Finally I've reviewed all the parameters. Some additional comments:

          1. In dfs.namenode.replication.pending.timeout-sec, would you document that the timeout is 5 minutes if the value is set to 0 or negative value. Please see PendingReplicationBlocks.java for the detail.
          2. In dfs.namenode.stale.datanode.minimum.interval, the parameter is used for calculating the interval for marking datanode stale. The interval is calculated by (dfs.namenode.stale.datanode.minimum.interval) * (dfs.heartbeat.interval) sec. If the interval is larger than "dfs.namenode.stale.datanode.interval", the calculated value is used for the interval. Please see DatanodeManager#getStaleIntervalFromConf for the detail.
          3. "dfs.datanode.startup" is not supposed to be configured by users, so we can remove it from hdfs-default.xml, as well as "dfs.namenode.startup".
          4. Would you remove "dfs.web.authentication.kerberos.keytab" and "dfs.web.authentication.kerberos.principal" from the patch because they are already documented?
          5. Would you add "dfs.web.ugi" to DeprecatedProperties.md instead of adding it to hdfs-default.xml?
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for updating the patch! Finally I've reviewed all the parameters. Some additional comments: In dfs.namenode.replication.pending.timeout-sec, would you document that the timeout is 5 minutes if the value is set to 0 or negative value. Please see PendingReplicationBlocks.java for the detail. In dfs.namenode.stale.datanode.minimum.interval, the parameter is used for calculating the interval for marking datanode stale. The interval is calculated by (dfs.namenode.stale.datanode.minimum.interval) * (dfs.heartbeat.interval) sec. If the interval is larger than "dfs.namenode.stale.datanode.interval", the calculated value is used for the interval. Please see DatanodeManager#getStaleIntervalFromConf for the detail. "dfs.datanode.startup" is not supposed to be configured by users, so we can remove it from hdfs-default.xml, as well as "dfs.namenode.startup". Would you remove "dfs.web.authentication.kerberos.keytab" and "dfs.web.authentication.kerberos.principal" from the patch because they are already documented? Would you add "dfs.web.ugi" to DeprecatedProperties.md instead of adding it to hdfs-default.xml?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          In dfs.namenode.replication.pending.timeout-sec, would you document that the timeout is 5 minutes if the value is set to 0 or negative value. Please see PendingReplicationBlocks.java for the detail.

          Filed HDFS-10219 for changing the default value from -1 to 300.

          Show
          ajisakaa Akira Ajisaka added a comment - In dfs.namenode.replication.pending.timeout-sec, would you document that the timeout is 5 minutes if the value is set to 0 or negative value. Please see PendingReplicationBlocks.java for the detail. Filed HDFS-10219 for changing the default value from -1 to 300.
          Hide
          rchiang Ray Chiang added a comment -
          • Updated with latest feedback.
          Show
          rchiang Ray Chiang added a comment - Updated with latest feedback.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 6m 1s trunk passed with JDK v1.8.0_77
          +1 compile 6m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 47s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 29s trunk passed
          +1 javadoc 2m 0s trunk passed with JDK v1.8.0_77
          +1 javadoc 2m 48s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 26s the patch passed
          +1 compile 5m 59s the patch passed with JDK v1.8.0_77
          +1 javac 5m 59s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.7.0_95
          +1 javac 6m 38s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 58s the patch passed
          +1 javadoc 1m 56s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 46s the patch passed with JDK v1.7.0_95
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 56m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 27s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 54m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 26s Patch generated 3 ASF License warnings.
          184m 48s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795732/HDFS-8356.010.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux d56ea1227287 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 948b758
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14966/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14966/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 6m 1s trunk passed with JDK v1.8.0_77 +1 compile 6m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 2m 0s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 48s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed +1 compile 5m 59s the patch passed with JDK v1.8.0_77 +1 javac 5m 59s the patch passed +1 compile 6m 38s the patch passed with JDK v1.7.0_95 +1 javac 6m 38s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 27s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 56s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 46s the patch passed with JDK v1.7.0_95 -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 56m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 7m 27s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 54m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 26s Patch generated 3 ASF License warnings. 184m 48s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.balancer.TestBalancer   hadoop.cli.TestHDFSCLI   hadoop.hdfs.shortcircuit.TestShortCircuitCache JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795732/HDFS-8356.010.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux d56ea1227287 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 948b758 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14966/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14966/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14966/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Clean up whitespace and see how a test re-run looks
          Show
          rchiang Ray Chiang added a comment - Clean up whitespace and see how a test re-run looks
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 6m 59s trunk passed with JDK v1.8.0_74
          +1 compile 6m 53s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 27s trunk passed
          +1 javadoc 2m 2s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 54s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 6m 23s the patch passed with JDK v1.8.0_74
          +1 javac 6m 23s the patch passed
          +1 compile 7m 9s the patch passed with JDK v1.7.0_95
          +1 javac 7m 9s the patch passed
          +1 checkstyle 1m 4s the patch passed
          +1 mvnsite 1m 50s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 59s the patch passed
          +1 javadoc 2m 2s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 48s the patch passed with JDK v1.7.0_95
          -1 unit 21m 11s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 63m 51s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 57m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 24s Patch generated 3 ASF License warnings.
          211m 14s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
            org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795778/HDFS-8356.011.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux 1893c05c3ff3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8018280
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14977/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14977/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 6m 59s trunk passed with JDK v1.8.0_74 +1 compile 6m 53s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 27s trunk passed +1 javadoc 2m 2s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 54s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 6m 23s the patch passed with JDK v1.8.0_74 +1 javac 6m 23s the patch passed +1 compile 7m 9s the patch passed with JDK v1.7.0_95 +1 javac 7m 9s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 59s the patch passed +1 javadoc 2m 2s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 48s the patch passed with JDK v1.7.0_95 -1 unit 21m 11s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 63m 51s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 57m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 24s Patch generated 3 ASF License warnings. 211m 14s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker   org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.cli.TestHDFSCLI JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795778/HDFS-8356.011.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux 1893c05c3ff3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8018280 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14977/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14977/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14977/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: failing unit tests

          TestHDFSCLI is HDFS-10228
          TestNativeLibraryChecker is HADOOP-12955
          TestHFlush is HDFS-2043

          All other tests pass in my tree

          Show
          rchiang Ray Chiang added a comment - RE: failing unit tests TestHDFSCLI is HDFS-10228 TestNativeLibraryChecker is HADOOP-12955 TestHFlush is HDFS-2043 All other tests pass in my tree
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for the update. One comment from me.

          • In dfs.namenode.replication.pending.timeout-sec, I'm thinking the timeout is not capped at 300 seconds.
                      if (now > pendingBlock.getTimeStamp() + timeout) {
                        BlockInfo block = entry.getKey();
                        synchronized (timedOutItems) {
                          timedOutItems.add(block);
                        }
            

            The interval between scans is capped.

                    long period = Math.min(DEFAULT_RECHECK_INTERVAL, timeout);
                    try {
                      pendingReplicationCheck();
                      Thread.sleep(period);
            
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for the update. One comment from me. In dfs.namenode.replication.pending.timeout-sec, I'm thinking the timeout is not capped at 300 seconds. if (now > pendingBlock.getTimeStamp() + timeout) { BlockInfo block = entry.getKey(); synchronized (timedOutItems) { timedOutItems.add(block); } The interval between scans is capped. long period = Math .min(DEFAULT_RECHECK_INTERVAL, timeout); try { pendingReplicationCheck(); Thread .sleep(period);
          Hide
          rchiang Ray Chiang added a comment -
          • Remove comment about capping dfs.namenode.replication.pending.timeout-sec
          Show
          rchiang Ray Chiang added a comment - Remove comment about capping dfs.namenode.replication.pending.timeout-sec
          Hide
          rchiang Ray Chiang added a comment -

          Thanks Akira Ajisaka. I removed the extra comment.

          Show
          rchiang Ray Chiang added a comment - Thanks Akira Ajisaka . I removed the extra comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 27s Maven dependency ordering for branch
          +1 mvninstall 11m 2s trunk passed
          +1 compile 15m 0s trunk passed with JDK v1.8.0_74
          +1 compile 11m 39s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 32s trunk passed
          +1 mvnsite 3m 1s trunk passed
          +1 mvneclipse 0m 48s trunk passed
          +1 findbugs 5m 28s trunk passed
          +1 javadoc 3m 48s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 55s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 24s Maven dependency ordering for patch
          +1 mvninstall 2m 28s the patch passed
          +1 compile 15m 49s the patch passed with JDK v1.8.0_74
          +1 javac 15m 49s the patch passed
          +1 compile 11m 57s the patch passed with JDK v1.7.0_95
          +1 javac 11m 57s the patch passed
          +1 checkstyle 1m 38s the patch passed
          +1 mvnsite 2m 58s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 6m 7s the patch passed
          +1 javadoc 3m 50s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 57s the patch passed with JDK v1.7.0_95
          -1 unit 13m 21s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 139m 31s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 12m 17s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 96m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 42s Patch generated 2 ASF License warnings.
          373m 49s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestName
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.TestRefreshCallQueue
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestName
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.TestRefreshCallQueue
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796402/HDFS-8356.012.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux 939b0d2e1043 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7a02147
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15028/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15028/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 11m 2s trunk passed +1 compile 15m 0s trunk passed with JDK v1.8.0_74 +1 compile 11m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 32s trunk passed +1 mvnsite 3m 1s trunk passed +1 mvneclipse 0m 48s trunk passed +1 findbugs 5m 28s trunk passed +1 javadoc 3m 48s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 55s trunk passed with JDK v1.7.0_95 0 mvndep 0m 24s Maven dependency ordering for patch +1 mvninstall 2m 28s the patch passed +1 compile 15m 49s the patch passed with JDK v1.8.0_74 +1 javac 15m 49s the patch passed +1 compile 11m 57s the patch passed with JDK v1.7.0_95 +1 javac 11m 57s the patch passed +1 checkstyle 1m 38s the patch passed +1 mvnsite 2m 58s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 6m 7s the patch passed +1 javadoc 3m 50s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 57s the patch passed with JDK v1.7.0_95 -1 unit 13m 21s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 139m 31s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 12m 17s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 96m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 42s Patch generated 2 ASF License warnings. 373m 49s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestName   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.TestRefreshCallQueue   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestName   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.TestRefreshCallQueue   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796402/HDFS-8356.012.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux 939b0d2e1043 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7a02147 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15028/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15028/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15028/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for the update. Review comments for TestHdfsConfigFields.java:

              // Remove new property for now
              xmlPropsToSkipCompare.add("dfs.client.hedged.threadpool.size");
          

          1. Would you remove the above code because HDFS-9886 has been fixed?

              // Remove support property
              xmlPropsToSkipCompare
                  .add(DFSConfigKeys.DFS_NAMENODE_MIN_SUPPORTED_DATANODE_VERSION_KEY);
              xmlPropsToSkipCompare
                  .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY);
          

          2. I'm thinking we can remove the above because the parameters don't exist in hdfs-default.xml.

              configurationPropsToSkipCompare
                  .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY);
          

          3. Duplicate.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for the update. Review comments for TestHdfsConfigFields.java: // Remove new property for now xmlPropsToSkipCompare.add( "dfs.client.hedged.threadpool.size" ); 1. Would you remove the above code because HDFS-9886 has been fixed? // Remove support property xmlPropsToSkipCompare .add(DFSConfigKeys.DFS_NAMENODE_MIN_SUPPORTED_DATANODE_VERSION_KEY); xmlPropsToSkipCompare .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY); 2. I'm thinking we can remove the above because the parameters don't exist in hdfs-default.xml. configurationPropsToSkipCompare .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY); 3. Duplicate.
          Hide
          rchiang Ray Chiang added a comment -
          • Handle feedback on TestHdfsConfigFields.java
          Show
          rchiang Ray Chiang added a comment - Handle feedback on TestHdfsConfigFields.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 9m 53s trunk passed
          +1 compile 11m 48s trunk passed with JDK v1.8.0_74
          +1 compile 10m 13s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 25s trunk passed
          +1 mvnsite 2m 31s trunk passed
          +1 mvneclipse 0m 39s trunk passed
          +1 findbugs 4m 32s trunk passed
          +1 javadoc 3m 1s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 22s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 21s Maven dependency ordering for patch
          +1 mvninstall 2m 5s the patch passed
          +1 compile 11m 47s the patch passed with JDK v1.8.0_74
          +1 javac 11m 47s the patch passed
          +1 compile 10m 22s the patch passed with JDK v1.7.0_95
          +1 javac 10m 22s the patch passed
          +1 checkstyle 1m 27s the patch passed
          +1 mvnsite 2m 33s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 15s the patch passed
          +1 javadoc 3m 1s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 12s the patch passed with JDK v1.7.0_95
          -1 unit 10m 40s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 76m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 11m 16s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 91m 56s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 40s Patch does not generate ASF License warnings.
          283m 44s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestPrint0
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.TestFileAppend3
            org.apache.hadoop.hdfs.server.balancer.TestBalancer
            org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
            org.apache.hadoop.hdfs.TestFileConcurrentReader
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.TestRefreshCallQueue
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796568/HDFS-8356.013.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux 67f5c3f935d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 256c82f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15040/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15040/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 9m 53s trunk passed +1 compile 11m 48s trunk passed with JDK v1.8.0_74 +1 compile 10m 13s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 25s trunk passed +1 mvnsite 2m 31s trunk passed +1 mvneclipse 0m 39s trunk passed +1 findbugs 4m 32s trunk passed +1 javadoc 3m 1s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 22s trunk passed with JDK v1.7.0_95 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 2m 5s the patch passed +1 compile 11m 47s the patch passed with JDK v1.8.0_74 +1 javac 11m 47s the patch passed +1 compile 10m 22s the patch passed with JDK v1.7.0_95 +1 javac 10m 22s the patch passed +1 checkstyle 1m 27s the patch passed +1 mvnsite 2m 33s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 15s the patch passed +1 javadoc 3m 1s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 12s the patch passed with JDK v1.7.0_95 -1 unit 10m 40s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 76m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 11m 16s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 91m 56s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 40s Patch does not generate ASF License warnings. 283m 44s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestPrint0   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.TestFileAppend3   org.apache.hadoop.hdfs.server.balancer.TestBalancer   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding   org.apache.hadoop.hdfs.TestFileConcurrentReader JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.TestRefreshCallQueue   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796568/HDFS-8356.013.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux 67f5c3f935d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 256c82f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15040/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15040/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang for the update! Additional comments:

              // Fully deprecated properties?
              configurationPropsToSkipCompare
                  .add("dfs.client.file-block-storage-locations.num-threads");
              configurationPropsToSkipCompare
                  .add("dfs.client.file-block-storage-locations.timeout.millis");
          (snip)
              configurationPropsToSkipCompare
                  .add("dfs.namenode.replication.max-streams-hard-limit");
          

          1. These properties are not deprecated. They should be documented, or commented as TODO: document these properties.

              configurationPropsToSkipCompare
                  .add("dfs.namenode.hosts");
              configurationPropsToSkipCompare
                  .add("dfs.namenode.hosts.exclude");
          

          2. These properties can be removed.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang for the update! Additional comments: // Fully deprecated properties? configurationPropsToSkipCompare .add( "dfs.client.file-block-storage-locations.num-threads" ); configurationPropsToSkipCompare .add( "dfs.client.file-block-storage-locations.timeout.millis" ); (snip) configurationPropsToSkipCompare .add( "dfs.namenode.replication.max-streams-hard-limit" ); 1. These properties are not deprecated. They should be documented, or commented as TODO: document these properties . configurationPropsToSkipCompare .add( "dfs.namenode.hosts" ); configurationPropsToSkipCompare .add( "dfs.namenode.hosts.exclude" ); 2. These properties can be removed.
          Hide
          rchiang Ray Chiang added a comment -

          Akira Ajisaka, for 1. above, I don't see these properties referenced anywhere other than DfsConfigKeys/HdfsClientConfigKeys

          dfs.client.file-block-storage-locations.num-threads / DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_NUM_THREADS

          dfs.client.file-block-storage-locations.timeout.millis / dfs.client.file-block-storage-locations.timeout /
          DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_TIMEOUT_MS

          I do see:

          dfs.namenode.replication.max-streams-hard-limit / DFS_NAMENODE_REPLICATION_STREAMS_HARD_LIMIT_KEY

          being used now though.

          Show
          rchiang Ray Chiang added a comment - Akira Ajisaka , for 1. above, I don't see these properties referenced anywhere other than DfsConfigKeys/HdfsClientConfigKeys dfs.client.file-block-storage-locations.num-threads / DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_NUM_THREADS dfs.client.file-block-storage-locations.timeout.millis / dfs.client.file-block-storage-locations.timeout / DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_TIMEOUT_MS I do see: dfs.namenode.replication.max-streams-hard-limit / DFS_NAMENODE_REPLICATION_STREAMS_HARD_LIMIT_KEY being used now though.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang.

          I don't see these properties referenced anywhere other than DfsConfigKeys/HdfsClientConfigKeys

          Sorry, you are right. These properties are not used.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang . I don't see these properties referenced anywhere other than DfsConfigKeys/HdfsClientConfigKeys Sorry, you are right. These properties are not used.
          Hide
          rchiang Ray Chiang added a comment -
          • Add property dfs.namenode.replication.max-streams-hard-limit to hdfs-default.xml
          Show
          rchiang Ray Chiang added a comment - Add property dfs.namenode.replication.max-streams-hard-limit to hdfs-default.xml
          Hide
          rchiang Ray Chiang added a comment -

          Filed HDFS-10266 as a follow up.

          Show
          rchiang Ray Chiang added a comment - Filed HDFS-10266 as a follow up.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 6m 46s trunk passed
          +1 compile 5m 46s trunk passed with JDK v1.8.0_77
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 1m 52s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 31s trunk passed
          +1 javadoc 2m 5s trunk passed with JDK v1.8.0_77
          +1 javadoc 2m 58s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 6m 7s the patch passed with JDK v1.8.0_77
          +1 javac 6m 7s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.7.0_95
          +1 javac 6m 38s the patch passed
          +1 checkstyle 1m 5s the patch passed
          +1 mvnsite 1m 49s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 3s the patch passed
          +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 55s the patch passed with JDK v1.7.0_95
          -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 58m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 14s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 54m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          189m 22s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.TestDataNodeLifeline



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797334/HDFS-8356.014.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux 852a709faf1e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de96d7c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15093/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15093/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 6m 46s trunk passed +1 compile 5m 46s trunk passed with JDK v1.8.0_77 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 2m 5s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 58s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 6m 7s the patch passed with JDK v1.8.0_77 +1 javac 6m 7s the patch passed +1 compile 6m 38s the patch passed with JDK v1.7.0_95 +1 javac 6m 38s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 3s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 55s the patch passed with JDK v1.7.0_95 -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 58m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 7m 14s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 54m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 189m 22s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestDataNodeLifeline Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797334/HDFS-8356.014.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux 852a709faf1e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de96d7c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15093/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15093/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15093/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: failing unit tests

          TestHFlush is HDFS-2043

          All other tests pass in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: failing unit tests TestHFlush is HDFS-2043 All other tests pass in my tree.
          Hide
          rchiang Ray Chiang added a comment -

          After some discussion on HDFS-10266, it looks like those two properties can be removed in trunk, but still exists in branch-2. I'll work on a branch-2 patch.

          Show
          rchiang Ray Chiang added a comment - After some discussion on HDFS-10266 , it looks like those two properties can be removed in trunk, but still exists in branch-2. I'll work on a branch-2 patch.
          Hide
          rchiang Ray Chiang added a comment -

          branch-2 version:

          • Add back some properties that are branch-2 only
          • Remove some properties that are trunk only
          • Add one more property to DeprecatedProperties.md
          Show
          rchiang Ray Chiang added a comment - branch-2 version: Add back some properties that are branch-2 only Remove some properties that are trunk only Add one more property to DeprecatedProperties.md
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 56s Maven dependency ordering for branch
          +1 mvninstall 6m 15s branch-2 passed
          +1 compile 5m 11s branch-2 passed with JDK v1.8.0_77
          +1 compile 6m 3s branch-2 passed with JDK v1.7.0_95
          +1 checkstyle 1m 1s branch-2 passed
          +1 mvnsite 1m 46s branch-2 passed
          +1 mvneclipse 0m 28s branch-2 passed
          -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
          +1 javadoc 1m 55s branch-2 passed with JDK v1.8.0_77
          +1 javadoc 2m 45s branch-2 passed with JDK v1.7.0_95
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 24s the patch passed
          +1 compile 5m 5s the patch passed with JDK v1.8.0_77
          +1 javac 5m 5s the patch passed
          +1 compile 6m 3s the patch passed with JDK v1.7.0_95
          +1 javac 6m 3s the patch passed
          +1 checkstyle 1m 1s the patch passed
          +1 mvnsite 1m 45s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 56s the patch passed
          +1 javadoc 1m 52s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 47s the patch passed with JDK v1.7.0_95
          -1 unit 21m 3s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 49m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 46m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          180m 47s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestFileAppend
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797604/HDFS-8356.014.branch-2.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux eb17d7e02a19 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 46352de
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15106/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15106/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 56s Maven dependency ordering for branch +1 mvninstall 6m 15s branch-2 passed +1 compile 5m 11s branch-2 passed with JDK v1.8.0_77 +1 compile 6m 3s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 1m 1s branch-2 passed +1 mvnsite 1m 46s branch-2 passed +1 mvneclipse 0m 28s branch-2 passed -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 55s branch-2 passed with JDK v1.8.0_77 +1 javadoc 2m 45s branch-2 passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 5m 5s the patch passed with JDK v1.8.0_77 +1 javac 5m 5s the patch passed +1 compile 6m 3s the patch passed with JDK v1.7.0_95 +1 javac 6m 3s the patch passed +1 checkstyle 1m 1s the patch passed +1 mvnsite 1m 45s the patch passed +1 mvneclipse 0m 27s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 52s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 47s the patch passed with JDK v1.7.0_95 -1 unit 21m 3s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 49m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 46m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 180m 47s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestFileAppend JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797604/HDFS-8356.014.branch-2.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux eb17d7e02a19 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 46352de Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15106/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15106/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15106/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for the update. Hi Ray Chiang, given HDFS-10266 is committed, would you update the patch for trunk?

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for the update. Hi Ray Chiang , given HDFS-10266 is committed, would you update the patch for trunk?
          Hide
          rchiang Ray Chiang added a comment -
          • Remove the property waivers from TestHdfsConfigFields due to HDFS-10266.
          Show
          rchiang Ray Chiang added a comment - Remove the property waivers from TestHdfsConfigFields due to HDFS-10266 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 54s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 6m 48s trunk passed with JDK v1.8.0_77
          +1 compile 6m 51s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 37s trunk passed
          +1 javadoc 2m 3s trunk passed with JDK v1.8.0_77
          +1 javadoc 2m 56s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 35s the patch passed
          +1 compile 6m 12s the patch passed with JDK v1.8.0_77
          +1 javac 6m 12s the patch passed
          +1 compile 6m 42s the patch passed with JDK v1.7.0_95
          +1 javac 6m 42s the patch passed
          +1 checkstyle 1m 6s the patch passed
          +1 mvnsite 1m 55s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 3s the patch passed
          +1 javadoc 1m 56s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 49s the patch passed with JDK v1.7.0_95
          -1 unit 20m 53s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 59m 16s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 57m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          207m 45s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.fs.contract.hdfs.TestHDFSContractSeek
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.fs.contract.hdfs.TestHDFSContractSeek
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797770/HDFS-8356.015.patch
          JIRA Issue HDFS-8356
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle
          uname Linux ba4cdee4c8ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 44bbc50
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15136/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15136/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 6m 48s trunk passed with JDK v1.8.0_77 +1 compile 6m 51s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 2m 3s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 56s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 6m 12s the patch passed with JDK v1.8.0_77 +1 javac 6m 12s the patch passed +1 compile 6m 42s the patch passed with JDK v1.7.0_95 +1 javac 6m 42s the patch passed +1 checkstyle 1m 6s the patch passed +1 mvnsite 1m 55s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 3s the patch passed +1 javadoc 1m 56s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 49s the patch passed with JDK v1.7.0_95 -1 unit 20m 53s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 59m 16s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 57m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 207m 45s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.fs.contract.hdfs.TestHDFSContractSeek JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797770/HDFS-8356.015.patch JIRA Issue HDFS-8356 Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml findbugs checkstyle uname Linux ba4cdee4c8ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44bbc50 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15136/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15136/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15136/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing unit tests

          All tests pass in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: Failing unit tests All tests pass in my tree.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing these patches.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing these patches.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9596 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9596/)
          HDFS-8356. Document missing properties in hdfs-default.xml. Contributed (aajisaka: rev 209303be3a4d038b420ae3c11230d419bba07575)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9596 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9596/ ) HDFS-8356 . Document missing properties in hdfs-default.xml. Contributed (aajisaka: rev 209303be3a4d038b420ae3c11230d419bba07575) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-common-project/hadoop-common/src/site/markdown/DeprecatedProperties.md
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed the patches to trunk and branch-2. Thanks Ray Chiang for the great work!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed the patches to trunk and branch-2. Thanks Ray Chiang for the great work!
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for doing the many iterations of reviews and commit Akira Ajisaka.

          Also, thanks to Xiao Chen, Wei-Chiu Chuang, John Zhuge, and Yongjun Zhang for helping me with a bunch of the property definitions.

          Show
          rchiang Ray Chiang added a comment - Thanks for doing the many iterations of reviews and commit Akira Ajisaka . Also, thanks to Xiao Chen , Wei-Chiu Chuang , John Zhuge , and Yongjun Zhang for helping me with a bunch of the property definitions.
          Hide
          yzhangal Yongjun Zhang added a comment -

          This is really great work Ray Chiang, congratulations!

          Many thanks to Akira Ajisaka for reviewing and committing!

          Show
          yzhangal Yongjun Zhang added a comment - This is really great work Ray Chiang , congratulations! Many thanks to Akira Ajisaka for reviewing and committing!

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development