Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7559

Create unit test to automatically compare HDFS related classes and hdfs-default.xml

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:

      Description

      Create a unit test that will automatically compare the fields in the various HDFS related classes and hdfs-default.xml. It should throw an error if a property is missing in either the class or the file.

      1. HDFS-7559.004.patch
        4 kB
        Ray Chiang
      2. HDFS-7559.003.patch
        3 kB
        Ray Chiang
      3. HDFS-7559.002.patch
        3 kB
        Ray Chiang
      4. HDFS-7559.001.patch
        3 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -

          HDFS-8371. The problem with these checks is chasing down every time someone adds a new property in one place and not the corresponding other place before the check gets committed. In this case, it looks like it all happened around the same time.

          Show
          rchiang Ray Chiang added a comment - HDFS-8371 . The problem with these checks is chasing down every time someone adds a new property in one place and not the corresponding other place before the check gets committed. In this case, it looks like it all happened around the same time.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Okay, the compilation problem is already fixed by HDFS-8362. But why the new test is failing in trunk?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Okay, the compilation problem is already fixed by HDFS-8362 . But why the new test is failing in trunk?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Hi, have you tried to run the new test yourself?

          Running org.apache.hadoop.hdfs.tools.TestHdfsConfigFields
          Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.673 sec <<< FAILURE! - in org.apache.hadoop.hdfs.tools.TestHdfsConfigFields
          testCompareXmlAgainstConfigurationClass(org.apache.hadoop.hdfs.tools.TestHdfsConfigFields)  Time elapsed: 0.526 sec  <<< FAILURE!
          java.lang.AssertionError: hdfs-default.xml has 2 properties missing in  class org.apache.hadoop.hdfs.DFSConfigKeys
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.junit.Assert.assertTrue(Assert.java:41)
          	at org.apache.hadoop.conf.TestConfigurationFieldsBase.testCompareXmlAgainstConfigurationClass(TestConfigurationFieldsBase.java:468)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
          	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
          	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
          	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
          	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
          	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
          	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
          	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
          	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
          	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
          	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
          	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
          
          Running org.apache.hadoop.tools.TestHdfsConfigFields
          Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.098 sec <<< FAILURE! - in org.apache.hadoop.tools.TestHdfsConfigFields
          testCompareXmlAgainstConfigurationClass(org.apache.hadoop.tools.TestHdfsConfigFields)  Time elapsed: 0.009 sec  <<< ERROR!
          java.lang.Error: Unresolved compilation problem: 
          	The declared package "org.apache.hadoop.hdfs.tools" does not match the expected package "org.apache.hadoop.tools"
          
          	at org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19)
          
          testCompareConfigurationClassAgainstXml(org.apache.hadoop.tools.TestHdfsConfigFields)  Time elapsed: 0 sec  <<< ERROR!
          java.lang.Error: Unresolved compilation problem: 
          	The declared package "org.apache.hadoop.hdfs.tools" does not match the expected package "org.apache.hadoop.tools"
          
          	at org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19)
          
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Hi, have you tried to run the new test yourself? Running org.apache.hadoop.hdfs.tools.TestHdfsConfigFields Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.673 sec <<< FAILURE! - in org.apache.hadoop.hdfs.tools.TestHdfsConfigFields testCompareXmlAgainstConfigurationClass(org.apache.hadoop.hdfs.tools.TestHdfsConfigFields) Time elapsed: 0.526 sec <<< FAILURE! java.lang.AssertionError: hdfs- default .xml has 2 properties missing in class org.apache.hadoop.hdfs.DFSConfigKeys at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.conf.TestConfigurationFieldsBase.testCompareXmlAgainstConfigurationClass(TestConfigurationFieldsBase.java:468) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) Running org.apache.hadoop.tools.TestHdfsConfigFields Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.098 sec <<< FAILURE! - in org.apache.hadoop.tools.TestHdfsConfigFields testCompareXmlAgainstConfigurationClass(org.apache.hadoop.tools.TestHdfsConfigFields) Time elapsed: 0.009 sec <<< ERROR! java.lang.Error: Unresolved compilation problem: The declared package "org.apache.hadoop.hdfs.tools" does not match the expected package "org.apache.hadoop.tools" at org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19) testCompareConfigurationClassAgainstXml(org.apache.hadoop.tools.TestHdfsConfigFields) Time elapsed: 0 sec <<< ERROR! java.lang.Error: Unresolved compilation problem: The declared package "org.apache.hadoop.hdfs.tools" does not match the expected package "org.apache.hadoop.tools" at org.apache.hadoop.tools.TestHdfsConfigFields.<init>(TestHdfsConfigFields.java:19)
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7777 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7777/)
          HDFS-7559. Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7777 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7777/ ) HDFS-7559 . Create unit test to automatically compare HDFS related classes and hdfs-default.xml. (Ray Chiang via asuresh) (Arun Suresh: rev 3cefc02af73faa12a6edce904b98ba543167bec5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          asuresh Arun Suresh added a comment -

          +1,
          Thanks for working on this Ray Chiang
          Committing this shortly to trunk and branch-2

          Show
          asuresh Arun Suresh added a comment - +1, Thanks for working on this Ray Chiang Committing this shortly to trunk and branch-2
          Hide
          rchiang Ray Chiang added a comment -

          Link to MAPREDUCE equivalent.

          Show
          rchiang Ray Chiang added a comment - Link to MAPREDUCE equivalent.
          Hide
          rchiang Ray Chiang added a comment -

          Link to YARN equivalent

          Show
          rchiang Ray Chiang added a comment - Link to YARN equivalent
          Hide
          rchiang Ray Chiang added a comment -

          Both failed tests pass in my tree.

          Show
          rchiang Ray Chiang added a comment - Both failed tests pass in my tree.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 7s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 4m 1s There were no new checkstyle issues.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 30s The patch built with eclipse:eclipse.
          +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 1m 19s Pre-build of native portion
          -1 hdfs tests 182m 56s Tests failed in hadoop-hdfs.
              206m 29s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728465/HDFS-7559.004.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 7f07c4d
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10415/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10415/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10415/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 4m 1s There were no new checkstyle issues. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 30s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 1m 19s Pre-build of native portion -1 hdfs tests 182m 56s Tests failed in hadoop-hdfs.     206m 29s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728465/HDFS-7559.004.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 7f07c4d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10415/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10415/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10415/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Update for the following properties:

          • dfs.webhdfs.enabled has been removed in trunk (but not branch-2)
          • dfs.client.short.circuit.replica.stale.threshold has moved to HdfsClientConfigKeys
          Show
          rchiang Ray Chiang added a comment - Update for the following properties: dfs.webhdfs.enabled has been removed in trunk (but not branch-2) dfs.client.short.circuit.replica.stale.threshold has moved to HdfsClientConfigKeys
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12699323/HDFS-7559.003.patch
          against trunk revision 13d1ba9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9604//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9604//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699323/HDFS-7559.003.patch against trunk revision 13d1ba9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9604//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9604//console This message is automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Add new property exception for dfs.namenode.kerberos.principal.pattern

          Show
          rchiang Ray Chiang added a comment - Add new property exception for dfs.namenode.kerberos.principal.pattern
          Hide
          rchiang Ray Chiang added a comment -

          RE: failing unit tests

          Both tests pass fine in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: failing unit tests Both tests pass fine in my tree.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12693504/HDFS-7559.002.patch
          against trunk revision 18741ad.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
          org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9352//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9352//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12693504/HDFS-7559.002.patch against trunk revision 18741ad. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9352//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9352//console This message is automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          HDFS-7566 committed. Submitting patch with .xml -> Java configuration properties testing turned on.

          Show
          rchiang Ray Chiang added a comment - HDFS-7566 committed. Submitting patch with .xml -> Java configuration properties testing turned on.
          Hide
          rchiang Ray Chiang added a comment -
          • Add two more Configuration properties to exceptions
          • Turn on flagging errors for now
          Show
          rchiang Ray Chiang added a comment - Add two more Configuration properties to exceptions Turn on flagging errors for now
          Hide
          rchiang Ray Chiang added a comment -

          Initial version. Doesn't flag any errors right now.

          Show
          rchiang Ray Chiang added a comment - Initial version. Doesn't flag any errors right now.

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development