[HDFS-8309] Skip unit test using DataNodeTestUtils#injectDataDirFailure() on Windows

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Xiaoyu Yao
• Reporter: Xiaoyu Yao
• Created: 01/May/15 22:56
• Updated: 09/Feb/17 13:56
• Resolved: 03/May/15 05:40

Description

As Chris Nauroth noted in HDFS-7917 below, DataNodeTestUtils.injectDataDirFailure() won't work for Windows as rename will fail due to open handles on data node dir. This ticket is opened to skip these tests for Windows.

Unfortunately, I just remembered that the rename isn't going to work on Windows. It typically doesn't allow you to rename a directory where there are open file handles anywhere in the sub-tree. We'd have to shutdown the DataNode before doing the rename and then start it up. By doing that, we'd be changing the meaning of the test from covering an online failure to covering a failure at DataNode startup, so I don't think we can make that change.

Below are the two test cases that need to be fixed:

1. TestDataNodeVolumeFailure#testFailedVolumeBeingRemovedFromDataNode
2. TestDataNodeHotSwapVolumes.testDirectlyReloadAfterCheckDiskError

Issue Links

• is duplicated by: HDFS-8599 Skip tests that call DataNodeTestUtils.injectDataDirFailure on Windows
• is related to: HDFS-11399 Many tests fails in Windows due to injecting disk failures