[HDFS-11399] Many tests fails in Windows due to injecting disk failures

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.3
• Labels: Windows
• Target Version/s: 3.1.0
• Hadoop Flags: Reviewed
• Assignee: Yiqun Lin
• Reporter: Yiqun Lin
• Created: 09/Feb/17 05:55
• Updated: 17/May/18 16:11
• Resolved: 12/Mar/18 19:56

Description

Found many tests run failed in Windows due to using DataNodeTestUtils#injectDataDirFailure. One of the failure test:

java.io.IOException: Failed to rename D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2 to D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2.origin.
	at org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils.injectDataDirFailure(DataNodeTestUtils.java:156)
	at org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean.testStorageTypeStatsWhenStorageFailed(TestBlockStatsMXBean.java:176)

The root cause of this is that the test method uses DataNodeTestUtils#injectDataDirFailure to injects disk failures but however missing the compare operation assumeNotWindows. Currently DataNodeTestUtils#injectDataDirFailure is not supported in Windows then the test fails.

It would be better to add assumeNotWindows into DataNodeTestUtils#injectDataDirFailure in case we forget to add this in test methods.

Issue Links

• relates to: HDFS-8309 Skip unit test using DataNodeTestUtils#injectDataDirFailure() on Windows