Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.3
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Found many tests run failed in Windows due to using DataNodeTestUtils#injectDataDirFailure. One of the failure test:

      java.io.IOException: Failed to rename D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2 to D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2.origin.
      	at org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils.injectDataDirFailure(DataNodeTestUtils.java:156)
      	at org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean.testStorageTypeStatsWhenStorageFailed(TestBlockStatsMXBean.java:176)
      

      The root cause of this is that the test method uses DataNodeTestUtils#injectDataDirFailure to injects disk failures but however missing the compare operation assumeNotWindows. Currently DataNodeTestUtils#injectDataDirFailure is not supported in Windows then the test fails.

      It would be better to add assumeNotWindows into DataNodeTestUtils#injectDataDirFailure in case we forget to add this in test methods.

        Attachments

        1. HDFS-11399-branch-2.000.patch
          5 kB
          Íñigo Goiri
        2. HDFS-11399.002.patch
          3 kB
          Yiqun Lin
        3. HDFS-11399.001.patch
          1 kB
          Yiqun Lin

          Issue Links

            Activity

              People

              • Assignee:
                linyiqun Yiqun Lin
                Reporter:
                linyiqun Yiqun Lin
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: