Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7922

ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      ShortCircuitCache has the following executors. It would be good to shutdown these pools during ShortCircuitCache#close to avoid leaks.

        /**
         * The executor service that runs the cacheCleaner.
         */
        private final ScheduledThreadPoolExecutor cleanerExecutor
        = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
                setDaemon(true).setNameFormat("ShortCircuitCache_Cleaner").
                build());
      
        /**
         * The executor service that runs the cacheCleaner.
         */
        private final ScheduledThreadPoolExecutor releaserExecutor
            = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
                setDaemon(true).setNameFormat("ShortCircuitCache_SlotReleaser").
                build());
      
      1. 001-HDFS-7922.patch
        1 kB
        Rakesh R
      2. 002-HDFS-7922.patch
        3 kB
        Rakesh R
      3. 003-HDFS-7922.patch
        3 kB
        Rakesh R
      4. 004-HDFS-7922.patch
        2 kB
        Rakesh R

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704228/001-HDFS-7922.patch
        against trunk revision 6dae6d1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache
        org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
        org.apache.hadoop.hdfs.TestAppendSnapshotTruncate
        org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704228/001-HDFS-7922.patch against trunk revision 6dae6d1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA org.apache.hadoop.hdfs.TestAppendSnapshotTruncate org.apache.hadoop.hdfs.server.namenode.TestFileTruncate The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//console This message is automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Note that this is never a problem in production, only in unit tests.

        Test failures looks related, did you get a chance to look at them?

        Show
        cmccabe Colin P. McCabe added a comment - Note that this is never a problem in production, only in unit tests. Test failures looks related, did you get a chance to look at them?
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Colin P. McCabe for the interest. Yes, TestShortCircuitCache#testExpiry failure is due to waiting for the cleanerExecutor#shutdown() completion. I've attached another patch which modifies the interval values.

        Show
        rakeshr Rakesh R added a comment - Thanks Colin P. McCabe for the interest. Yes, TestShortCircuitCache#testExpiry failure is due to waiting for the cleanerExecutor#shutdown() completion. I've attached another patch which modifies the interval values.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704669/002-HDFS-7922.patch
        against trunk revision bc9cb3e.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9888//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704669/002-HDFS-7922.patch against trunk revision bc9cb3e. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9888//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        This patch successfully compiles in my local env. Appreciate any help in resolving this issue. Thanks!

        Compiling /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build
        /home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests -DHadoopPatchProcess -Ptest-patch > /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/../patchprocess/trunkJavacWarnings.txt 2>&1
        Trunk compilation is broken?
        
        Show
        rakeshr Rakesh R added a comment - This patch successfully compiles in my local env. Appreciate any help in resolving this issue. Thanks! Compiling /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build /home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests -DHadoopPatchProcess -Ptest-patch > /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/../patchprocess/trunkJavacWarnings.txt 2>&1 Trunk compilation is broken?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704669/002-HDFS-7922.patch
        against trunk revision d884670.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
        org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9939//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9939//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704669/002-HDFS-7922.patch against trunk revision d884670. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9939//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9939//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        It looks like test case failures are unrelated to this patch. Colin P. McCabe could you please have a look at the new patch. Thanks!

        Show
        rakeshr Rakesh R added a comment - It looks like test case failures are unrelated to this patch. Colin P. McCabe could you please have a look at the new patch. Thanks!
        Hide
        cmccabe Colin P. McCabe added a comment -

        We need to do shutdown and awaitTermination after releasing the lock. There isn't any reason to hold the lock when doing these and if one of the executors is about to take the lock right before close does it, it would lead to deadlock and timeout.

        Show
        cmccabe Colin P. McCabe added a comment - We need to do shutdown and awaitTermination after releasing the lock. There isn't any reason to hold the lock when doing these and if one of the executors is about to take the lock right before close does it, it would lead to deadlock and timeout.
        Hide
        rakeshr Rakesh R added a comment -

        Yes, thats correct. I've moved the cleanup outside the lock and updated another patch. Please have a look at it when you get some time. Thanks!

        Show
        rakeshr Rakesh R added a comment - Yes, thats correct. I've moved the cleanup outside the lock and updated another patch. Please have a look at it when you get some time. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707974/003-HDFS-7922.patch
        against trunk revision 27d49e6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10100//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10100//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707974/003-HDFS-7922.patch against trunk revision 27d49e6. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10100//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10100//console This message is automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks for looking at this, Rakesh R.

        • You do not need to check the executors against null, since they are final members which are initialized when the object is constructed. They cannot be null.
        • I would put the calls to shutdown together before the calls to awaitTermination.
        • It looks like there is an existing bug where we try to join the CacheCleaner thread (which may require a lock to finish) while holding the lock ourselves. The fix is the same... we should join the cache cleaner thread once releasing the lock.
        • I don't see the need for a separate cleanup and close function. cleanup is only ever called by close and it does the same thing.
        Show
        cmccabe Colin P. McCabe added a comment - Thanks for looking at this, Rakesh R . You do not need to check the executors against null, since they are final members which are initialized when the object is constructed. They cannot be null. I would put the calls to shutdown together before the calls to awaitTermination . It looks like there is an existing bug where we try to join the CacheCleaner thread (which may require a lock to finish) while holding the lock ourselves. The fix is the same... we should join the cache cleaner thread once releasing the lock. I don't see the need for a separate cleanup and close function. cleanup is only ever called by close and it does the same thing.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks a lot Colin P. McCabe for the comments. I've updated another patch addressing the comments.

        It looks like there is an existing bug where we try to join the CacheCleaner thread (which may require a lock to finish) while holding the lock ourselves. The fix is the same... we should join the cache cleaner thread once releasing the lock.

        Thanks again for identifying this case during reviews.

        Show
        rakeshr Rakesh R added a comment - Thanks a lot Colin P. McCabe for the comments. I've updated another patch addressing the comments. It looks like there is an existing bug where we try to join the CacheCleaner thread (which may require a lock to finish) while holding the lock ourselves. The fix is the same... we should join the cache cleaner thread once releasing the lock. Thanks again for identifying this case during reviews.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12708313/004-HDFS-7922.patch
        against trunk revision cce66ba.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestAuditLogs

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10123//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10123//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708313/004-HDFS-7922.patch against trunk revision cce66ba. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestAuditLogs The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10123//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10123//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        It looks like test case failure is not related to the patch.

        Show
        rakeshr Rakesh R added a comment - It looks like test case failure is not related to the patch.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Hi Rakesh R, I agree that the test failure looks unrelated. I was unable to reproduce it locally.

        +1. Committed to 2.8. Thanks again.

        Show
        cmccabe Colin P. McCabe added a comment - Hi Rakesh R , I agree that the test failure looks unrelated. I was unable to reproduce it locally. +1. Committed to 2.8. Thanks again.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7489 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7489/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7489 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7489/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #885 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/885/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #885 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/885/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/151/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/151/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2083 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2083/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2083 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2083/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/142/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/142/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/151/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/151/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2101 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2101/)
        HDFS-7922. ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2101 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2101/ ) HDFS-7922 . ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors (Rakesh R via Colin P. McCabe) (cmccabe: rev 3c7adaaf3571c91fee80585472d2a81402a53e2b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Colin P. McCabe for reviewing and committing the changes!

        Show
        rakeshr Rakesh R added a comment - Thanks Colin P. McCabe for reviewing and committing the changes!

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            rakeshr Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development