Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7922

ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha1
    • None
    • None

    Description

      ShortCircuitCache has the following executors. It would be good to shutdown these pools during ShortCircuitCache#close to avoid leaks.

        /**
         * The executor service that runs the cacheCleaner.
         */
        private final ScheduledThreadPoolExecutor cleanerExecutor
        = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
                setDaemon(true).setNameFormat("ShortCircuitCache_Cleaner").
                build());
      
        /**
         * The executor service that runs the cacheCleaner.
         */
        private final ScheduledThreadPoolExecutor releaserExecutor
            = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
                setDaemon(true).setNameFormat("ShortCircuitCache_SlotReleaser").
                build());
      

      Attachments

        1. 001-HDFS-7922.patch
          1 kB
          Rakesh Radhakrishnan
        2. 002-HDFS-7922.patch
          3 kB
          Rakesh Radhakrishnan
        3. 003-HDFS-7922.patch
          3 kB
          Rakesh Radhakrishnan
        4. 004-HDFS-7922.patch
          2 kB
          Rakesh Radhakrishnan

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rakeshr Rakesh Radhakrishnan
            rakeshr Rakesh Radhakrishnan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment