Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7894

Rolling upgrade readiness is not updated in jmx until query command is issued.

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When a hdfs rolling upgrade is started and a rollback image is created/uploaded, the active NN does not update its rollingUpgradeInfo until it receives a query command via RPC. This results in inconsistent info being showing up in the web UI and its jmx page.

      1. HDFS-7894.patch
        1.0 kB
        Brahma Reddy Battula
      2. HDFS-7894-002.patch
        1 kB
        Brahma Reddy Battula
      3. HDFS-7894-003.patch
        2 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          kihwal Kihwal Lee added a comment -

          In FSNamesystem#getRollingUpgradeStatus(), we can have it update the rollback image state like queryRollingUpgrade() does.

          Show
          kihwal Kihwal Lee added a comment - In FSNamesystem#getRollingUpgradeStatus() , we can have it update the rollback image state like queryRollingUpgrade() does.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Kihwal Lee Thanks for reporting this issue... Attached the patch, kindly review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Kihwal Lee Thanks for reporting this issue... Attached the patch, kindly review..
          Hide
          kihwal Kihwal Lee added a comment -

          It won't work because of checkSuperuserPrivilege() and checkOperation().
          What do you think about something like following? I didn't try to compile or test this code. Adding a test case would be nice, if possible.

              if (!isRollingUpgrade()) {
                return null; // this is the common case.
              }
              readLock();
              // check again after acquiring the read lock.
              RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo();
              if (upgradeInfo == null) {
                return null;
              }
              try {
                boolean hasRollbackImage = this.getFSImage().hasRollbackFSImage();
                upgradeInfo.setCreatedRollbackImages(hasRollbackImage);
              } finally {
                readUnlock();
              }
              return new RollingUpgradeInfo.Bean(upgradeInfo);
          
          Show
          kihwal Kihwal Lee added a comment - It won't work because of checkSuperuserPrivilege() and checkOperation() . What do you think about something like following? I didn't try to compile or test this code. Adding a test case would be nice, if possible. if (!isRollingUpgrade()) { return null ; // this is the common case . } readLock(); // check again after acquiring the read lock. RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo(); if (upgradeInfo == null ) { return null ; } try { boolean hasRollbackImage = this .getFSImage().hasRollbackFSImage(); upgradeInfo.setCreatedRollbackImages(hasRollbackImage); } finally { readUnlock(); } return new RollingUpgradeInfo.Bean(upgradeInfo);
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for your pointers,,Addressed your comments..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for your pointers,,Addressed your comments..
          Hide
          kihwal Kihwal Lee added a comment -

          I think you have to put the jira state to "patch available" for the precommit jenkins job to run against it.

          Show
          kihwal Kihwal Lee added a comment - I think you have to put the jira state to "patch available" for the precommit jenkins job to run against it.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thought of doing Once after your review...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thought of doing Once after your review.. .
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch
          against trunk revision 82db334.

          -1 patch. Trunk compilation may be broken.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9808//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch against trunk revision 82db334. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9808//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch
          against trunk revision d39bc90.

          -1 patch. Trunk compilation may be broken.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9818//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch against trunk revision d39bc90. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9818//console This message is automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          I will re-kick the build once it is fixed.

          Show
          kihwal Kihwal Lee added a comment - I will re-kick the build once it is fixed.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks!!!

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks!!!
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch
          against trunk revision 64eb068.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

          The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9825//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9825//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703295/HDFS-7894-002.patch against trunk revision 64eb068. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFileTruncate The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9825//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9825//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Test case failures are un-related to this patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Test case failures are un-related to this patch..
          Hide
          kihwal Kihwal Lee added a comment - - edited

          Brahma Reddy Battula It will be nice if you post a manual test result showing the jmx/webUI works correctly with the patch.

          Show
          kihwal Kihwal Lee added a comment - - edited Brahma Reddy Battula It will be nice if you post a manual test result showing the jmx/webUI works correctly with the patch.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          sure, I will update soon..thanks!!

          Show
          brahmareddy Brahma Reddy Battula added a comment - sure, I will update soon..thanks!!
          Hide
          vinayrpet Vinayakumar B added a comment -

          Patch looks good.
          Few nits:
          below part also should be inside try block. otherwise lock will never be released.

          +    // check again after acquiring the read lock.
               RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo();
          -    if (upgradeInfo != null) {
          -      return new RollingUpgradeInfo.Bean(upgradeInfo);
          +    if (upgradeInfo == null) {
          +      return null;
               }

          2.

          +      boolean hasRollbackImage = this.getFSImage().hasRollbackFSImage();
          +      upgradeInfo.setCreatedRollbackImages(hasRollbackImage);

          Here, this.getFSImage().hasRollbackFSImage(); will check for the image file presence on disk everytime query has passed. Actually this is required only if the flag is not set. Once its set, it will not be reset anyway until rollback/finalize.
          It could be like

          +      boolean hasRollbackImage = this.getFSImage().hasRollbackFSImage();
          +      upgradeInfo.setCreatedRollbackImages(hasRollbackImage);

          IMO below changes would do needful.

             @Override  // NameNodeMXBean
             public RollingUpgradeInfo.Bean getRollingUpgradeStatus() {
          +    if (!isRollingUpgrade()) {
          +      return null;
          +    }
               RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo();
          -    if (upgradeInfo != null) {
          +    if (upgradeInfo.createdRollbackImages()) {
                 return new RollingUpgradeInfo.Bean(upgradeInfo);
               }
          -    return null;
          +    readLock();
          +    try {
          +      // check again after acquiring the read lock.
          +      upgradeInfo = getRollingUpgradeInfo();
          +      if (upgradeInfo == null) {
          +        return null;
          +      }
          +      if (!upgradeInfo.createdRollbackImages()) {
          +        boolean hasRollbackImage = this.getFSImage().hasRollbackFSImage();
          +        upgradeInfo.setCreatedRollbackImages(hasRollbackImage);
          +      }
          +    } catch (IOException ioe) {
          +      LOG.warn("Encountered exception setting Rollback Image", ioe);
          +    } finally {
          +      readUnlock();
          +    }
          +    return new RollingUpgradeInfo.Bean(upgradeInfo);
             }

          Agree?

          Show
          vinayrpet Vinayakumar B added a comment - Patch looks good. Few nits: below part also should be inside try block. otherwise lock will never be released. + // check again after acquiring the read lock. RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo(); - if (upgradeInfo != null ) { - return new RollingUpgradeInfo.Bean(upgradeInfo); + if (upgradeInfo == null ) { + return null ; } 2. + boolean hasRollbackImage = this .getFSImage().hasRollbackFSImage(); + upgradeInfo.setCreatedRollbackImages(hasRollbackImage); Here, this.getFSImage().hasRollbackFSImage(); will check for the image file presence on disk everytime query has passed. Actually this is required only if the flag is not set. Once its set, it will not be reset anyway until rollback/finalize. It could be like + boolean hasRollbackImage = this .getFSImage().hasRollbackFSImage(); + upgradeInfo.setCreatedRollbackImages(hasRollbackImage); IMO below changes would do needful. @Override // NameNodeMXBean public RollingUpgradeInfo.Bean getRollingUpgradeStatus() { + if (!isRollingUpgrade()) { + return null ; + } RollingUpgradeInfo upgradeInfo = getRollingUpgradeInfo(); - if (upgradeInfo != null ) { + if (upgradeInfo.createdRollbackImages()) { return new RollingUpgradeInfo.Bean(upgradeInfo); } - return null ; + readLock(); + try { + // check again after acquiring the read lock. + upgradeInfo = getRollingUpgradeInfo(); + if (upgradeInfo == null ) { + return null ; + } + if (!upgradeInfo.createdRollbackImages()) { + boolean hasRollbackImage = this .getFSImage().hasRollbackFSImage(); + upgradeInfo.setCreatedRollbackImages(hasRollbackImage); + } + } catch (IOException ioe) { + LOG.warn( "Encountered exception setting Rollback Image" , ioe); + } finally { + readUnlock(); + } + return new RollingUpgradeInfo.Bean(upgradeInfo); } Agree?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks for taking a look into this issue,Yes, I will agree with you..Updated the patch,Please review the same..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks for taking a look into this issue,Yes, I will agree with you..Updated the patch,Please review the same..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12705575/HDFS-7894-003.patch
          against trunk revision 93d0f4a.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
          org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
          org.apache.hadoop.tracing.TestTracing
          org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9978//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9978//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705575/HDFS-7894-003.patch against trunk revision 93d0f4a. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery org.apache.hadoop.tracing.TestTracing org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9978//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9978//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Testcase failures are unrelated to this jira.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated to this jira.
          Hide
          kihwal Kihwal Lee added a comment -

          +1. The patch looks good. We've been running with this for a while.

          Show
          kihwal Kihwal Lee added a comment - +1. The patch looks good. We've been running with this for a while.
          Hide
          kihwal Kihwal Lee added a comment -

          Committed from trunk to branch-2.7. Thank you gentlemen for fixing and reviewing this.

          Show
          kihwal Kihwal Lee added a comment - Committed from trunk to branch-2.7. Thank you gentlemen for fixing and reviewing this.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7775 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7775/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7775 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7775/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
          HDFS-7894. Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) HDFS-7894 . Rolling upgrade readiness is not updated in jmx until query command is issued. Contributed by Brahma Reddy Battula. (kihwal: rev 6f622672b62aa8d719060063ef0e47480cdc8655) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Sangjin Lee backported this to 2.6.1, the patch applied cleanly.

          I just pushed the commit to 2.6.1 after running compilation.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Sangjin Lee backported this to 2.6.1, the patch applied cleanly. I just pushed the commit to 2.6.1 after running compilation.

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              kihwal Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development