Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8656

Preserve compatibility of ClientProtocol#rollingUpgrade after finalization

    Details

    • Target Version/s:

      Description

      HDFS-7645 changed rollingUpgradeInfo to still return an RUInfo after finalization, so the DNs can differentiate between rollback and a finalization. However, this breaks compatibility for the user facing APIs, which always expect a null after finalization. Let's fix this and edify it in unit tests.

      As an additional improvement, isFinalized and isStarted are part of the Java API, but not in the JMX output of RollingUpgradeInfo. It'd be nice to expose these booleans so JMX users don't need to do the != 0 check that possibly exposes our implementation details.

        Attachments

        1. hdfs-8656.001.patch
          12 kB
          Andrew Wang
        2. hdfs-8656.002.patch
          12 kB
          Andrew Wang
        3. hdfs-8656.003.patch
          11 kB
          Andrew Wang
        4. hdfs-8656.004.patch
          11 kB
          Andrew Wang

          Issue Links

            Activity

              People

              • Assignee:
                andrew.wang Andrew Wang
                Reporter:
                andrew.wang Andrew Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: