Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8656

Preserve compatibility of ClientProtocol#rollingUpgrade after finalization

    Details

    • Target Version/s:

      Description

      HDFS-7645 changed rollingUpgradeInfo to still return an RUInfo after finalization, so the DNs can differentiate between rollback and a finalization. However, this breaks compatibility for the user facing APIs, which always expect a null after finalization. Let's fix this and edify it in unit tests.

      As an additional improvement, isFinalized and isStarted are part of the Java API, but not in the JMX output of RollingUpgradeInfo. It'd be nice to expose these booleans so JMX users don't need to do the != 0 check that possibly exposes our implementation details.

      1. hdfs-8656.001.patch
        12 kB
        Andrew Wang
      2. hdfs-8656.002.patch
        12 kB
        Andrew Wang
      3. hdfs-8656.003.patch
        11 kB
        Andrew Wang
      4. hdfs-8656.004.patch
        11 kB
        Andrew Wang

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Patch attached, beefs up the tests. We return null now after finalization in user facing APIs (java and JMX) via a check to isRollingUpgrade(), but DNs can access it directly in the heartbeat response.

          Show
          andrew.wang Andrew Wang added a comment - Patch attached, beefs up the tests. We return null now after finalization in user facing APIs (java and JMX) via a check to isRollingUpgrade() , but DNs can access it directly in the heartbeat response.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741418/hdfs-8656.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 49dfad9
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11457/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741418/hdfs-8656.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 49dfad9 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11457/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Rebase on the new multi-SbNN support in trunk.

          Show
          andrew.wang Andrew Wang added a comment - Rebase on the new multi-SbNN support in trunk.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 30s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 24s The applied patch generated 1 new checkstyle issues (total was 310, now 309).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 15s Pre-build of native portion
          -1 hdfs tests 160m 47s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 17s Tests passed in hadoop-hdfs-client.
              209m 12s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741441/hdfs-8656.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 49dfad9
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11459/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11459/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 24s The applied patch generated 1 new checkstyle issues (total was 310, now 309). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 160m 47s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 17s Tests passed in hadoop-hdfs-client.     209m 12s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741441/hdfs-8656.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 49dfad9 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11459/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11459/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11459/console This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Patch LGTM,+1 ( non-binding).. Testcase failure is unrelated and checkstyle is about file length.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Patch LGTM,+1 ( non-binding).. Testcase failure is unrelated and checkstyle is about file length.
          Hide
          mingma Ming Ma added a comment -

          Andrew, when rolling upgrade isn't in progress, it seems JMX will have RollingUpgradeStatus set to null.

            @Override  // NameNodeMXBean
            public RollingUpgradeInfo.Bean getRollingUpgradeStatus() {
              if (!isRollingUpgrade()) {
                return null;
              }
            ....
            }
          

          If the intention is to provide RollingUpgradeInfo.Bean JMX output regardless of rolling upgrade state which could be "nothing has been scheduled", "in progress" or "finalized", then it seems the above function needs to be modified. If we do this, it will impact the JMX compatibility.

          Nit: Do we still need the Preconditions check given it has passed isRollingUpgrade check.

                if (!isRollingUpgrade()) {
                  return null;
                }
               Preconditions.checkNotNull(rollingUpgradeInfo);
          
          Show
          mingma Ming Ma added a comment - Andrew, when rolling upgrade isn't in progress, it seems JMX will have RollingUpgradeStatus set to null. @Override // NameNodeMXBean public RollingUpgradeInfo.Bean getRollingUpgradeStatus() { if (!isRollingUpgrade()) { return null; } .... } If the intention is to provide RollingUpgradeInfo.Bean JMX output regardless of rolling upgrade state which could be "nothing has been scheduled", "in progress" or "finalized", then it seems the above function needs to be modified. If we do this, it will impact the JMX compatibility. Nit: Do we still need the Preconditions check given it has passed isRollingUpgrade check. if (!isRollingUpgrade()) { return null; } Preconditions.checkNotNull(rollingUpgradeInfo);
          Hide
          mingma Ming Ma added a comment -

          To clarify what I meant. If the plan is still to return null for JMX output when rolling upgrade isn't in progress. then it appears isStarted will always be set to true and isFinalized will be set to false during rolling upgrade, thus wonder why we need those new properties.

          Show
          mingma Ming Ma added a comment - To clarify what I meant. If the plan is still to return null for JMX output when rolling upgrade isn't in progress. then it appears isStarted will always be set to true and isFinalized will be set to false during rolling upgrade, thus wonder why we need those new properties.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hey Ming, thanks for taking a look. Before HDFS-7645, we'd always return null if no RU was in progress or if the RU was finalized. HDFS-7645 changed this to still return an RUInfo after finalization, which is an incompatible change (but so far unreleased). I think this patch will make it return null again in this situation, restoring compatibility.

          Regarding the new fields, agreed, the new fields aren't that useful since they're always going to be the same. I'll post a new rev removing them.

          I'd like to leave the Precondition check as it's just for extra safety.

          Show
          andrew.wang Andrew Wang added a comment - Hey Ming, thanks for taking a look. Before HDFS-7645 , we'd always return null if no RU was in progress or if the RU was finalized. HDFS-7645 changed this to still return an RUInfo after finalization, which is an incompatible change (but so far unreleased). I think this patch will make it return null again in this situation, restoring compatibility. Regarding the new fields, agreed, the new fields aren't that useful since they're always going to be the same. I'll post a new rev removing them. I'd like to leave the Precondition check as it's just for extra safety.
          Hide
          andrew.wang Andrew Wang added a comment -

          Patch attached.

          Show
          andrew.wang Andrew Wang added a comment - Patch attached.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 11m 49s There were no new javadoc warning messages.
          +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 52s The applied patch generated 1 new checkstyle issues (total was 310, now 309).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 2m 2s mvn install still works.
          +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
          +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 58s Pre-build of native portion
          -1 hdfs tests 113m 0s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 19s Tests passed in hadoop-hdfs-client.
              166m 52s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.TestDFSClientRetries



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741748/hdfs-8656.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / a815cc1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11479/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11479/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 11m 49s There were no new javadoc warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 52s The applied patch generated 1 new checkstyle issues (total was 310, now 309). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 2m 2s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 58s Pre-build of native portion -1 hdfs tests 113m 0s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 19s Tests passed in hadoop-hdfs-client.     166m 52s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestDFSClientRetries Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741748/hdfs-8656.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a815cc1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11479/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11479/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11479/console This message was automatically generated.
          Hide
          mingma Ming Ma added a comment -

          Thanks, Andrew. Latest patch looks good. Nit: since you are modifying testDFSAdminDatanodeUpgradeControlCommands,

          Assert.assertEquals(0, dfsadmin.run(args1));
          

          can be:

                runCmd(dfsadmin, true, "-getDatanodeInfo", dnAddr);
          
          Show
          mingma Ming Ma added a comment - Thanks, Andrew. Latest patch looks good. Nit: since you are modifying testDFSAdminDatanodeUpgradeControlCommands, Assert.assertEquals(0, dfsadmin.run(args1)); can be: runCmd(dfsadmin, true, "-getDatanodeInfo", dnAddr);
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks again for reviewing Ming, fixed the nits. I didn't change the last assertEquals in that test to a runCmd, since there's value to checking the specific error return code.

          Show
          andrew.wang Andrew Wang added a comment - Thanks again for reviewing Ming, fixed the nits. I didn't change the last assertEquals in that test to a runCmd, since there's value to checking the specific error return code.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 57s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 49s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 25s The applied patch generated 1 new checkstyle issues (total was 310, now 309).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 15s Pre-build of native portion
          -1 hdfs tests 166m 44s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 16s Tests passed in hadoop-hdfs-client.
              216m 4s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.server.mover.TestMover
            org.apache.hadoop.security.TestPermissionSymlinks



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741998/hdfs-8656.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1403b84
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11492/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11492/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 49s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 25s The applied patch generated 1 new checkstyle issues (total was 310, now 309). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 166m 44s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 16s Tests passed in hadoop-hdfs-client.     216m 4s   Reason Tests Timed out tests org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.security.TestPermissionSymlinks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741998/hdfs-8656.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1403b84 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11492/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11492/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11492/console This message was automatically generated.
          Hide
          mingma Ming Ma added a comment -

          +1. Thanks Andrew. The unit test failures are unrelated.

          Show
          mingma Ming Ma added a comment - +1. Thanks Andrew. The unit test failures are unrelated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Pushed to trunk and branch-2, thanks Ming for reviewing!

          Show
          andrew.wang Andrew Wang added a comment - Pushed to trunk and branch-2, thanks Ming for reviewing!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8074 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8074/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8074 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8074/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #241 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/241/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #241 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/241/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #971 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/971/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #971 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/971/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/230/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/230/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2169/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2169/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/239/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/239/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2187/)
          HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2187/ ) HDFS-8656 . Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          Hide
          kihwal Kihwal Lee added a comment -

          I pulled this to branch-2.7 with HDFS-7645.

          Show
          kihwal Kihwal Lee added a comment - I pulled this to branch-2.7 with HDFS-7645 .

            People

            • Assignee:
              andrew.wang Andrew Wang
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development