[HDFS-7606] Missing null check in INodeFile#getBlocks() - ASF JIRA

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.0.0-alpha1
Fix Version/s: 2.7.0
Component/s: None
Labels:
None

Target Version/s:
Hadoop Flags:

Reviewed

Description

    BlockInfo[] snapshotBlocks = diff == null ? getBlocks() : diff.getBlocks();
    if(snapshotBlocks != null)
      return snapshotBlocks;
    // Blocks are not in the current snapshot
    // Find next snapshot with blocks present or return current file blocks
    snapshotBlocks = getDiffs().findLaterSnapshotBlocks(diff.getSnapshotId());

If diff is null and snapshotBlocks is null, NullPointerException would result from the call to diff.getSnapshotId().