Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-696

Java assertion failures triggered by tests

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None

      Description

      Re-purposing as catch-all ticket for assertion failures when running tests with java asserts enabled. Running with the attached patch on trunk@823732 the following tests all trigger assertion failures:

      TestAccessTokenWithDFS
      TestInterDatanodeProtocol
      TestBackupNode
      TestBlockUnderConstruction
      TestCheckpoint
      TestNameEditsConfigs
      TestStartup
      TestStorageRestore

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Summary Assert in chooseNodes fails when running TestAccessTokenWithDFS Java assertion failures triggered by tests
          Description Running TestAccessTokenWithDFS with java asserts enabled causes the following assert in chooseNodes in Balancer.java to faul.

              assert (datanodes.size() ==
                overUtilizedDatanodes.size()+underUtilizedDatanodes.size()+
                aboveAvgUtilizedDatanodes.size()+belowAvgUtilizedDatanodes.size()+
                sources.size()+targets.size())
                : "Mismatched number of datanodes";
          Re-purposing as catch-all ticket for assertion failures when running tests with java asserts enabled. Running with the attached patch on trunk@823732 the following tests all trigger assertion failures:
           
          TestAccessTokenWithDFS
          TestInterDatanodeProtocol
          TestBackupNode
          TestBlockUnderConstruction
          TestCheckpoint
          TestNameEditsConfigs
          TestStartup
          TestStorageRestore
          Eli Collins made changes -
          Attachment hadoop6309-hdfs.patch [ 12421907 ]
          Eli Collins made changes -
          Link This issue blocks HDFS-697 [ HDFS-697 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          TestBackupNode (HDFS-192) and TestBlockUnderConstruction (HDFS-682) are known to be failed. Are you sure that they are assert related?

          Show
          Tsz Wo Nicholas Sze added a comment - TestBackupNode ( HDFS-192 ) and TestBlockUnderConstruction ( HDFS-682 ) are known to be failed. Are you sure that they are assert related?
          Hide
          Eli Collins added a comment -

          Thanks Nicholas, you're right those two tests are failing for different reasons.

          Show
          Eli Collins added a comment - Thanks Nicholas, you're right those two tests are failing for different reasons.
          Hide
          Aaron Kimball added a comment -

          TestBalancer.testBalancer0 also fails due to assertion failures.

          Show
          Aaron Kimball added a comment - TestBalancer.testBalancer0 also fails due to assertion failures.
          Hide
          Eli Collins added a comment -

          Patch attached. Per MR-1092 made this a property of just the unit tests.

          Show
          Eli Collins added a comment - Patch attached. Per MR-1092 made this a property of just the unit tests.
          Eli Collins made changes -
          Attachment hdfs-696-1.patch [ 12443778 ]
          Eli Collins made changes -
          Attachment hdfs-696-1.patch [ 12443778 ]
          Hide
          Eli Collins added a comment -

          Ran all the tests with asserts enabled. Of all failures only TestHDFSConcat failed due to an assert firing, which is actually HDFS-1498 rather than a bug in the test, so I'll close this jira out.

              [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED
              [junit] Test org.apache.hadoop.hdfs.TestFileStatus FAILED
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestStorageRestore FAILED
              [junit] Test org.apache.hadoop.fs.TestHDFSFileContextMainOperations FAILED
              [junit] Test org.apache.hadoop.hdfs.TestPipelines FAILED
              [junit] Test org.apache.hadoop.hdfs.server.balancer.TestBalancer FAILED
              [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockReport FAILED
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS FAILED
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestFsck FAILED
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat FAILED
              [junit] Test org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer FAILED
          
          Show
          Eli Collins added a comment - Ran all the tests with asserts enabled. Of all failures only TestHDFSConcat failed due to an assert firing, which is actually HDFS-1498 rather than a bug in the test, so I'll close this jira out. [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED [junit] Test org.apache.hadoop.hdfs.TestFileStatus FAILED [junit] Test org.apache.hadoop.hdfs.server.namenode.TestStorageRestore FAILED [junit] Test org.apache.hadoop.fs.TestHDFSFileContextMainOperations FAILED [junit] Test org.apache.hadoop.hdfs.TestPipelines FAILED [junit] Test org.apache.hadoop.hdfs.server.balancer.TestBalancer FAILED [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockReport FAILED [junit] Test org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS FAILED [junit] Test org.apache.hadoop.hdfs.server.namenode.TestFsck FAILED [junit] Test org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat FAILED [junit] Test org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer FAILED
          Eli Collins made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Jakob Homan added a comment -

          It's after the fact, but +1. Eli, please update the components, versions, assignee, etc.

          Show
          Jakob Homan added a comment - It's after the fact, but +1. Eli, please update the components, versions, assignee, etc.
          Hide
          Eli Collins added a comment -

          Thanks Jakob. There's do you mean HDFS-697? There's no patch for this jira, I haven't checked the patch for HDFS-697 in yet.

          Show
          Eli Collins added a comment - Thanks Jakob. There's do you mean HDFS-697 ? There's no patch for this jira, I haven't checked the patch for HDFS-697 in yet.
          Eli Collins made changes -
          Assignee Eli Collins [ eli ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Component/s test [ 12312916 ]
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          397d 8h 37m 1 Eli Collins 14/Nov/10 05:14
          Resolved Resolved Closed Closed
          393d 1h 5m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development