[HDFS-6958] Fix the condition of reporting failures in BlockPoolSlice

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Duplicate
• Affects Version/s: 2.5.0
• Component/s: datanode
• Target Version/s: 2.6.0
• Assignee: Lei (Eddy) Xu
• Reporter: Lei (Eddy) Xu
• Created: 28/Aug/14 00:44
• Updated: 29/Aug/14 20:51
• Resolved: 29/Aug/14 20:51

Description

BlockPoolSlice#addToReplicsMap() should log the failure for the operation that deletes restart metadata file.

The current code did the opposite, log the failures on succeed deletion:

if (restartMeta.delete()) {
    FsDatasetImpl.LOG.warn("Failed to delete restart meta file: " +
              restartMeta.getPath());
}