Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6958

Fix the condition of reporting failures in BlockPoolSlice

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Duplicate
    • Affects Version/s: 2.5.0
    • Fix Version/s: None
    • Component/s: datanode
    • Labels:
      None
    • Target Version/s:

      Description

      BlockPoolSlice#addToReplicsMap() should log the failure for the operation that deletes restart metadata file.

      The current code did the opposite, log the failures on succeed deletion:

      if (restartMeta.delete()) {
          FsDatasetImpl.LOG.warn("Failed to delete restart meta file: " +
                    restartMeta.getPath());
      }
      
      1. HDFS-6958.000.patch
        0.9 kB
        Lei (Eddy) Xu

        Activity

        Hide
        Aaron T. Myers added a comment -

        +1 pending Jenkins.

        Show
        Aaron T. Myers added a comment - +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12664785/HDFS-6958.000.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
        org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7799//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7799//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664785/HDFS-6958.000.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7799//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7799//console This message is automatically generated.
        Hide
        Lei (Eddy) Xu added a comment -

        Aaron T. Myers These two failures are all related to balancer, which is not related to this patch.

        Show
        Lei (Eddy) Xu added a comment - Aaron T. Myers These two failures are all related to balancer, which is not related to this patch.
        Hide
        Aaron T. Myers added a comment -

        +1, patch looks good to me. It's fairly obviously trivially correct, so I don't think there's any need for a test on this one.

        I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, patch looks good to me. It's fairly obviously trivially correct, so I don't think there's any need for a test on this one. I'm going to commit this momentarily.
        Hide
        Lei (Eddy) Xu added a comment -

        It was fixed in HDFS-6774.

        Show
        Lei (Eddy) Xu added a comment - It was fixed in HDFS-6774 .

          People

          • Assignee:
            Lei (Eddy) Xu
            Reporter:
            Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development