[HDFS-6518] TestCacheDirectives#testExceedsCapacity should take FSN read lock when accessing pendingCached list

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.5.0
• Target Version/s: 2.5.0
• Assignee: Andrew Wang
• Reporter: Yongjun Zhang
• Created: 11/Jun/14 18:19
• Updated: 15/Aug/14 05:41
• Resolved: 16/Jun/14 22:48

Description

Observed from

https://builds.apache.org/job/PreCommit-HDFS-Build/7080//testReport/

Test
org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.testExceedsCapacity
fails intermittently

Failing for the past 1 build (Since Failed#7080 )
Took 7.3 sec.
Stacktrace

java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.checkPendingCachedEmpty(TestCacheDirectives.java:1416)
	at org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.testExceedsCapacity(TestCacheDirectives.java:1437)

A second run with the same code is successful,

https://builds.apache.org/job/PreCommit-HDFS-Build/7082//testReport/

Running it locally is also successful.

HDFS-6257 mentioned about possible race, maybe the issue is still there.

Thanks.

Issue Links

• is related to: HDFS-6257 TestCacheDirectives#testExceedsCapacity fails occasionally