Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6263

Remove DRFA.MaxBackupIndex config from log4j.properties

    Details

    • Type: Test Test
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.4.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      HDFS-side of HADOOP-10525.

      # uncomment the next line to limit number of backup files
      # log4j.appender.ROLLINGFILE.MaxBackupIndex=10
      

      In hadoop-hdfs/src/contrib/bkjournal/src/test/resources/log4j.properties, the above lines should be removed because the appender (DRFA) doesn't support MaxBackupIndex config.

      1. HDFS-6263.patch
        0.7 kB
        Abhiraj Butala

        Issue Links

          Activity

          Hide
          Abhiraj Butala added a comment -

          Attaching a simple patch to remove the config.

          Also, I noticed that in the same log4j.properties, the following two configs are defined twice at the end of the file:

          log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
          log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n
          

          The ConversionPattern is subtly different in the second definition. (First definition has extra '-' after '5p', while the second does not.)

          Is this by mistake? Should I just remove the redundant definitions? Please advise. Thanks!

          Show
          Abhiraj Butala added a comment - Attaching a simple patch to remove the config. Also, I noticed that in the same log4j.properties, the following two configs are defined twice at the end of the file: log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n The ConversionPattern is subtly different in the second definition. (First definition has extra '-' after '5p', while the second does not.) Is this by mistake? Should I just remove the redundant definitions? Please advise. Thanks!
          Hide
          Akira AJISAKA added a comment -

          Hi Abhiraj Butala, thanks for the patch. +1 (non-binding).

          Is this by mistake? Should I just remove the redundant definitions? Please advise. Thanks!

          I think it's a mistake. Let's file a JIRA and remove the redundant definitions. Thanks again for the report.

          Show
          Akira AJISAKA added a comment - Hi Abhiraj Butala , thanks for the patch. +1 (non-binding). Is this by mistake? Should I just remove the redundant definitions? Please advise. Thanks! I think it's a mistake. Let's file a JIRA and remove the redundant definitions. Thanks again for the report.
          Hide
          Abhiraj Butala added a comment -

          Thanks Akira AJISAKA, I have opened HDFS-6408 for the same and shall provide a patch there soon.

          Show
          Abhiraj Butala added a comment - Thanks Akira AJISAKA , I have opened HDFS-6408 for the same and shall provide a patch there soon.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12644953/HDFS-6263.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal:

          org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6908//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6908//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644953/HDFS-6263.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal: org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6908//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6908//console This message is automatically generated.
          Hide
          Akira AJISAKA added a comment -

          The test failure is not related to the patch. Filed HDFS-6419 for tracking the issue.

          Show
          Akira AJISAKA added a comment - The test failure is not related to the patch. Filed HDFS-6419 for tracking the issue.

            People

            • Assignee:
              Abhiraj Butala
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:

                Development