[HDFS-5956] A file size is multiplied by the replication factor in 'hdfs oiv -p FileDistribution' option

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.0-alpha1
• Fix Version/s: 2.4.0
• Component/s: tools
• Labels: newbie
• Target Version/s: 2.4.0
• Hadoop Flags: Reviewed
• Assignee: Akira Ajisaka
• Reporter: Akira Ajisaka
• Created: 15/Feb/14 00:06
• Updated: 12/May/16 18:18
• Resolved: 28/Feb/14 21:12

Description

In FileDistributionCalculator.java,

        long fileSize = 0;
        for (BlockProto b : f.getBlocksList()) {
          fileSize += b.getNumBytes() * f.getReplication();
        }
        maxFileSize = Math.max(fileSize, maxFileSize);
        totalSpace += fileSize;

should be

        long fileSize = 0;
        for (BlockProto b : f.getBlocksList()) {
          fileSize += b.getNumBytes();
        }
        maxFileSize = Math.max(fileSize, maxFileSize);
        totalSpace += fileSize * f.getReplication();

Issue Links

• is related to: HDFS-5866 '-maxSize' and '-step' option fail in OfflineImageViewer