[HDFS-4679] Namenode operation checks should be done in a consistent manner

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0-beta
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Suresh Srinivas
• Reporter: Suresh Srinivas
• Created: 09/Apr/13 19:47
• Updated: 25/Feb/14 19:49
• Resolved: 11/Apr/13 00:51

Description

Different operations performs checks in different order. I propose consistently checking the following in namenode operations:

1. Print debug log related to the operation
2. validate the input parameters, file names
3. Grab read or write lock
   • check if system is ready for read or write operation
   • check if system is in safemode (for write operations)
   • check permissions to see if the user is owner, has access or is super user privileges
4. Release the lock

Issue Links

• is related to: HDFS-6006 Remove duplicate code in FSNameSystem#getFileInfo