[HDFS-6006] Remove duplicate code in FSNameSystem#getFileInfo

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0
• Component/s: namenode
• Labels: newbie
• Target Version/s: 2.4.0
• Hadoop Flags: Reviewed
• Assignee: Akira Ajisaka
• Reporter: Akira Ajisaka
• Created: 24/Feb/14 21:19
• Updated: 04/Sep/14 01:15
• Resolved: 25/Feb/14 20:33

Description

In FSNameSystem#getFileInfo, it checks src file name two times.

    if (!DFSUtil.isValidName(src)) {
      throw new InvalidPathException("Invalid file name: " + src);
    }
    HdfsFileStatus stat = null;
    FSPermissionChecker pc = getPermissionChecker();
    checkOperation(OperationCategory.READ);
    if (!DFSUtil.isValidName(src)) {
      throw new InvalidPathException("Invalid file name: " + src);
    }

The latter should be removed.

Issue Links

• relates to: HDFS-4434 Provide a mapping from INodeId to INode
• relates to: HDFS-4679 Namenode operation checks should be done in a consistent manner