Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-4444

Add space between total transaction time and number of transactions in FSEditLog#printStatistics

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
    • Fix Version/s: 1.2.0, 2.0.3-alpha, 0.23.7
    • Component/s: None
    • Labels:
      None

      Description

      Currently, when we log statistics, we see something like

      13/01/25 23:16:59 INFO namenode.FSNamesystem: Number of transactions: 0 Total time for transactions(ms): 0Number of transactions batched in Syncs: 0 Number of syncs: 0 SyncTimes(ms): 0
      

      Notice how the value for total transactions time and "Number of transactions batched in Syncs" needs a space to separate them.

      FSEditLog#printStatistics:

        private void printStatistics(boolean force) {
          long now = now();
          if (lastPrintTime + 60000 > now && !force) {
            return;
          }
          lastPrintTime = now;
          StringBuilder buf = new StringBuilder();
          buf.append("Number of transactions: ");
          buf.append(numTransactions);
          buf.append(" Total time for transactions(ms): ");
          buf.append(totalTimeTransactions);
          buf.append("Number of transactions batched in Syncs: ");
          buf.append(numTransactionsBatchedInSync);
          buf.append(" Number of syncs: ");
          buf.append(editLogStream.getNumSync());
          buf.append(" SyncTimes(ms): ");
          buf.append(journalSet.getSyncTimes());
          LOG.info(buf);
        }
      

        Attachments

        1. HDFS-4444.patch.branch-1
          0.7 kB
          Stephen Chu
        2. HDFS-4444.patch.001
          0.9 kB
          Stephen Chu

          Issue Links

            Activity

              People

              • Assignee:
                schu Stephen Chu
                Reporter:
                schu Stephen Chu
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: