[HDFS-4444] Add space between total transaction time and number of transactions in FSEditLog#printStatistics

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
• Fix Version/s: 1.2.0, 2.0.3-alpha, 0.23.7
• Target Version/s: 2.0.0-alpha
• Hadoop Flags: Reviewed
• Assignee: Stephen Chu
• Reporter: Stephen Chu
• Created: 26/Jan/13 07:37
• Updated: 12/May/16 18:16
• Resolved: 28/Jan/13 19:00

Description

Currently, when we log statistics, we see something like

13/01/25 23:16:59 INFO namenode.FSNamesystem: Number of transactions: 0 Total time for transactions(ms): 0Number of transactions batched in Syncs: 0 Number of syncs: 0 SyncTimes(ms): 0

Notice how the value for total transactions time and "Number of transactions batched in Syncs" needs a space to separate them.

FSEditLog#printStatistics:

  private void printStatistics(boolean force) {
    long now = now();
    if (lastPrintTime + 60000 > now && !force) {
      return;
    }
    lastPrintTime = now;
    StringBuilder buf = new StringBuilder();
    buf.append("Number of transactions: ");
    buf.append(numTransactions);
    buf.append(" Total time for transactions(ms): ");
    buf.append(totalTimeTransactions);
    buf.append("Number of transactions batched in Syncs: ");
    buf.append(numTransactionsBatchedInSync);
    buf.append(" Number of syncs: ");
    buf.append(editLogStream.getNumSync());
    buf.append(" SyncTimes(ms): ");
    buf.append(journalSet.getSyncTimes());
    LOG.info(buf);
  }

Issue Links

• is related to: HDFS-4782 backport edit log corruption toleration to branch-1-win