[HDFS-4031] Update findbugsExcludeFile.xml to include findbugs 2 exclusions

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.3-alpha
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 10/Oct/12 23:12
• Updated: 15/Feb/13 13:12
• Resolved: 08/Jan/13 21:49

Description

Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029 and HDFS-4030 are less problematic:

• numFailedVolumes is only incremented in one thread and that access is synchronized
• pendingReceivedRequests in BPServiceActor is clearly synchronized
  It would be reasonable to make these Atomics as well but I think they're uses are clearly correct so figured for these the warning was more obviously bogus and so could be ignored.

There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize LocalDatanodeInfo.