Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-4014 Fix warnings found by findbugs2
  3. HDFS-4031

Update findbugsExcludeFile.xml to include findbugs 2 exclusions

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.3-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029 and HDFS-4030 are less problematic:

      • numFailedVolumes is only incremented in one thread and that access is synchronized
      • pendingReceivedRequests in BPServiceActor is clearly synchronized
        It would be reasonable to make these Atomics as well but I think they're uses are clearly correct so figured for these the warning was more obviously bogus and so could be ignored.

      There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize LocalDatanodeInfo.

        Attachments

        1. hdfs-4031.txt
          1 kB
          Eli Collins

          Activity

            People

            • Assignee:
              eli Eli Collins
              Reporter:
              eli Eli Collins

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment