VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0-alpha
    • 2.0.3-alpha
    • namenode
    • None
    • Reviewed

    Description

      GenerationStamp#genstamp is a volatile long. Incrementing volatiles is not thread safe, which is currently not an issue because the only increment is done in nextStamp which is synchronized (theoretically setStamp could race with nextStamp though that wouldn't happen given the current code). It would be cleaner to use an AtomicLong so that genstamp itself is atomic and we don't have to synchronize the various accesses to it.

      Attachments

        1. hdfs-4029.txt
          3 kB
          Eli Collins

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            eli Eli Collins
            eli Eli Collins
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment