VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.3-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      GenerationStamp#genstamp is a volatile long. Incrementing volatiles is not thread safe, which is currently not an issue because the only increment is done in nextStamp which is synchronized (theoretically setStamp could race with nextStamp though that wouldn't happen given the current code). It would be cleaner to use an AtomicLong so that genstamp itself is atomic and we don't have to synchronize the various accesses to it.

        Attachments

        1. hdfs-4029.txt
          3 kB
          Eli Collins

          Activity

            People

            • Assignee:
              eli Eli Collins
              Reporter:
              eli Eli Collins

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment