Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3817

avoid printing stack information for SafeModeException

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 1.2.0, 0.23.7, 2.1.0-beta
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When NN is in safemode, any namespace change request could cause a SafeModeException to be thrown and logged in the server log, which can make the server side log grow very quickly.

      The server side log can be more concise if only the exception and error message will be printed but not the stack trace.

      1. HDFS-3817.patch
        0.9 kB
        Brandon Li
      2. HDFS-3817.branch-1.patch
        0.9 kB
        Brandon Li

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1d 4h 21m 1 Suresh Srinivas 21/Aug/12 20:58
          Patch Available Patch Available Resolved Resolved
          17h 2m 1 Suresh Srinivas 22/Aug/12 14:00
          Resolved Resolved Closed Closed
          265d 15h 15m 1 Matt Foley 15/May/13 05:16
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Suresh Srinivas made changes -
          Fix Version/s 1.2.0 [ 12321657 ]
          Fix Version/s 3.0.0 [ 12320356 ]
          Hide
          Suresh Srinivas added a comment -

          I have committed the branch-1 patch to branch-1 and branch-1.2. Thank you Brandon.

          Show
          Suresh Srinivas added a comment - I have committed the branch-1 patch to branch-1 and branch-1.2. Thank you Brandon.
          Hide
          Suresh Srinivas added a comment -

          +1 for the branch-1 patch.

          Show
          Suresh Srinivas added a comment - +1 for the branch-1 patch.
          Hide
          Brandon Li added a comment -

          Uploaded a branch-1 patch.

          Show
          Brandon Li added a comment - Uploaded a branch-1 patch.
          Brandon Li made changes -
          Attachment HDFS-3817.branch-1.patch [ 12581534 ]
          Kihwal Lee made changes -
          Fix Version/s 2.0.5-beta [ 12324031 ]
          Kihwal Lee made changes -
          Link This issue relates to HDFS-4714 [ HDFS-4714 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/)
          svn merge -c 1376054 Merging from truk to branch-0.23 to fix HDFS-3817. (Revision 1454588)

          Result = SUCCESS
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454588
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/ ) svn merge -c 1376054 Merging from truk to branch-0.23 to fix HDFS-3817 . (Revision 1454588) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454588 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Kihwal Lee made changes -
          Fix Version/s 0.23.7 [ 12323955 ]
          Hide
          Kihwal Lee added a comment -

          Merged to branch-0.23. The only merge conflict was from the name of rpc server introduced by HDFS-2481.

          Is there any reason not to pull this and HADOOP-8711 to branch-2?

          Show
          Kihwal Lee added a comment - Merged to branch-0.23. The only merge conflict was from the name of rpc server introduced by HDFS-2481 . Is there any reason not to pull this and HADOOP-8711 to branch-2?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/)
          HDFS-3817. Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1175/ ) HDFS-3817 . Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1143 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1143/)
          HDFS-3817. Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1143 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1143/ ) HDFS-3817 . Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2646 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2646/)
          HDFS-3817. Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2646 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2646/ ) HDFS-3817 . Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2680 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2680/)
          HDFS-3817. Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2680 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2680/ ) HDFS-3817 . Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2616 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2616/)
          HDFS-3817. Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2616 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2616/ ) HDFS-3817 . Avoid printing SafeModeException stack trace in RPC server. Contributed by Brandon Li. (Revision 1376054) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376054 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 3.0.0 [ 12320356 ]
          Resolution Fixed [ 1 ]
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to trunk. Thank you Brandon.

          Show
          Suresh Srinivas added a comment - I committed the patch to trunk. Thank you Brandon.
          Hide
          Suresh Srinivas added a comment -

          +1 for the trivial patch. No tests are needed as HADOOP-8711 adds test for this functionality.

          Show
          Suresh Srinivas added a comment - +1 for the trivial patch. No tests are needed as HADOOP-8711 adds test for this functionality.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12541789/HDFS-3817.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestReplication

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3057//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3057//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541789/HDFS-3817.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestReplication +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3057//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3057//console This message is automatically generated.
          Suresh Srinivas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Brandon Li made changes -
          Attachment HDFS-3817.patch [ 12541789 ]
          Brandon Li made changes -
          Link This issue is related to HADOOP-8711 [ HADOOP-8711 ]
          Brandon Li made changes -
          Affects Version/s 3.0.0 [ 12320356 ]
          Component/s name-node [ 12312926 ]
          Brandon Li made changes -
          Description When NN is in safemode, any namespace change request could cause a SafeModeException to be thrown and logged in the server log, which can make the server side log grow very quickly.

          The server side log can be more concise if only the exception and error message will be printed but not the stack track.
          When NN is in safemode, any namespace change request could cause a SafeModeException to be thrown and logged in the server log, which can make the server side log grow very quickly.

          The server side log can be more concise if only the exception and error message will be printed but not the stack trace.
          Brandon Li made changes -
          Field Original Value New Value
          Description When NN is in safemode, any namespace change request could cause a SafeModeException to be thrown and logged in the server log, which can make the server side log grow very quickly.

          The server side log can be more concise if only print the exception and error message will be printed but not the stack track.
          When NN is in safemode, any namespace change request could cause a SafeModeException to be thrown and logged in the server log, which can make the server side log grow very quickly.

          The server side log can be more concise if only the exception and error message will be printed but not the stack track.
          Brandon Li created issue -

            People

            • Assignee:
              Brandon Li
              Reporter:
              Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development