Uploaded the whole patch to show the idea, and the HDFS changes will be moved to HDFS-3817 before commit.

Comments:

1. DFSUtil method seems unnecessary.
2. Name terseException to terseExceptions. It should be made volatile.
3. It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.hdfs.TestPersistBlocks

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//console

This message is automatically generated.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//console

This message is automatically generated.

Thanks Suresh for reviewing the patch.

DFSUtil method seems unnecessary.

change removed

Name terseException to terseExceptions. It should be made volatile.

done

It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc.

done

New patch is uploaded.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541711/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.ipc.TestRPC
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
org.apache.hadoop.hdfs.TestPersistBlocks

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//console

This message is automatically generated.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541714/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.TestDatanodeBlockScanner

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//console

This message is automatically generated.

Couple of comments:

1. Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public.
2. Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions().

Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public.
Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions().

Done. Thanks!

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541766/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.server.namenode.TestCheckpoint

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//console

This message is automatically generated.

The test failure is not introduced by this patch and it passed in my local tests.

Uploaded the patch with only changes of Common.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541788/HADOOP-8711.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//console

This message is automatically generated.

I committed the patch. Thank you Brandon.

Integrated in Hadoop-Mapreduce-trunk-Commit #2643 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2643/)
HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Integrated in Hadoop-Hdfs-trunk-Commit #2678 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2678/)
HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Integrated in Hadoop-Common-trunk-Commit #2614 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2614/)
HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Integrated in Hadoop-Hdfs-trunk #1142 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1142/)
HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Integrated in Hadoop-Mapreduce-trunk #1174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1174/)
HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Merged to branch-0.23. There were merge conflicts due to absence of HA in 0.23, but resolution was straightforward.

Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/)
svn merge -c 1375790 Merging from trunk to branch-0.23 to fix HADOOP-8711. (Revision 1454534)

Result = SUCCESS
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454534
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java

Committed to branch-2 as HDFS-4714 depends on it.

Thanks Kihwal!
This patch could be useful for banch-1 too. Just uploaded a patch for branch-1.

Can you add a test case to the patch?

Can you add a test case to the patch?

Given trunk, branch-2 and 0.23 versions have gone without the tests, lets address it in another jira and ensure that jira/patch gets committed to all the branches to which HADOOP-8711 is committed to

Trunk and other branches have a small additional test case in TestServer.java, which came with this jira.

Also, the branch-1 patch seems to include HDFS-3817. Suresh, do you think it should be separated out?

Trunk and other branches have a small additional test case in TestServer.java, which came with this jira.

Sorry missed that.

I agree. It is a good idea to do hdfs part in separate Jira as well.

Brandon can you please split this into two separate patches?

Thanks for the reminder.
The patch is split into two. A branch-1 patch is uploaded in HDFS-3817. One is uploaded for this JIRA. This JIRA's new branch-1 patch includes a unit test now.

+1 for the branch-1 patch. Thanks Brandon.

I committed the patch to branch-1 and branch-1.2.

Closed upon release of Hadoop 1.2.0.