Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8711

provide an option for IPC server users to avoid printing stack information for certain exceptions

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 3.0.0-alpha1
        • Fix Version/s: 1.2.0, 0.23.7, 2.1.0-beta
        • Component/s: ipc
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Currently it's hard coded in the server that it doesn't print the exception stack for StandbyException.

          Similarly, other components may have their own exceptions which don't need to save the stack trace in log. One example is HDFS-3817.

          1. File
            HADOOP-8711.branch-1.patch.2
            5 kB
            Brandon Li
          2. Text File
            HADOOP-8871.branch-1.patch
            4 kB
            Brandon Li
          3. Text File
            HADOOP-8711.patch
            4 kB
            Brandon Li
          4. Text File
            HADOOP-8711.patch
            5 kB
            Brandon Li
          5. Text File
            HADOOP-8711.patch
            5 kB
            Brandon Li
          6. Text File
            HADOOP-8711.patch
            4 kB
            Brandon Li
          7. Text File
            HADOOP-8711.patch
            4 kB
            Brandon Li

            Issue Links

            is depended upon by

            Bug - A problem which impairs or prevents the functions of the product. HDFS-4714 Log short messages in Namenode RPC server for exceptions meant for clients

            • Major - Major loss of function.
            • Closed
            relates to

            Improvement - An improvement or enhancement to an existing feature or task. HDFS-3817 avoid printing stack information for SafeModeException

            • Major - Major loss of function.
            • Closed

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              mattf Matt Foley added a comment -

              Closed upon release of Hadoop 1.2.0.

              Show
              mattf Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              I committed the patch to branch-1 and branch-1.2.

              Show
              sureshms Suresh Srinivas added a comment - I committed the patch to branch-1 and branch-1.2.
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              +1 for the branch-1 patch. Thanks Brandon.

              Show
              sureshms Suresh Srinivas added a comment - +1 for the branch-1 patch. Thanks Brandon.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Thanks for the reminder.
              The patch is split into two. A branch-1 patch is uploaded in HDFS-3817. One is uploaded for this JIRA. This JIRA's new branch-1 patch includes a unit test now.

              Show
              brandonli Brandon Li added a comment - Thanks for the reminder. The patch is split into two. A branch-1 patch is uploaded in HDFS-3817 . One is uploaded for this JIRA. This JIRA's new branch-1 patch includes a unit test now.
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              Brandon can you please split this into two separate patches?

              Show
              sureshms Suresh Srinivas added a comment - Brandon can you please split this into two separate patches?
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              Trunk and other branches have a small additional test case in TestServer.java, which came with this jira.

              Sorry missed that.

              I agree. It is a good idea to do hdfs part in separate Jira as well.

              Show
              sureshms Suresh Srinivas added a comment - Trunk and other branches have a small additional test case in TestServer.java, which came with this jira. Sorry missed that. I agree. It is a good idea to do hdfs part in separate Jira as well.
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Also, the branch-1 patch seems to include HDFS-3817. Suresh, do you think it should be separated out?

              Show
              kihwal Kihwal Lee added a comment - Also, the branch-1 patch seems to include HDFS-3817 . Suresh, do you think it should be separated out?
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Trunk and other branches have a small additional test case in TestServer.java, which came with this jira.

              Show
              kihwal Kihwal Lee added a comment - Trunk and other branches have a small additional test case in TestServer.java, which came with this jira.
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              Can you add a test case to the patch?

              Given trunk, branch-2 and 0.23 versions have gone without the tests, lets address it in another jira and ensure that jira/patch gets committed to all the branches to which HADOOP-8711 is committed to

              Show
              sureshms Suresh Srinivas added a comment - Can you add a test case to the patch? Given trunk, branch-2 and 0.23 versions have gone without the tests, lets address it in another jira and ensure that jira/patch gets committed to all the branches to which HADOOP-8711 is committed to
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Can you add a test case to the patch?

              Show
              kihwal Kihwal Lee added a comment - Can you add a test case to the patch?
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Thanks Kihwal!
              This patch could be useful for banch-1 too. Just uploaded a patch for branch-1.

              Show
              brandonli Brandon Li added a comment - Thanks Kihwal! This patch could be useful for banch-1 too. Just uploaded a patch for branch-1.
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Committed to branch-2 as HDFS-4714 depends on it.

              Show
              kihwal Kihwal Lee added a comment - Committed to branch-2 as HDFS-4714 depends on it.
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/)
              svn merge -c 1375790 Merging from trunk to branch-0.23 to fix HADOOP-8711. (Revision 1454534)

              Result = SUCCESS
              kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454534
              Files :

              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/ ) svn merge -c 1375790 Merging from trunk to branch-0.23 to fix HADOOP-8711 . (Revision 1454534) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454534 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Merged to branch-0.23. There were merge conflicts due to absence of HA in 0.23, but resolution was straightforward.

              Show
              kihwal Kihwal Lee added a comment - Merged to branch-0.23. There were merge conflicts due to absence of HA in 0.23, but resolution was straightforward.
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1174/)
              HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

              Result = FAILURE
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1174/ ) HADOOP-8711 . IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1142 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1142/)
              HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

              Result = FAILURE
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1142 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1142/ ) HADOOP-8711 . IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #2614 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2614/)
              HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2614 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2614/ ) HADOOP-8711 . IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #2678 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2678/)
              HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

              Result = SUCCESS
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2678 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2678/ ) HADOOP-8711 . IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #2643 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2643/)
              HADOOP-8711. IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790)

              Result = FAILURE
              suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Show
              hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2643 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2643/ ) HADOOP-8711 . IPC Server supports adding exceptions for which the message is printed and the stack trace is not printed to avoid chatter. Contributed by Brandon Li. (Revision 1375790) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375790 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              I committed the patch. Thank you Brandon.

              Show
              sureshms Suresh Srinivas added a comment - I committed the patch. Thank you Brandon.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              +1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541788/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541788/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1343//console This message is automatically generated.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Uploaded the patch with only changes of Common.

              Show
              brandonli Brandon Li added a comment - Uploaded the patch with only changes of Common.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              The test failure is not introduced by this patch and it passed in my local tests.

              Show
              brandonli Brandon Li added a comment - The test failure is not introduced by this patch and it passed in my local tests.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541766/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.hdfs.server.namenode.TestCheckpoint

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541766/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestCheckpoint +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1341//console This message is automatically generated.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public.
              Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions().

              Done. Thanks!

              Show
              brandonli Brandon Li added a comment - Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public. Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions(). Done. Thanks!
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              Couple of comments:

              1. Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public.
              2. Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions().
              Show
              sureshms Suresh Srinivas added a comment - Couple of comments: Please add brief javadoc for ExceptionsHandler class. Also please make the class package private instead of public. Please do not make Server#exceptionsHandler public. Instead add a method Server#addTerseExceptions().
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541714/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.hdfs.TestDatanodeBlockScanner

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541714/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1337//console This message is automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541711/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.ha.TestZKFailoverController
              org.apache.hadoop.ipc.TestRPC
              org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
              org.apache.hadoop.hdfs.TestPersistBlocks

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541711/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.ipc.TestRPC org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1336//console This message is automatically generated.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Thanks Suresh for reviewing the patch.

              DFSUtil method seems unnecessary.

              change removed

              Name terseException to terseExceptions. It should be made volatile.

              done

              It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc.

              done

              New patch is uploaded.

              Show
              brandonli Brandon Li added a comment - Thanks Suresh for reviewing the patch. DFSUtil method seems unnecessary. change removed Name terseException to terseExceptions. It should be made volatile. done It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc. done New patch is uploaded.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1335//console This message is automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.ha.TestZKFailoverController
              org.apache.hadoop.hdfs.TestPersistBlocks

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541665/HADOOP-8711.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1334//console This message is automatically generated.
              Hide
              Permalink
              sureshms Suresh Srinivas added a comment -

              Comments:

              1. DFSUtil method seems unnecessary.
              2. Name terseException to terseExceptions. It should be made volatile.
              3. It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc.
              Show
              sureshms Suresh Srinivas added a comment - Comments: DFSUtil method seems unnecessary. Name terseException to terseExceptions. It should be made volatile. It would be good add unit test. For that reason it may be good to organize the code, where you could have an inner class TerseExceptions with methods, add(), isTerse() etc.
              Hide
              Permalink
              brandonli Brandon Li added a comment -

              Uploaded the whole patch to show the idea, and the HDFS changes will be moved to HDFS-3817 before commit.

              Show
              brandonli Brandon Li added a comment - Uploaded the whole patch to show the idea, and the HDFS changes will be moved to HDFS-3817 before commit.

                People

                • Assignee:
                  brandonli Brandon Li
                  Reporter:
                  brandonli Brandon Li
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development