Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Somewhere in the later stages of HDFS-2834 I accidentally left TestParallelLocalRead out of the patch, and we didn't catch it before it got checked in.

      Here's that file, which provides test coverage for shortcircuit local reads using the copying and non-copying paths.

      1. HDFS-3514.patch
        3 kB
        Henry Robinson

        Activity

        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531136/HDFS-3514.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2606//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2606//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531136/HDFS-3514.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2606//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2606//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531136/HDFS-3514.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2620//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2620//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531136/HDFS-3514.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2620//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2620//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'm confident the test failure is unrelated. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I'm confident the test failure is unrelated. I'm going to commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk. Thanks a lot for the contribution, Hank.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk. Thanks a lot for the contribution, Hank.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2338 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2338/)
        HDFS-3514. Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2338 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2338/ ) HDFS-3514 . Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2411/)
        HDFS-3514. Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2411/ ) HDFS-3514 . Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2358 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2358/)
        HDFS-3514. Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2358 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2358/ ) HDFS-3514 . Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 as well.

        Show
        Todd Lipcon added a comment - Committed to branch-2 as well.
        Hide
        Todd Lipcon added a comment -

        BTW, I filed HDFS-3519 for the test failure seen in the above test-patch build (agree it's entirely unrelated to this patch)

        Show
        Todd Lipcon added a comment - BTW, I filed HDFS-3519 for the test failure seen in the above test-patch build (agree it's entirely unrelated to this patch)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1072/)
        HDFS-3514. Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1072/ ) HDFS-3514 . Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1105 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1105/)
        HDFS-3514. Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1105 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1105/ ) HDFS-3514 . Add missing TestParallelLocalRead. Contributed by Henry Robinson. (Revision 1348207) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348207 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelLocalRead.java

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development